summaryrefslogtreecommitdiffstats
path: root/Source/CTest
Commit message (Collapse)AuthorAgeFilesLines
* IWYU: Add missing cstddef includes for size_t and nullptr_tBrad King2019-09-031-0/+1
| | | | The IWYU tool we use for CI now diagnoses these.
* cmCTestTestHandler: Re-order includes to follow our conventionBrad King2019-09-031-16/+17
|
* Merge topic 'pvs-cleanup'Brad King2019-08-263-5/+6
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7fe3e874d5 cmCPackLog: Fix support for multiple log message tags 74f2c0ea56 cmCTestTestHandler: Remove extra layer of parentheses 7c2767ef3b cmCTestMultiProcessHandler: Explain testRun ownership in comments 303e813438 CTest: Simplify some boolean conditions 51565abe79 cmMessageCommand: Remove extra layer of parentheses b1cfaf7b91 cmVSSetupHelper: Remove unused SmartBSTR copy operations 3f4c4e7afe cmVSSetupHelper: Fix SmartBSTR copy operations a8ca5aea94 cmMakefileTargetGenerator: Check for null before using a pointer ... Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: Daniel Pfeifer <daniel@pfeifer-mail.de> Acked-by: Artalus <artalus-mail@yandex.ru> Merge-request: !3715
| * cmCTestTestHandler: Remove extra layer of parenthesesBrad King2019-08-261-1/+1
| | | | | | | | | | | | | | | | A condition in `ComputeTestListForRerunFailed` contained an extra layer of parentheses. Remove them. The condition itself is correct because an empty list means "all tests" so we want to include the current test. Issue: #19610
| * cmCTestMultiProcessHandler: Explain testRun ownership in commentsBrad King2019-08-261-0/+3
| | | | | | | | | | | | | | | | The ownership semantics of the 'testRun' variable are subtle and may fool static analysers. Add comments explaining them for now. Later some refactoring could be done to clarify the code. Issue: #19610
| * CTest: Simplify some boolean conditionsBrad King2019-08-262-4/+2
| | | | | | | | | | | | | | Directly compare two boolean values instead of spelling out accepted combinations. Issue: #19610
* | Merge topic 'source_sweep_ostringstream_single'Brad King2019-08-265-23/+15
|\ \ | | | | | | | | | | | | | | | | | | 3b2b02825d Source sweep: Replace std::ostringstream when used with a single append Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !3726
| * | Source sweep: Replace std::ostringstream when used with a single appendSebastian Holtermann2019-08-235-23/+15
| | | | | | | | | | | | | | | | | | | | | This replaces `std::ostringstream`, when it is written to only once. If the single written argument was numeric, `std::to_string` is used instead. Otherwise, the single written argument is used directly instead of the `std::ostringstream::str()` invocation.
* | | Merge topic 'source_sweep_cmExpandedList'Brad King2019-08-266-40/+20
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | aaf59120bf Source sweep: Replace cmExpandList with the shorter cmExpandedList Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !3725
| * | | Source sweep: Replace cmExpandList with the shorter cmExpandedListSebastian Holtermann2019-08-236-40/+20
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This replaces the code pattern ``` std::vector<std::string> args; cmExpandList(valueStr, args, ...) ``` with ``` std::vector<std::string> args = cmExpandedList(valueStr, ...) ```
* | | Merge topic 'group_not_track'Brad King2019-08-262-9/+16
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2a71a0390c ctest: rename TRACK to GROUP Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: Zack Galbreath <zack.galbreath@kitware.com> Merge-request: !3707
| * | | ctest: rename TRACK to GROUPZack Galbreath2019-08-222-9/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Update command-line options, script variables, and documentation to use the term "group" instead of "track". The old terms are still available for now, but they are now undocumented. This makes our terminology more consistent with CDash. The goal of this change is to make it more clear to our users how CTest and CDash interact with each other.
* | | | Merge topic 'warnings_skip_color'Brad King2019-08-262-9/+22
|\ \ \ \ | |_|/ / |/| | | | | | | | | | | | | | | | | | | 2079267959 ctest_build: ignore ANSI color Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !3702
| * | | ctest_build: ignore ANSI colorZack Galbreath2019-08-222-9/+22
| | | | | | | | | | | | | | | | Ignore ANSI color when scraping logs for errors and warnings
* | | | Merge topic 'ctest-json-REQUIRED_FILES'Brad King2019-08-231-2/+2
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5778880d20 CTest: Fix --show-only=json-v1 output with REQUIRED_FILES property Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !3719
| * | | | CTest: Fix --show-only=json-v1 output with REQUIRED_FILES propertyBrad King2019-08-221-2/+2
| | | | | | | | | | | | | | | | | | | | Fixes: #19629
* | | | | Source sweep: Use cmStrCat for string concatenationSebastian Holtermann2019-08-2220-188/+110
| |_|_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch is generated by a python script that uses regular expressions to search for string concatenation patterns of the kind ``` std::string str = <ARG0>; str += <ARG1>; str += <ARG2>; ... ``` and replaces them with a single `cmStrCat` call ``` std::string str = cmStrCat(<ARG0>, <ARG1>, <ARG2>, ...); ``` If any `<ARGX>` is itself a concatenated string of the kind ``` a + b + c + ...; ``` then `<ARGX>` is split into multiple arguments for the `cmStrCat` call. If there's a sequence of literals in the `<ARGX>`, then all literals in the sequence are concatenated and merged into a single literal argument for the `cmStrCat` call. Single character strings are converted to single char arguments for the `cmStrCat` call. `std::to_string(...)` wrappings are removed from `cmStrCat` arguments, because it supports numeric types as well as string types. `arg.substr(x)` arguments to `cmStrCat` are replaced with `cm::string_view(arg).substr(x)`
* | | | Merge topic 'cm-contains'Brad King2019-08-212-25/+14
|\ \ \ \ | |_|_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | 2dfc52675c cmAlgorithms: Add cmContains Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: Sebastian Holtermann <sebholt@web.de> Acked-by: Daniel Pfeifer <daniel@pfeifer-mail.de> Merge-request: !3700
| * | | cmAlgorithms: Add cmContainsRegina Pfeifer2019-08-192-25/+14
| | |/ | |/| | | | | | | Also, use the new function where applicable.
* | | Merge topic 'string-literal-append'Brad King2019-08-192-4/+2
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | da26b3be89 avoid adding multiple consecutive string literals to std::string Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !3698
| * | | avoid adding multiple consecutive string literals to std::stringRolf Eike Beer2019-08-182-4/+2
| |/ / | | | | | | | | | While at it change some single character additions to be of type char.
* | | Source sweep: Use cmIsOn instead of cmSystemTools::IsOnSebastian Holtermann2019-08-175-13/+13
|/ / | | | | | | | | | | | | | | | | This replaces invocations of - `cmSystemTools::IsInternallyOn` with `cmIsInternallyOn` - `cmSystemTools::IsNOTFOUND` with `cmIsNOTFOUND` - `cmSystemTools::IsOn` with `cmIsOn` - `cmSystemTools::IsOff` with `cmIsOff`
* | Merge topic 'cmExpandList'Kyle Edwards2019-08-168-31/+32
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | 2f6495e24e cmSystemTools: Remove ExpandListArgument methods f4f3c68926 Source code: Use cmExpandList instead of cmSystemTools::ExpandListArgument ff42dec891 cmStringAlgorithms: Add cmExpandList functions Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !3682
| * | Source code: Use cmExpandList instead of cmSystemTools::ExpandListArgumentSebastian Holtermann2019-08-148-31/+32
| | |
* | | Merge topic 'cmStringAlgorithms_ulong'Kyle Edwards2019-08-164-11/+8
|\ \ \ | |/ / |/| | | | | | | | | | | | | | 935fbe0b04 cmStringAlgorithms: Add cmStrToLong and cmStrToULong Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !3681
| * | cmStringAlgorithms: Add cmStrToLong and cmStrToULongSebastian Holtermann2019-08-104-11/+8
| | | | | | | | | | | | | | | | | | | | | | | | This adds the following functions to cmStringAlgorithms: - `cmStrToLong`: moved from `cmSystemTools::StringToLong` - `cmStrToULong`: moved from `cmSystemTools::StringToULong` Overloads of the given functions for `std::string` are added as well.
* | | Refactor: Convert all instances of CMAKE_BUILD_WITH_CMAKE to CMAKE_BOOTSTRAPKitware Robot2019-08-092-2/+2
|/ /
* | clang-tidy: Enable performance-inefficient-string-concatenationSebastian Holtermann2019-08-055-17/+13
| | | | | | | | | | | | | | Enables the clang-tidy test performance-inefficient-string-concatenation and replaces all inefficient string concatenations with `cmStrCat`. Closes: #19555
* | Merge topic 'control-block3'Brad King2019-08-051-31/+2
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 41364824ad cmFunctionBlocker: Recycle functions 6491270e0d cmFunctionBlocker: Move check for matching args af24e4ef6e cmFunctionBlocker: Move common logic to base ef38ff22f7 cm*FunctionBlocker: Extract function Replay b51fba6298 cmMakefile: Add OnExecuteCommand callback c76500949d cm*FunctionBlocker: Move to source file Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !3632
| * | cmMakefile: Add OnExecuteCommand callbackRegina Pfeifer2019-07-301-31/+2
| | | | | | | | | | | | | | | In cmCTestScriptHandler, port away from cmFunctionBlocker and update the elapsed time with the new callback instead.
* | | Cleanups: Use cmHas{Prefix,Suffix} instead of String{Starts,Ends}WithSebastian Holtermann2019-08-013-3/+6
| | |
* | | Merge topic 'clang-tidy-8'Brad King2019-07-312-2/+3
|\ \ \ | |/ / |/| | | | | | | | | | | | | | 4af094c8df clang-tidy: Blacklist violations for version 8 Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !3627
| * | clang-tidy: Blacklist violations for version 8Regina Pfeifer2019-07-302-2/+3
| | | | | | | | | | | | | | | Check the codebase with clang-tidy version 8, fix the low hanging fruits, blacklist the rest.
* | | cmStringAlgorithms: Move string functions to the new cmStringAlgorithms.hSebastian Holtermann2019-07-295-3/+5
|/ / | | | | | | | | This adds the `cmStringAlgorithms.h` header and moves all string functions from `cmAlgorithms.h` to `cmStringAlgorithms.h`.
* | Merge topic 'definitions_string_view'Brad King2019-07-267-22/+17
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | e91bfe440c cmMakefile: Let AddDefinition accept a value as cm::string_view f2ba968ef2 cmMakefile: Simplify and rename AddDefinitionBool 9b5cc42531 cmDefinitions: Remove const char* based Set method e268840c0a cmDefinitions: Add Unset and cm::string_view based Set methods 451fd329a8 cmDefinitions: Cleanups Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !3577
| * | cmMakefile: Let AddDefinition accept a value as cm::string_viewSebastian Holtermann2019-07-247-21/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This changes `cmMakefile::AddDefinition` to take a `cm::string_view` as value argument instead of a `const char *`. Benefits are: - `std::string` can be passed to `cmMakefile::AddDefinition` directly without the `c_str()` plus string length recomputation fallback. - Lengths of literals passed to `cmMakefile::AddDefinition` can be computed at compile time. In various sources uses of `cmMakefile::AddDefinition` are adapted to avoid `std::string::c_str` calls and the `std::string` is passed directly. Uses of `cmMakefile::AddDefinition`, where a `nullptr` `const char*` might be passed to `cmMakefile::AddDefinition` are extended with `nullptr` checks.
| * | cmMakefile: Simplify and rename AddDefinitionBoolSebastian Holtermann2019-07-241-1/+1
| | | | | | | | | | | | | | | | | | | | | This simplifies the `cmMakefile::AddDefinition` method with bool value overload to call the string based `cmMakefile::AddDefinition` method with either an "ON" or "OFF" string. Also the method is renamed to `cmMakefile::AddDefinitionBool`
* | | cmCTestHandlerCommand: fix typo of local variableBen Boeckel2019-07-241-7/+7
|/ /
* | Merge topic 'command-refactoring3'Brad King2019-07-231-9/+8
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | dfaa87f1b3 cmState: Support BuiltinCommands as free functions 28f2d12a05 cmCommand: De-virtualize function InvokeInitialPass de77d355ac cmState: Add scripted commands by value 0101ace131 cmUnexpectedCommand: Replace with lambda expression 015001aaf1 cmState: Hold commands by value 1eebc29563 cmCommand: deprecate functions GetMakefile and SetError Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !3574
| * | cmCommand: deprecate functions GetMakefile and SetErrorDaniel Pfeifer2019-07-211-9/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | Replace the members for the Makefile and the Error with a cmExecutionStatus. Re-implement GetMakefile and SetError based on that. Both functions should be called directly on the cmExecutionStatus that is passed to InitialPass. This will help us make all Commands immutable and remove the need for cloning.
* | | Refactor: Break cmCTestTestHandler::ProcessHandler() into smaller functionsKyle Edwards2019-07-192-137/+181
|/ /
* | Merge topic 'skip_regular_expression'Kyle Edwards2019-07-194-5/+38
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | 5dbd9c8583 Vim: Add SKIP_REGULAR_EXPRESSION test property to vim syntax file 407dd1a910 Help: Add documentation for SKIP_REGULAR_EXPRESSION test property d7955d4e5d Tests: Create test for SKIP_REGULAR_EXPRESSION test property 4f1dec86a5 CTest: Add SKIP_REGULAR_EXPRESSION test property Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !3570
| * | CTest: Add SKIP_REGULAR_EXPRESSION test propertyGabor Bencze2019-07-184-5/+38
| | |
* | | Merge topic 'ctest-done-hash'Brad King2019-07-191-9/+9
|\ \ \ | | |/ | |/| | | | | | | | | | | | | da79075c4d CTest: Generate Done.xml before calculating its hash Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !3563
| * | CTest: Generate Done.xml before calculating its hashBetsy McPhail2019-07-191-9/+9
| | | | | | | | | | | | Fixes: #19489
* | | cmMakefile: Modernize AddFunctionBlocker method to accept a std::unique_ptrSebastian Holtermann2019-07-171-10/+14
| |/ |/|
* | modernize: manage cmCommand instances using unique_ptr.Marc Chevrier2019-07-1417-100/+153
| |
* | Introduce memory management helper: cm_memory.hxxMarc Chevrier2019-07-142-3/+4
| |
* | Merge topic 'ctest_make_program__propagated_to_cmake_configure_pass'Brad King2019-07-121-0/+5
|\ \ | | | | | | | | | | | | | | | | | | cd681f1f41 ctest: propagate make program to cmake Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !3483
| * | ctest: propagate make program to cmakeRobert Maynard2019-07-111-0/+5
| |/