summaryrefslogtreecommitdiffstats
path: root/Source/QtDialog
Commit message (Collapse)AuthorAgeFilesLines
* AddCacheEntry: Suppress raw pointer usageMarc Chevrier2023-05-301-4/+4
|
* presets: Improve JSON parser and error messagesMartin Duffy2023-03-294-15/+11
|
* cmake-gui: Fix conversion warnings about Qt indexing typesBrad King2023-02-208-20/+45
| | | | | Qt 5 uses `int` for indexing, and Qt 6 uses `qsizetype`. Add helper types and casts to the appropriate type to avoid conversion warnings.
* cmake-gui: Add optional filename argument to --browse-manualKyle Edwards2023-02-092-6/+12
|
* cmake-gui: do not set search filter if regex is invalidKyle Edwards2022-12-166-18/+56
| | | | Fixes: #24248
* cmDocumentationEntry: Drop all user provided ctors for C++ >= 14Alex Turbov2022-11-171-2/+3
| | | | | | | | | | | There is no need for them cuz: - the last field has a default value - all static instances use 2 arguments convertible to `std::string` - "dynamic" instances used for _Generator_ doc entries access fields diectly using default constructed instance Moreover, compiler may generate move ctor/assign when needed.
* cmDocumentation: `char*[][2]` → `cmDocumentationEntry[N]`Alex Turbov2022-11-171-15/+13
| | | | | | | | | | Use fixed size arrays of `cmDocumentationEntry` items instead of open arrays of two `char` pointers when describe program options help screens. Also, drop `const char*[][2]` overloads of methods of `cmDocumentation` and `cmDocumentationSection` classes in the sake of generic (template) appenders introduced earlier.
* CMakeSetup.cxx: Use anonymous namespace instead of `static`Alex Turbov2022-11-171-5/+9
|
* ctest.cxx: Eliminate redundand trenary operatorAlex Turbov2022-11-171-1/+1
|
* Merge topic 'cmake-gui-restore-version-info'Brad King2022-11-101-3/+8
|\ | | | | | | | | | | | | | | ec76a9c22f cmake-gui: Restore embedded version information in Windows binary Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: buildbot <buildbot@kitware.com> Merge-request: !7895
| * cmake-gui: Restore embedded version information in Windows binaryBrad King2022-11-091-3/+8
| | | | | | | | | | | | Refactoring in commit 89a1e1c1be (Build: Link w/ `OBJECT` library is OK since 3.12, 2022-08-21, v3.25.0-rc1~97^2~19) dropped the `.res` object containing this information from the `cmake-gui` link line. Restore it.
* | cmake: Honor CMAKE_GENERATOR env var in --help outputJuan Ramos2022-10-211-1/+1
|/
* Source: Fix regression causing CMakeLib sources to be compiled repeatedlyBrad King2022-10-051-1/+1
| | | | | | | In commit 4ff8604604 (Build: Do not use variables for sources lists, 2022-08-21) the sources of `CMakeLib` were accidentally made PUBLIC. This causes them to be compiled again in all consuming targets. Make the sources PRIVATE instead.
* Build: Eliminate one time used variableAlex Turbov2022-09-221-3/+1
|
* Build: Link w/ `OBJECT` library is OK since 3.12Alex Turbov2022-09-221-3/+8
|
* Build: Introduce `ManifestLib` interface libraryAlex Turbov2022-09-221-2/+2
| | | | … instead of `MANIFEST_FILE` variable.
* Build: `add_definitions()` → `add_compile_definitions()`Alex Turbov2022-09-221-1/+1
|
* Build: Do not use variables for sources listsAlex Turbov2022-09-221-11/+20
| | | | | Instead use `add_library()` with unconditionally compiled sources and conditional `target_sources()` with extra sources to compile.
* Build: Simplify `configure_file()` callsAlex Turbov2022-09-221-2/+1
|
* CMakeLists: Remove redundant spaces around CMake command callsAlex Turbov2022-09-221-10/+10
|
* Build: Modernize some `foreach` calls to use `IN LISTS`/`IN ITEMS`Alex Turbov2022-09-221-4/+4
|
* cmake-gui: Fix selected item mismatched CMAKE_GENERATOR_PLATFORM envdou fu2022-09-011-1/+2
| | | | | The first empty item in the combobox causes a misalignment with the actual setting by `CMAKE_GENERATOR_PLATFORM` environment variable.
* cmSystemTools: Fix 'ErrorOccurred' spellingFeRD (Frank Dana)2022-06-131-3/+3
| | | | | | | | Rename the booleans 's_ErrorOccured' and 's_FatalErrorOccured' to 's_ErrorOccurred' and 's_FatalErrorOccurred', respectively. Rename the getters and setters to 'Get[Fatal]ErrorOccurred' and 'Set[Fatal]ErrorOccurred', and fix all uses across the codebase.
* cmake-gui: Support non-ASCII chars on Windows with Qt6Mehdi Chinoune2022-06-105-105/+81
| | | | | | | | | | Since commit baead1e2a8 (Encoding: Remove option to use ANSI code page internally, 2016-11-01, v3.8.0-rc1~358^2), we always use UTF-8 strings internally. Using fromLocal8Bit/toLocal8Bit + QTextCodec is no longer needed. Convert to fromStdString/toStdString instead, which should work both with Qt5 and Qt6. Fixes: #23565
* Merge topic 'cmake-gui-locale'Brad King2022-05-311-0/+14
|\ | | | | | | | | | | | | ae13524e3b cmake-gui: Restore support for internationalization with Qt5 on Windows Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !7303
| * cmake-gui: Restore support for internationalization with Qt5 on WindowsBrad King2022-05-271-0/+14
| | | | | | | | | | | | | | | | | | Restore the logic removed by commit 035078d847 (cmake-gui: Remove explicit locale setup, 2020-12-17, v3.20.0-rc1~205^2~6), but only with Qt5 on Windows. Leave a FIXME comment to support Qt6 later. Fixes: #23562 Issue: #23565
* | clang-tidy: fix `performance-unnecessary-copy-initialization` lintsBen Boeckel2022-05-241-2/+2
| |
* | clang-tidy: address `modernize-use-default-member-init` lintsBen Boeckel2022-05-241-2/+1
| |
* | cmake-gui: avoid undefined font in recent macOSCarlo Marcelo Arenas Belón2022-04-151-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Since commit 8fb74f97ef (ENH: Use fixed pitch font in output window, 2008-03-07), cmake-gui has been using a "Courier" font to print mono spaced text in the output window, but at least in macOS 12, Courier is no longer availablemand therefore will print the following warning in the invoking terminal: qt.qpa.fonts: Populating font family aliases took 175 ms. Replace uses of missing font family "Courier" with one that exists to avoid this cost. Change it to use "Courier New" instead, which has been provided as an automatically selected alternative in Windows and comes preinstalled in both systems, and add a hint to pull another monospaced font if not.
* | cmake-gui: Add "Building" category to freedesktop menu specReinaldo Deprera2022-04-041-1/+1
| | | | | | | | | | | | | | Add "Building" to Categories parameters like suggested by the specification [1] for better XFCE/GNome/Plasma menu integration. [1] https://specifications.freedesktop.org/menu-spec/latest/apas02.html
* | Refactor: Rename cmCMakePresetsFile to cmCMakePresetsGraphKyle Edwards2022-01-065-21/+21
| | | | | | | | And change all references to "file" to say "graph" instead.
* | Rename cmProp in cmValueMarc Chevrier2021-09-211-8/+8
| |
* | cmProp: refactoring: transform alias in classMarc Chevrier2021-08-081-3/+3
| | | | | | | | | | | | To handle safely the values used by CMake variables and properties, introduce the class cmProp as a replacement from the simple pointer to std::string instance.
* | Fix -Wpessimizing-move warnings in QCMake::loadPresets()Alex Richardson2021-06-221-9/+6
| |
* | cmMessenger: Pass title inside a metadata structureMarius Messerschmidt2021-05-191-2/+3
| |
* | cmake-gui: Address deprecation warnings with Qt6Craig Scott2021-05-083-5/+17
| |
* | cmake-presets: Make generator and binaryDir fields optionalfriendlyanon2021-04-061-1/+1
| | | | | | | | | | | | | | | | In v3 of the presets, generator and buildDir can be omitted to fall back to regular cmake behavior when these values are not explicitly provided by the user. Fixes: #21987
* | CMakePresets.json: Add the ability to conditionally disable presetsKyle Edwards2021-03-221-1/+1
|/
* cmake-gui: Restore search bar case insensitivityBrad King2021-03-042-4/+4
| | | | | | | | | | | | | | | Since these changes: * commit f1de6f6682 (cmake-gui: Support building against Qt6, 2020-12-17, v3.20.0-rc1~205^2~7) * commit 134d69121e (cmake-gui: Restore search bar for cache view and environment dialog, 2021-02-22, v3.20.0-rc2~12^2) the search bar is no longer case insensitive when using Qt 5.12.[0-1], and possibly some later versions. It works as of Qt 5.15 though, so update our version check accordingly. Fixes: #21884
* cmake-gui: Restore search bar for cache view and environment dialogSankhesh Jhaveri2021-02-222-0/+10
| | | | | | | This was broken by commit f1de6f6682 (cmake-gui: Support building against Qt6, 2020-12-17, v3.20.0-rc1~205^2~7). Fixes: #21850
* cmake-presets: Add build and test presetsSam Freed2021-02-011-6/+7
| | | | Fixes: #21391
* CMake GUI: Fix rendering issueMatthew Woehlke2021-01-151-4/+1
| | | | | | Remove style sheet from a combo box in the GUI. I have no idea why this was being set, but it causes a render glitch. Also, use a more sensible size policy on the same widget.
* CMake GUI: Use system icons when availableMatthew Woehlke2021-01-152-4/+4
| | | | | | | | Modify GUI to use system (theme) icons when available. This may only affect builds on Linux platforms when using the system-provided Qt, but will improve visual consistency with e.g. okay/cancel buttons which are also using the system/theme icons. This also means that the GUI will look slightly more "native" on Linux.
* CMake GUI: Don't use QToolButtonMatthew Woehlke2021-01-153-17/+4
| | | | | | | | Replace QToolButton instances with QPushButton. QToolButton is only meant to be used on tool bars and some other special situations. Worse, we had a mix of QToolButton and QPushButton for things that clearly should be using the same widget. This will improve visual consistency and may fix some rendering issues.
* CMake GUI: Improve signal specificationMatthew Woehlke2021-01-153-13/+15
| | | | | | | Don't use subclasses to connect to QAbstractButton::clicked. This is slightly dodgy, but of more immediate importance, tweaking it will allow us to change the widget type of some QToolButton instances that should be QPushButton.
* Merge branch 'master' into cmake-gui-qrc-fixKyle Edwards2021-01-115-33/+151
|\
| * cmake-gui: Fix macOS styling for binaries distributed with Qt 5.10+Brad King2021-01-071-0/+3
| | | | | | | | | | | | | | | | According to https://bugreports.qt.io/browse/QTBUG-59428, Qt 5.10 and above moved macOS style handling into a separate `qmacstyle` plugin. Install the plugin in our `CMake.app` package on macOS. Issue: #21606
| * cmake-gui: Restore minimal plugin installation for Qt5Brad King2021-01-071-2/+12
| | | | | | | | | | | | | | Since commit f1de6f6682 (cmake-gui: Support building against Qt6, 2020-12-17) all available plugins for each Qt component are installed. This installs more than we need for CMake, so restore Qt5-specific logic to install only the plugins did before.
| * cmake-gui: Restore exclusion of static plugin installationBrad King2021-01-071-1/+2
| | | | | | | | | | This was broken by commit f1de6f6682 (cmake-gui: Support building against Qt6, 2020-12-17).
| * cmake-gui: Restore installation of Qt plugin dependenciesBrad King2021-01-071-1/+1
| | | | | | | | | | | | Fix logic from commit f1de6f6682 (cmake-gui: Support building against Qt6, 2020-12-17) to restore population of the `QT_PLUGINS` variable used in our `fixup_bundle` call.