summaryrefslogtreecommitdiffstats
path: root/Source/QtDialog
Commit message (Collapse)AuthorAgeFilesLines
* cmSystemTools: Fix 'ErrorOccurred' spellingFeRD (Frank Dana)2022-06-131-3/+3
| | | | | | | | Rename the booleans 's_ErrorOccured' and 's_FatalErrorOccured' to 's_ErrorOccurred' and 's_FatalErrorOccurred', respectively. Rename the getters and setters to 'Get[Fatal]ErrorOccurred' and 'Set[Fatal]ErrorOccurred', and fix all uses across the codebase.
* cmake-gui: Support non-ASCII chars on Windows with Qt6Mehdi Chinoune2022-06-105-105/+81
| | | | | | | | | | Since commit baead1e2a8 (Encoding: Remove option to use ANSI code page internally, 2016-11-01, v3.8.0-rc1~358^2), we always use UTF-8 strings internally. Using fromLocal8Bit/toLocal8Bit + QTextCodec is no longer needed. Convert to fromStdString/toStdString instead, which should work both with Qt5 and Qt6. Fixes: #23565
* Merge topic 'cmake-gui-locale'Brad King2022-05-311-0/+14
|\ | | | | | | | | | | | | ae13524e3b cmake-gui: Restore support for internationalization with Qt5 on Windows Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !7303
| * cmake-gui: Restore support for internationalization with Qt5 on WindowsBrad King2022-05-271-0/+14
| | | | | | | | | | | | | | | | | | Restore the logic removed by commit 035078d847 (cmake-gui: Remove explicit locale setup, 2020-12-17, v3.20.0-rc1~205^2~6), but only with Qt5 on Windows. Leave a FIXME comment to support Qt6 later. Fixes: #23562 Issue: #23565
* | clang-tidy: fix `performance-unnecessary-copy-initialization` lintsBen Boeckel2022-05-241-2/+2
| |
* | clang-tidy: address `modernize-use-default-member-init` lintsBen Boeckel2022-05-241-2/+1
| |
* | cmake-gui: avoid undefined font in recent macOSCarlo Marcelo Arenas Belón2022-04-151-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Since commit 8fb74f97ef (ENH: Use fixed pitch font in output window, 2008-03-07), cmake-gui has been using a "Courier" font to print mono spaced text in the output window, but at least in macOS 12, Courier is no longer availablemand therefore will print the following warning in the invoking terminal: qt.qpa.fonts: Populating font family aliases took 175 ms. Replace uses of missing font family "Courier" with one that exists to avoid this cost. Change it to use "Courier New" instead, which has been provided as an automatically selected alternative in Windows and comes preinstalled in both systems, and add a hint to pull another monospaced font if not.
* | cmake-gui: Add "Building" category to freedesktop menu specReinaldo Deprera2022-04-041-1/+1
| | | | | | | | | | | | | | Add "Building" to Categories parameters like suggested by the specification [1] for better XFCE/GNome/Plasma menu integration. [1] https://specifications.freedesktop.org/menu-spec/latest/apas02.html
* | Refactor: Rename cmCMakePresetsFile to cmCMakePresetsGraphKyle Edwards2022-01-065-21/+21
| | | | | | | | And change all references to "file" to say "graph" instead.
* | Rename cmProp in cmValueMarc Chevrier2021-09-211-8/+8
| |
* | cmProp: refactoring: transform alias in classMarc Chevrier2021-08-081-3/+3
| | | | | | | | | | | | To handle safely the values used by CMake variables and properties, introduce the class cmProp as a replacement from the simple pointer to std::string instance.
* | Fix -Wpessimizing-move warnings in QCMake::loadPresets()Alex Richardson2021-06-221-9/+6
| |
* | cmMessenger: Pass title inside a metadata structureMarius Messerschmidt2021-05-191-2/+3
| |
* | cmake-gui: Address deprecation warnings with Qt6Craig Scott2021-05-083-5/+17
| |
* | cmake-presets: Make generator and binaryDir fields optionalfriendlyanon2021-04-061-1/+1
| | | | | | | | | | | | | | | | In v3 of the presets, generator and buildDir can be omitted to fall back to regular cmake behavior when these values are not explicitly provided by the user. Fixes: #21987
* | CMakePresets.json: Add the ability to conditionally disable presetsKyle Edwards2021-03-221-1/+1
|/
* cmake-gui: Restore search bar case insensitivityBrad King2021-03-042-4/+4
| | | | | | | | | | | | | | | Since these changes: * commit f1de6f6682 (cmake-gui: Support building against Qt6, 2020-12-17, v3.20.0-rc1~205^2~7) * commit 134d69121e (cmake-gui: Restore search bar for cache view and environment dialog, 2021-02-22, v3.20.0-rc2~12^2) the search bar is no longer case insensitive when using Qt 5.12.[0-1], and possibly some later versions. It works as of Qt 5.15 though, so update our version check accordingly. Fixes: #21884
* cmake-gui: Restore search bar for cache view and environment dialogSankhesh Jhaveri2021-02-222-0/+10
| | | | | | | This was broken by commit f1de6f6682 (cmake-gui: Support building against Qt6, 2020-12-17, v3.20.0-rc1~205^2~7). Fixes: #21850
* cmake-presets: Add build and test presetsSam Freed2021-02-011-6/+7
| | | | Fixes: #21391
* CMake GUI: Fix rendering issueMatthew Woehlke2021-01-151-4/+1
| | | | | | Remove style sheet from a combo box in the GUI. I have no idea why this was being set, but it causes a render glitch. Also, use a more sensible size policy on the same widget.
* CMake GUI: Use system icons when availableMatthew Woehlke2021-01-152-4/+4
| | | | | | | | Modify GUI to use system (theme) icons when available. This may only affect builds on Linux platforms when using the system-provided Qt, but will improve visual consistency with e.g. okay/cancel buttons which are also using the system/theme icons. This also means that the GUI will look slightly more "native" on Linux.
* CMake GUI: Don't use QToolButtonMatthew Woehlke2021-01-153-17/+4
| | | | | | | | Replace QToolButton instances with QPushButton. QToolButton is only meant to be used on tool bars and some other special situations. Worse, we had a mix of QToolButton and QPushButton for things that clearly should be using the same widget. This will improve visual consistency and may fix some rendering issues.
* CMake GUI: Improve signal specificationMatthew Woehlke2021-01-153-13/+15
| | | | | | | Don't use subclasses to connect to QAbstractButton::clicked. This is slightly dodgy, but of more immediate importance, tweaking it will allow us to change the widget type of some QToolButton instances that should be QPushButton.
* Merge branch 'master' into cmake-gui-qrc-fixKyle Edwards2021-01-115-33/+151
|\
| * cmake-gui: Fix macOS styling for binaries distributed with Qt 5.10+Brad King2021-01-071-0/+3
| | | | | | | | | | | | | | | | According to https://bugreports.qt.io/browse/QTBUG-59428, Qt 5.10 and above moved macOS style handling into a separate `qmacstyle` plugin. Install the plugin in our `CMake.app` package on macOS. Issue: #21606
| * cmake-gui: Restore minimal plugin installation for Qt5Brad King2021-01-071-2/+12
| | | | | | | | | | | | | | Since commit f1de6f6682 (cmake-gui: Support building against Qt6, 2020-12-17) all available plugins for each Qt component are installed. This installs more than we need for CMake, so restore Qt5-specific logic to install only the plugins did before.
| * cmake-gui: Restore exclusion of static plugin installationBrad King2021-01-071-1/+2
| | | | | | | | | | This was broken by commit f1de6f6682 (cmake-gui: Support building against Qt6, 2020-12-17).
| * cmake-gui: Restore installation of Qt plugin dependenciesBrad King2021-01-071-1/+1
| | | | | | | | | | | | Fix logic from commit f1de6f6682 (cmake-gui: Support building against Qt6, 2020-12-17) to restore population of the `QT_PLUGINS` variable used in our `fixup_bundle` call.
| * cmake-gui: Remove outdated FIXME comment about plugin installationBrad King2021-01-071-2/+0
| | | | | | | | Qt plugin installation conventions are now well-established.
| * cmake-gui: Fix CMake_QT_MAJOR_VERSION string comparisonBrad King2021-01-071-1/+1
| | | | | | | | | | | | Fix the string comparison added by commit 2e4cbaa521 (cmake-gui: Add a Qt version control variable, 2020-12-28). The version-based comparison is not meant for arbitrary strings.
| * cmake-gui: Add a Qt version control variableSankhesh Jhaveri2021-01-051-8/+20
| |
| * cmake-gui: Conditionally switch between QDirModel and QFileSystemModelSankhesh Jhaveri2021-01-051-1/+36
| | | | | | | | | | Uses QT_VERSION_CHECK to determine Qt version. The code switches to QFileSystemModel for Qt versions >= 6
| * cmake-gui: Replace obsolete QDirModel with QFileSystemModelSankhesh Jhaveri2021-01-051-13/+10
| |
| * cmake-gui: Prefer local variable for Qt major versionSankhesh Jhaveri2021-01-051-23/+27
| | | | | | | | QT_DEFAULT_MAJOR_VERSION was added in Qt 5.15 and CMake supports Qt versions >= 5.9
| * cmake-gui: Support installation for both Qt5 and Qt6 pluginsSankhesh Jhaveri2021-01-051-7/+17
| |
| * cmake-gui: Use a consistent Qt major version variable nameSankhesh Jhaveri2021-01-051-20/+19
| |
| * cmake-gui: Remove explicit locale setupSankhesh Jhaveri2021-01-051-4/+0
| | | | | | | | Qt uses utf-8 encoding by default for versions >= Qt5.
| * cmake-gui: Support building against Qt6Sankhesh Jhaveri2021-01-053-21/+77
| |
| * Merge topic 'cmake-gui-system-icon'Brad King2020-12-161-1/+1
| |\ | | | | | | | | | | | | | | | | | | 47649baf60 cmake-gui: Use icon from system theme if available Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !5616
| | * cmake-gui: Use icon from system theme if availableLoren Burkholder2020-12-151-1/+1
| | |
* | | cmake-gui: Restore linking of Qt resourcesKyle Edwards2021-01-111-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | Refactoring in commit 41e223deb3 (CMake GUI: Split up into libraries, add test shim, 2020-09-14, v3.19.0-rc1~116^2~2) broke linking of Qt resources, such as the Add/Remove Entry button icons. Fixes: #21682
* | | cmake-gui: Fix macOS styling for binaries distributed with Qt 5.10+Brad King2021-01-071-0/+3
|/ / | | | | | | | | | | | | | | According to https://bugreports.qt.io/browse/QTBUG-59428, Qt 5.10 and above moved macOS style handling into a separate `qmacstyle` plugin. Install the plugin in our `CMake.app` package on macOS. Issue: #21606
* | cmake-gui: Restore completion during path editingBrad King2020-12-151-9/+14
|/ | | | | | | | | | Revert commit 0fc1818831 (QCMakeWidgets: replace QDirModel, 2020-06-15, v3.19.0-rc1~696^2). `QFileSystemModel` is not a drop-in replacement for `QDirModel`. Additional changes are needed to make it work fully. Revert the change and suppress the `QDirModel` deprecation warning pending further investigation. Fixes: #21589
* cmake-gui: Restore workaround for crash in file dialogBrad King2020-11-052-0/+14
| | | | | | | | | | In commit ce9dbceb42 (QtDialog: remove Qt4-only code, 2020-06-02, v3.19.0-rc1~712^2~1) we removed an event filter that was thought to be necessary only as a workaround for a bug in Qt. However, that bug was fixed in Qt 4.5, and the file dialog still crashes as of Qt 5.14 without the filter. Restore the workaround pending further investigation. Fixes: #21400
* Merge topic 'cmake-presets-help-flag' into release-3.19Brad King2020-10-281-1/+6
|\ | | | | | | | | | | | | c619be2784 ccmake: Don't list --preset in --help Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !5428
| * ccmake: Don't list --preset in --helpKyle Edwards2020-10-271-1/+6
| | | | | | | | | | | | And show available options in cmake-gui. Fixes: #21313
* | CMake GUI: Add --browse-manual argumentKyle Edwards2020-10-272-14/+22
|/
* CMakePresets.json: Rework how --preset argument is handledKyle Edwards2020-10-261-2/+1
| | | | | | | | If a path argument with no -S or -B leads to a cache directory, use that directory as the binary directory. Otherwise, use the binary directory from the preset. Fixes: #21311
* CMakePresets.json: Split cmakeGeneratorConfig fieldKyle Edwards2020-10-224-11/+19
| | | | | | | | Make this field separate for both architecture and toolset. Allow architecture and toolset to be either strings or objects with value and strategy fields. Fixes: #21317
* CMakePresets.json: Properly report macro expansion errorsKyle Edwards2020-10-211-11/+11
| | | | | | | | Make a distinction between strings which simply use the $vendor{<...>} macro, which is valid but makes it unusable by CMake, and strings which actually contain invalid macro expansions. Fixes: #21308