summaryrefslogtreecommitdiffstats
path: root/Source/QtDialog
Commit message (Collapse)AuthorAgeFilesLines
* cmake-gui: Fix crash when built with Qt 5.14 or laterBrad King2020-07-221-2/+3
| | | | | | | | | | | | In commit d7679f6427 (QCMakeCacheView: use non-deprecated List and Set constructions, 2020-06-10, v3.18.0-rc2~13^2) the conversion of the `this->properties()` value to QSet is incorrect for Qt 5.14+. The problem is that `this->properties()` returns by value, so the range `this->properties().begin(), this->properties().end()` provides iterators to two different instances. Use an intermediate temporary copy of the value to get a consistent iterator range. Fixes: #20981
* cmake-gui: Fix compilation as C++14 with Qt 5.14Brad King2020-07-061-4/+4
| | | | | | Fix code added by commit d7679f6427 (QCMakeCacheView: use non-deprecated List and Set constructions, 2020-06-10, v3.18.0-rc2~13^2), used conditionally on Qt 5.14 or above, to compile as C++14.
* QCMakeCacheView: use non-deprecated List and Set constructionsBen Boeckel2020-06-101-2/+15
|
* CursesDialog: resolve clang-tidy warningsBen Boeckel2020-06-022-11/+1
| | | | | | | | | Fixes: - unnecessary bool expression (cmCursesMainForm) - removes a duplicate if/else branch (RegexExplorer) - collapses redundant if/else branch logic (CMakeSetupDialog and cmCursesStringWidget)
* QtDialog: avoid using deprecated APIsBen Boeckel2020-06-022-0/+47
|
* cmake-gui: Do not pass CMAKE_{C,CXX}_COMPILER items to cmake if emptyJiri Malak2020-04-271-4/+8
| | | | | | | If C or C++ compiler is not specified in the initial dialog, do not pass `CMAKE_C_COMPILER` or `CMAKE_CXX_COMPILER` cache entries for cross-compilation setup. Instead allow the normal search for the compiler to proceed.
* cmake-gui: Pass CMAKE_SYSTEM_PROCESSOR to from gui to cmakeJiri Malak2020-04-131-0/+3
| | | | | Add missing `CMAKE_SYSTEM_PROCESSOR` cmake cache entry to passed options for first configure. We already pass `CMAKE_SYSTEM_{NAME,VERSION}`.
* Merge topic 'cmprop-state'Brad King2020-03-271-5/+6
|\ | | | | | | | | | | | | a7f2ff16a4 cmState::GetCacheEntryProperty: return cmProp Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4522
| * cmState::GetCacheEntryProperty: return cmPropVitaly Stakhovsky2020-03-251-5/+6
| |
* | Remove redundant calls to CollapseFullPathBrad King2020-03-241-4/+2
|/ | | | | Remove calls where it is known the input is already a collapsed full path.
* Merge topic 'cmake-gui-open-check'Brad King2020-03-231-1/+1
|\ | | | | | | | | | | | | ecc0086bfc cmake-gui: Fix use-after-free in Open-possible check Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4508
| * cmake-gui: Fix use-after-free in Open-possible checkFrancisco Facioni2020-03-201-1/+1
| | | | | | | | | | Fix `QCMake::checkOpenPossible` to copy `toLocal8Bit().data()` before its lifetime expires.
* | cmState::GetCacheEntryValue: return cmPropVitaly Stakhovsky2020-03-171-12/+11
| |
* | Modernize memory managementMarc Chevrier2020-03-054-15/+16
| | | | | | | | Update internals of various classes.
* | cmake-gui: set generator field defaults from environmentCode Smith2020-02-062-3/+51
|/ | | | Fixes: #20251
* GlobalGenerator family: modernize memory managementMarc Chevrier2020-01-071-0/+1
|
* Add option to configure Ninja link job pool for CMake's own binariesBrad King2019-10-101-0/+4
| | | | | Create an undocumented `CMake_JOB_POOL_LINK_BIN` option that builders can set to avoid linking too many of our binaries at once.
* Revise include order using clang-format-6.0Kitware Robot2019-10-0111-32/+38
| | | | | Run the `clang-format.bash` script to update our C and C++ code to a new include order `.clang-format`. Use `clang-format` version 6.0.
* Help: fixed typos in PCH / Unity Build docCorentin Plouet2019-09-301-2/+2
| | | | + typos in source code
* clang-tidy: modernize-deprecated-headersRegina Pfeifer2019-09-161-2/+2
|
* clang-tidy: modernize-use-autoRegina Pfeifer2019-09-101-2/+1
| | | | | | Set the MinTypeNameLength option to an impossibly high value in order to limit the diagnostics to iterators. Leave new expressions and cast expressions for later.
* clang-tidy: Replace typedef with usingRegina Pfeifer2019-09-041-1/+1
| | | | | | | | Automate the conversion with perl -i -0pe 's/typedef ([^;]*) ([^ ]+);/using $2 = $1;/g' then manually fix a few places.
* Source sweep: Use cmStrCat for string concatenationSebastian Holtermann2019-08-221-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch is generated by a python script that uses regular expressions to search for string concatenation patterns of the kind ``` std::string str = <ARG0>; str += <ARG1>; str += <ARG2>; ... ``` and replaces them with a single `cmStrCat` call ``` std::string str = cmStrCat(<ARG0>, <ARG1>, <ARG2>, ...); ``` If any `<ARGX>` is itself a concatenated string of the kind ``` a + b + c + ...; ``` then `<ARGX>` is split into multiple arguments for the `cmStrCat` call. If there's a sequence of literals in the `<ARGX>`, then all literals in the sequence are concatenated and merged into a single literal argument for the `cmStrCat` call. Single character strings are converted to single char arguments for the `cmStrCat` call. `std::to_string(...)` wrappings are removed from `cmStrCat` arguments, because it supports numeric types as well as string types. `arg.substr(x)` arguments to `cmStrCat` are replaced with `cm::string_view(arg).substr(x)`
* clang-tidy: isolate declarations for readabilityRegina Pfeifer2019-08-201-1/+2
|
* Source sweep: Use cmIsOn instead of cmSystemTools::IsOnSebastian Holtermann2019-08-171-1/+2
| | | | | | | | | This replaces invocations of - `cmSystemTools::IsInternallyOn` with `cmIsInternallyOn` - `cmSystemTools::IsNOTFOUND` with `cmIsNOTFOUND` - `cmSystemTools::IsOn` with `cmIsOn` - `cmSystemTools::IsOff` with `cmIsOff`
* cmStringAlgorithms: Move string functions to the new cmStringAlgorithms.hSebastian Holtermann2019-07-291-0/+1
| | | | | This adds the `cmStringAlgorithms.h` header and moves all string functions from `cmAlgorithms.h` to `cmStringAlgorithms.h`.
* QtDialog: Use QPalette::WindowText instead of QPalette::ForegroundSebastian Holtermann2019-07-011-1/+1
| | | | | | | | | | `QPalette::Foreground` is deprecated and was replaced by `QPalette::WindowText` since at least Qt 4.8. https://doc.qt.io/archives/qt-4.8/qpalette.html#ColorRole-enum This replaces the `QPalette::Foreground` color role with `QPalette::WindowText` in `QtDialog/RegexExplorer.cxx` to avoid compiler warnings.
* cmake-gui: Update Qt copyright holder in About dialogBrad King2019-06-121-1/+1
| | | | Qt is now copyright "The Qt Company Ltd.".
* Ensure stdin, stdout, and stderr pipes are always openBrad King2019-05-021-0/+1
| | | | | | | | | | | | | On non-Windows platforms libuv assumes that file descriptors 0-2 are always used for standard pipes and never for anything else. Otherwise, libuv may re-use one of these descriptors and then fail an assertion when closing it. Similarly, On Windows platforms our ConsoleBuf implementation assumes that the standard handles are always open. If CMake is run with any standard pipes closed, open them with `/dev/null` or `NUL` to satisfy these assumptions. Fixes: #19219
* Merge topic 'fix-overlay-icon-windows'Brad King2019-04-121-1/+0
|\ | | | | | | | | | | | | 12ef832c96 cmake-gui: Fix icon overlay on windows Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !3217
| * cmake-gui: Fix icon overlay on windowsJulien Jomier2019-04-111-1/+0
| | | | | | | | | | | | | | | | | | Since commit 9175a378f5 (QtDialog: Add windows taskbar progress, 2018-11-17, v3.14.0-rc1~330^2) we've added a missing overlay icon. This results in Windows falling back to a default overlay icon. Simply drop this line. Fixes: #19160
* | Merge branch 'backport-cmake-gui-windows-theme'Brad King2019-04-081-0/+3
|\ \
| * | cmake-gui: Fix theme on Windows with Qt >= 5.10mistersandman2019-04-081-0/+3
| |/ | | | | | | | | | | | | In Qt 5.10 the theme support moved to a separate QWindowsVistaStyle plugin. Issue: #19147
* | cmake-gui: Drop code not needed with current required CMake versionBrad King2019-03-141-3/+0
| |
* | cmake: Progress functions use `std::string` paramVitaly Stakhovsky2019-02-112-5/+5
| |
* | Merge topic 'modernize-for-loops'Brad King2019-02-112-30/+26
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | 01b2d6ab74 Modernize: Use ranged for-loops when possible 15bdbec017 cmAlgorithms: Make cmRange advance/retreat safe for rvalues Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: Daniel Pfeifer <daniel@pfeifer-mail.de> Merge-request: !2901
| * | Modernize: Use ranged for-loops when possibleArtur Ryt2019-02-072-30/+26
| |/ | | | | | | | | | | | | Replaced most manual `const_iterator`-based loops and some reverse-iterator loops with range loops. Fixes: #18858
* | cmSystemTools: MessageCallback and Message() accept std::string argumentVitaly Stakhovsky2019-02-072-4/+4
|/
* OutputCallback: Accept std::string argumentRegina Pfeifer2019-01-302-8/+8
|
* Merge topic 'functional-callbacks'Brad King2019-01-302-29/+33
|\ | | | | | | | | | | | | | | | | | | 8c92db829b MessageCallback: Remove unused bool& argument bcee24aecc Use `std::function` for callbacks Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: vvs31415 <vstakhovsky@fastmail.com> Acked-by: Daniel Pfeifer <daniel@pfeifer-mail.de> Merge-request: !2872
| * MessageCallback: Remove unused bool& argumentRegina Pfeifer2019-01-292-5/+4
| |
| * Use `std::function` for callbacksRegina Pfeifer2019-01-292-28/+33
| |
* | Merge topic 'tidy-use-equals-default'Brad King2019-01-292-18/+6
|\ \ | |/ |/| | | | | | | | | | | | | 094f01d0f0 cleanup: Prefer compiler provided special member functions 55671b41d2 clang-tidy: Use `= default` Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: Brad King <brad.king@kitware.com> Merge-request: !2841
| * clang-tidy: Use `= default`Regina Pfeifer2019-01-252-18/+6
| | | | | | | | | | | | Suppress some cases in `Source/cmGeneratorExpressionNode.cxx` and `Source/cmUVHandlePtr.h` where a few older compilers require a user-defined default constructor (with `{}`).
* | Merge topic 'cmake-gui-s-b'Brad King2019-01-281-12/+43
|\ \ | | | | | | | | | | | | | | | | | | | | | ad0853b3d4 QtDialog: Clean up and document -S and -B options Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: Robert Maynard <robert.maynard@kitware.com> Merge-request: !2863
| * | QtDialog: Clean up and document -S and -B optionsKyle Edwards2019-01-251-12/+43
| |/
* | Reduce size of PNG imagesLucy Phipps2019-01-255-0/+0
|/ | | | | | Use FileOptimizer 13.50.2431 (x86) and ZopfliPNG 1.0.2. Update expected file hashes in tests.
* Merge topic 'tidy-pass-by-value'Brad King2019-01-232-3/+4
|\ | | | | | | | | | | | | 5a0784ddea clang-tidy: Pass by value Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !2836
| * clang-tidy: Pass by valueRegina Pfeifer2019-01-222-3/+4
| |
* | Merge topic 'help-mark-default-generator'Brad King2019-01-221-2/+1
|\ \ | |/ |/| | | | | | | | | | | | | dfd5ae7da7 Help: Mark default CMake generator with asterisk 6023fe7ff2 ccmake: Append rather than replace Generators section of docs 7408cd3929 cmake: Return generator docs directly Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !2682
generated by cgit v0.12 at 2025-01-27 04:21:59 (GMT)