summaryrefslogtreecommitdiffstats
path: root/Source/QtDialog
Commit message (Collapse)AuthorAgeFilesLines
* Ensure stdin, stdout, and stderr pipes are always openBrad King2019-05-021-0/+1
| | | | | | | | | | | | | On non-Windows platforms libuv assumes that file descriptors 0-2 are always used for standard pipes and never for anything else. Otherwise, libuv may re-use one of these descriptors and then fail an assertion when closing it. Similarly, On Windows platforms our ConsoleBuf implementation assumes that the standard handles are always open. If CMake is run with any standard pipes closed, open them with `/dev/null` or `NUL` to satisfy these assumptions. Fixes: #19219
* Merge topic 'fix-overlay-icon-windows'Brad King2019-04-121-1/+0
|\ | | | | | | | | | | | | 12ef832c96 cmake-gui: Fix icon overlay on windows Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !3217
| * cmake-gui: Fix icon overlay on windowsJulien Jomier2019-04-111-1/+0
| | | | | | | | | | | | | | | | | | Since commit 9175a378f5 (QtDialog: Add windows taskbar progress, 2018-11-17, v3.14.0-rc1~330^2) we've added a missing overlay icon. This results in Windows falling back to a default overlay icon. Simply drop this line. Fixes: #19160
* | Merge branch 'backport-cmake-gui-windows-theme'Brad King2019-04-081-0/+3
|\ \
| * | cmake-gui: Fix theme on Windows with Qt >= 5.10mistersandman2019-04-081-0/+3
| |/ | | | | | | | | | | | | In Qt 5.10 the theme support moved to a separate QWindowsVistaStyle plugin. Issue: #19147
* | cmake-gui: Drop code not needed with current required CMake versionBrad King2019-03-141-3/+0
| |
* | cmake: Progress functions use `std::string` paramVitaly Stakhovsky2019-02-112-5/+5
| |
* | Merge topic 'modernize-for-loops'Brad King2019-02-112-30/+26
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | 01b2d6ab74 Modernize: Use ranged for-loops when possible 15bdbec017 cmAlgorithms: Make cmRange advance/retreat safe for rvalues Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: Daniel Pfeifer <daniel@pfeifer-mail.de> Merge-request: !2901
| * | Modernize: Use ranged for-loops when possibleArtur Ryt2019-02-072-30/+26
| |/ | | | | | | | | | | | | Replaced most manual `const_iterator`-based loops and some reverse-iterator loops with range loops. Fixes: #18858
* | cmSystemTools: MessageCallback and Message() accept std::string argumentVitaly Stakhovsky2019-02-072-4/+4
|/
* OutputCallback: Accept std::string argumentRegina Pfeifer2019-01-302-8/+8
|
* Merge topic 'functional-callbacks'Brad King2019-01-302-29/+33
|\ | | | | | | | | | | | | | | | | | | 8c92db829b MessageCallback: Remove unused bool& argument bcee24aecc Use `std::function` for callbacks Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: vvs31415 <vstakhovsky@fastmail.com> Acked-by: Daniel Pfeifer <daniel@pfeifer-mail.de> Merge-request: !2872
| * MessageCallback: Remove unused bool& argumentRegina Pfeifer2019-01-292-5/+4
| |
| * Use `std::function` for callbacksRegina Pfeifer2019-01-292-28/+33
| |
* | Merge topic 'tidy-use-equals-default'Brad King2019-01-292-18/+6
|\ \ | |/ |/| | | | | | | | | | | | | 094f01d0f0 cleanup: Prefer compiler provided special member functions 55671b41d2 clang-tidy: Use `= default` Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: Brad King <brad.king@kitware.com> Merge-request: !2841
| * clang-tidy: Use `= default`Regina Pfeifer2019-01-252-18/+6
| | | | | | | | | | | | Suppress some cases in `Source/cmGeneratorExpressionNode.cxx` and `Source/cmUVHandlePtr.h` where a few older compilers require a user-defined default constructor (with `{}`).
* | Merge topic 'cmake-gui-s-b'Brad King2019-01-281-12/+43
|\ \ | | | | | | | | | | | | | | | | | | | | | ad0853b3d4 QtDialog: Clean up and document -S and -B options Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: Robert Maynard <robert.maynard@kitware.com> Merge-request: !2863
| * | QtDialog: Clean up and document -S and -B optionsKyle Edwards2019-01-251-12/+43
| |/
* | Reduce size of PNG imagesLucy Phipps2019-01-255-0/+0
|/ | | | | | Use FileOptimizer 13.50.2431 (x86) and ZopfliPNG 1.0.2. Update expected file hashes in tests.
* Merge topic 'tidy-pass-by-value'Brad King2019-01-232-3/+4
|\ | | | | | | | | | | | | 5a0784ddea clang-tidy: Pass by value Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !2836
| * clang-tidy: Pass by valueRegina Pfeifer2019-01-222-3/+4
| |
* | Merge topic 'help-mark-default-generator'Brad King2019-01-221-2/+1
|\ \ | |/ |/| | | | | | | | | | | | | dfd5ae7da7 Help: Mark default CMake generator with asterisk 6023fe7ff2 ccmake: Append rather than replace Generators section of docs 7408cd3929 cmake: Return generator docs directly Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !2682
| * cmake: Return generator docs directlyArtur Ryt2019-01-181-2/+1
| | | | | | | | | | | | | | | | | | The GetGeneratorDocumentation() function was not accurately named and required the vector to populate to be passed as a function argument. This commit makes the slightly renamed function return by value, making it a true getter as implied by its name. Some minor refactoring of the implementation also makes the steps of populating the vector clearer.
* | cmake-gui: Improve label for default platformJulien Jomier2019-01-212-2/+13
| | | | | | | | Specify the default platform to be used when the platform field is empty
* | cmake-gui: Add field for generator platform selectionJulien Jomier2019-01-185-4/+101
|/ | | | | | | Extend the "first configure" dialog with a field for the user to select a value for `CMAKE_GENERATOR_PLATFORM`. Fixes: #17343
* Properties: Add CMAKE_ROLE global propertyKyle Edwards2019-01-172-2/+2
| | | | | This property allows scripts to determine whether they're in project mode, script mode, find-package mode, CTest, or CPack.
* Merge topic 'readability-static-accessed-through-instance'Brad King2018-11-283-14/+14
|\ | | | | | | | | | | | | 3e60580784 clang-tidy: Fix readability-static-accessed-through-instance Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !2647
| * clang-tidy: Fix readability-static-accessed-through-instanceRegina Pfeifer2018-11-213-14/+14
| | | | | | | | Enable the check in .clang-tidy and fix all warnings.
* | clang-tidy: fix warnings in macOS-only codeBrad King2018-11-271-5/+4
| |
* | Merge topic 'windows-taskbar-progress'Brad King2018-11-263-0/+43
|\ \ | |/ |/| | | | | | | | | 9175a378f5 QtDialog: Add windows taskbar progress Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !2628
| * QtDialog: Add windows taskbar progressJulien Jomier2018-11-203-0/+43
| |
* | clang-tidy: fix warnings from version 7Regina Pfeifer2018-11-201-2/+2
|/ | | | | Fix some warnings that are new since clang-tidy version 4, and update `.clang-tidy` to suppress the rest.
* Merge topic 'provide_explicit_source_and_build_command_line_options'Brad King2018-09-191-1/+1
|\ | | | | | | | | | | | | | | | | 638f00117a Add release note for the -S and -B options. de962cc00d CMake: Internally uses -S instead of -H to specify source directory a10d63d578 cmake: -S and -B can be used to specify source and build directories Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !2358
| * CMake: Internally uses -S instead of -H to specify source directoryRobert Maynard2018-09-151-1/+1
| |
* | Merge topic 'gicv-stdstring'Brad King2018-09-121-2/+2
|\ \ | | | | | | | | | | | | | | | | | | 13d10ee616 cmState::GetInitializedCacheValue: Return as const std::string* Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !2365
| * | cmState::GetInitializedCacheValue: Return as const std::string*Vitaly Stakhovsky2018-09-101-2/+2
| |/
* | Merge topic 'replace-os-x-name-with-macos'Brad King2018-09-112-2/+2
|\ \ | |/ |/| | | | | | | | | | | | | | | ab2e35d614 Replace occurrences of "Mac OS X" with "macOS" in comments fc1602456a Help: Replace occurrences of "Mac OS X" with "macOS" Acked-by: Kitware Robot <kwrobot@kitware.com> Reviewed-by: Gregor Jasny <gjasny@googlemail.com> Reviewed-by: Clinton Stimpson <clinton@elemtech.com> Merge-request: !2351
| * Replace occurrences of "Mac OS X" with "macOS" in commentsBartosz Kosiorek2018-09-102-2/+2
| | | | | | | | | | | | | | | | Apple's main Operating system changed their name from OS X to macOS: https://www.engadget.com/2016/06/13/os-x-is-now-macos/ Revise source comments accordingly.
* | cmake-gui: Align source and binary directory path textZeex2018-09-041-0/+3
|/ | | | | | | | Text inputs for "where is the source code" and "where to build the binaries" had different amount of left spacing, so the two paths were not aligned. This could create a feeling that you typed something wrong in the input even though the paths were identical or had a common root path.
* cmake-gui: Update iconsT.J. Corona2018-08-165-0/+0
|
* Revise C++ coding style using clang-format-6.0Kitware Robot2018-06-0110-20/+36
| | | | | | | | | | | | Run the `clang-format.bash` script to update all our C and C++ code to a new style defined by `.clang-format`. Use `clang-format` version 6.0. * If you reached this commit for a line in `git blame`, re-run the blame operation starting at the parent of this commit to see older history for the content. * See the parent commit for instructions to rebase a change across this style transition commit.
* Windows: Embed version information into cmake-guiBrad King2018-01-301-0/+4
| | | | | In commit 5b9da05b7a (Windows: Embed version information into CMake binaries, 2017-10-25) we accidentally left out cmake-gui.
* Merge topic 'RemoveKDevelop3'Brad King2018-01-251-9/+0
|\ | | | | | | | | | | | | | | 551bd0b3 Generators: adjust error message for the removed KDevelop3 generator 9198e6a2 Generators: remove KDevelop3 generator Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !1688
| * Generators: remove KDevelop3 generatorAlex Neundorf2018-01-241-9/+0
| | | | | | | | | | | | | | | | | | | | The last KDevelop3 release was many years ago, in 2008 I think. I haven't seen or read about anybody using KDevelop 3 since a long time, so I think it can safely be removed from CMake. KDevelop 4 (first released in 2010) has its own proper CMake support now, independent from this generator. Alex
* | Extend libuv file translate mode workaround to all executablesBrad King2018-01-231-0/+1
|/ | | | | | | | | | | | | | | Since libuv commit v1.14.1~7 (win: add uv__once_init() calls, 2017-08-30) the libuv initialization of the file translate mode may take place even if we do not use a uv loop. This change was included in our libuv update commit f4a26c748b (libuv 2018-01-19). Therefore use of libuv even through `cmSystemTools::GetRealPath` in any executable may trigger its file translate mode setting. Factor out the logic added to `cmake.exe` by commit v3.9.0-rc4~10^2 (cmake: Fix default file translate mode when using libuv, 2017-06-13) and re-use to initialize all executables. Issue: #16962
* Various typo fixesLuz Paz2018-01-031-1/+1
| | | | Some are user-facing. Others are source comments.
* cmake-gui: Update RegexExplorer for changes to KWSysBrad King2017-12-051-2/+2
|
* Merge topic 'cmake-gui-qt-static-windows'Brad King2017-11-142-1/+11
|\ | | | | | | | | | | | | | | 3a993c49 Tests: Add options to disable tests requiring Qt 27a73f16 cmake-gui: Add build option to use Qt5 windows plugin statically Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !1476
| * cmake-gui: Add build option to use Qt5 windows plugin staticallyBrad King2017-11-132-1/+11
| | | | | | | | This will enable builds against a static Qt5 on Windows.
* | cmake-gui: Use cmake::Open to open generated projectGregor Jasny2017-10-134-28/+46
|/