summaryrefslogtreecommitdiffstats
path: root/Source/QtDialog
Commit message (Collapse)AuthorAgeFilesLines
* cmake-gui: Restore workaround for crash in file dialogBrad King2020-11-052-0/+14
| | | | | | | | | | In commit ce9dbceb42 (QtDialog: remove Qt4-only code, 2020-06-02, v3.19.0-rc1~712^2~1) we removed an event filter that was thought to be necessary only as a workaround for a bug in Qt. However, that bug was fixed in Qt 4.5, and the file dialog still crashes as of Qt 5.14 without the filter. Restore the workaround pending further investigation. Fixes: #21400
* Merge topic 'cmake-presets-help-flag' into release-3.19Brad King2020-10-281-1/+6
|\ | | | | | | | | | | | | c619be2784 ccmake: Don't list --preset in --help Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !5428
| * ccmake: Don't list --preset in --helpKyle Edwards2020-10-271-1/+6
| | | | | | | | | | | | And show available options in cmake-gui. Fixes: #21313
* | CMake GUI: Add --browse-manual argumentKyle Edwards2020-10-272-14/+22
|/
* CMakePresets.json: Rework how --preset argument is handledKyle Edwards2020-10-261-2/+1
| | | | | | | | If a path argument with no -S or -B leads to a cache directory, use that directory as the binary directory. Otherwise, use the binary directory from the preset. Fixes: #21311
* CMakePresets.json: Split cmakeGeneratorConfig fieldKyle Edwards2020-10-224-11/+19
| | | | | | | | Make this field separate for both architecture and toolset. Allow architecture and toolset to be either strings or objects with value and strategy fields. Fixes: #21317
* CMakePresets.json: Properly report macro expansion errorsKyle Edwards2020-10-211-11/+11
| | | | | | | | Make a distinction between strings which simply use the $vendor{<...>} macro, which is valid but makes it unusable by CMake, and strings which actually contain invalid macro expansions. Fixes: #21308
* CMake GUI: Disable preset fields instead of hiding themKyle Edwards2020-10-162-4/+15
|
* cmake-gui: Attach icons only to main GUI executablesBrad King2020-10-141-2/+2
| | | | | | | | | | In commit efe48189bf (cmake-gui: Restore application icon on macOS, 2020-10-13, v3.19.0-rc1~2^2) and commit f7ae4f572b (cmake-gui: Restore application icon on Windows, 2020-10-13, v3.19.0-rc1~1^2) we attached the icon source files to all consumers of `CMakeGUILib`, but that includes other libraries like `CMakeGUIMainLib`. The latter library is meant only for direct consumption by a GUI executable, so use that to propagate the icons instead.
* cmake-gui: Restore application icon on WindowsBrad King2020-10-131-5/+1
| | | | | | | In commit 41e223deb3 (CMake GUI: Split up into libraries, add test shim, 2020-09-14) the Windows resource source file that references the icon was moved to CMakeGUILib, but it needs to be directly in the main application in order to be attached properly.
* cmake-gui: Restore application icon on macOSBrad King2020-10-131-6/+6
| | | | | | | In commit 41e223deb3 (CMake GUI: Split up into libraries, add test shim, 2020-09-14) the macOS icon source file was moved to CMakeGUILib, but it needs to be directly in the main application in order to be attached to the `.app` in the right place.
* CMake GUI: Add presets functionalityKyle Edwards2020-10-0515-11/+762
|
* CMake GUI: Add "CMake Reference Manual" help itemKyle Edwards2020-09-301-2/+16
| | | | And switch the ordering of "Help" and "About".
* CMake GUI: Add environment editorKyle Edwards2020-09-289-37/+539
|
* CMake GUI: Modernize signal-slot connectionsKyle Edwards2020-09-277-149/+180
| | | | | | | Qt5 supports passing function pointers to QObject::connect(), and prefers this over SIGNAL() and SLOT(). Modernize the connections, stop using a deprecated signal from QComboBox, and modernize a few QKeySequence's.
* CMake GUI: Split up into libraries, add test shimKyle Edwards2020-09-233-7/+31
|
* QCMakeCacheView: Default to nullptr for parentKyle Edwards2020-09-231-1/+1
|
* Modernize: Use #pragma once in all header filesKitware Robot2020-09-039-36/+9
| | | | | | | | | | | | | | | | #pragma once is a widely supported compiler pragma, even though it is not part of the C++ standard. Many of the issues keeping #pragma once from being standardized (distributed filesystems, build farms, hard links, etc.) do not apply to CMake - it is easy to build CMake on a single machine. CMake also does not install any header files which can be consumed by other projects (though cmCPluginAPI.h has been deliberately omitted from this conversion in case anyone is still using it.) Finally, #pragma once has been required to build CMake since at least August 2017 (7f29bbe6 enabled server mode unconditionally, which had been using #pragma once since September 2016 (b13d3e0d)). The fact that we now require C++11 filters out old compilers, and it is unlikely that there is a compiler which supports C++11 but does not support #pragma once.
* Merge topic 'cmake-gui-qt-5.14'Brad King2020-07-231-2/+3
|\ | | | | | | | | | | | | af6cf586f6 cmake-gui: Fix crash when built with Qt 5.14 or later Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !5045
| * cmake-gui: Fix crash when built with Qt 5.14 or laterBrad King2020-07-221-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | In commit d7679f6427 (QCMakeCacheView: use non-deprecated List and Set constructions, 2020-06-10, v3.18.0-rc2~13^2) the conversion of the `this->properties()` value to QSet is incorrect for Qt 5.14+. The problem is that `this->properties()` returns by value, so the range `this->properties().begin(), this->properties().end()` provides iterators to two different instances. Use an intermediate temporary copy of the value to get a consistent iterator range. Fixes: #20981
* | Merge topic 'cmake-gui-qt-5.14'Brad King2020-07-071-4/+4
|\ \ | |/ | | | | | | | | | | | | 8eb7cf9b5f cmake-gui: Fix compilation as C++14 with Qt 5.14 Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: Ben Boeckel <ben.boeckel@kitware.com> Merge-request: !4978
| * cmake-gui: Fix compilation as C++14 with Qt 5.14Brad King2020-07-061-4/+4
| | | | | | | | | | | | Fix code added by commit d7679f6427 (QCMakeCacheView: use non-deprecated List and Set constructions, 2020-06-10, v3.18.0-rc2~13^2), used conditionally on Qt 5.14 or above, to compile as C++14.
* | cmake: Remove broken '--warn-unused-vars' optionBrad King2020-06-294-18/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | This option has been broken since commit b9f9915516 (cmMakefile: Remove VarUsageStack., 2015-05-17, v3.3.0-rc1~52^2). That commit removed the check that an initialized variable has actually been used and caused the option to warn on every variable ever set. This was not caught by the test suite because the test for the feature only checked that warnings appear when needed and not that they do not appear when not needed. The option was never very practical to use. Remove it to avoid the runtime cost of usage tracking and checks for every variable (which we were doing even when the option was not used).
* | QCMakeWidgets: replace QDirModelBen Boeckel2020-06-151-9/+9
| |
* | QCMake: use loadRelaxed if availableBen Boeckel2020-06-151-0/+4
| | | | | | | | Added in 5.14 and load() was deprecated at the same time.
* | Merge topic 'cmake-gui-qt5-only'Brad King2020-06-125-145/+80
|\ \ | |/ |/| | | | | | | | | | | | | | | | | 4037beb747 QtDialog: remove Qt4 definition ce9dbceb42 QtDialog: remove Qt4-only code 8ea50749da QtDialog: use Qt5's imported targets 4ccc9921be QtDialog: use qt5 functions for special Qt sources e4d6015460 QtDialog: remove Qt4 support Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4836
| * QtDialog: remove Qt4 definitionBen Boeckel2020-06-091-3/+0
| |
| * QtDialog: remove Qt4-only codeBen Boeckel2020-06-094-45/+1
| | | | | | | | | | The `reset()` method was actually deprecated for 5.0 which means it can now be removed here.
| * QtDialog: use Qt5's imported targetsBen Boeckel2020-06-051-15/+9
| |
| * QtDialog: use qt5 functions for special Qt sourcesBen Boeckel2020-06-051-15/+17
| | | | | | | | | | Automoc is not supported in bootstrap builds, so it cannot be used unconditionally.
| * QtDialog: remove Qt4 supportBen Boeckel2020-06-051-91/+77
| |
* | QCMakeCacheView: use non-deprecated List and Set constructionsBen Boeckel2020-06-101-2/+15
|/
* CursesDialog: resolve clang-tidy warningsBen Boeckel2020-06-022-11/+1
| | | | | | | | | Fixes: - unnecessary bool expression (cmCursesMainForm) - removes a duplicate if/else branch (RegexExplorer) - collapses redundant if/else branch logic (CMakeSetupDialog and cmCursesStringWidget)
* QtDialog: avoid using deprecated APIsBen Boeckel2020-06-022-0/+47
|
* cmake-gui: Do not pass CMAKE_{C,CXX}_COMPILER items to cmake if emptyJiri Malak2020-04-271-4/+8
| | | | | | | If C or C++ compiler is not specified in the initial dialog, do not pass `CMAKE_C_COMPILER` or `CMAKE_CXX_COMPILER` cache entries for cross-compilation setup. Instead allow the normal search for the compiler to proceed.
* cmake-gui: Pass CMAKE_SYSTEM_PROCESSOR to from gui to cmakeJiri Malak2020-04-131-0/+3
| | | | | Add missing `CMAKE_SYSTEM_PROCESSOR` cmake cache entry to passed options for first configure. We already pass `CMAKE_SYSTEM_{NAME,VERSION}`.
* Merge topic 'cmprop-state'Brad King2020-03-271-5/+6
|\ | | | | | | | | | | | | a7f2ff16a4 cmState::GetCacheEntryProperty: return cmProp Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4522
| * cmState::GetCacheEntryProperty: return cmPropVitaly Stakhovsky2020-03-251-5/+6
| |
* | Remove redundant calls to CollapseFullPathBrad King2020-03-241-4/+2
|/ | | | | Remove calls where it is known the input is already a collapsed full path.
* Merge topic 'cmake-gui-open-check'Brad King2020-03-231-1/+1
|\ | | | | | | | | | | | | ecc0086bfc cmake-gui: Fix use-after-free in Open-possible check Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4508
| * cmake-gui: Fix use-after-free in Open-possible checkFrancisco Facioni2020-03-201-1/+1
| | | | | | | | | | Fix `QCMake::checkOpenPossible` to copy `toLocal8Bit().data()` before its lifetime expires.
* | cmState::GetCacheEntryValue: return cmPropVitaly Stakhovsky2020-03-171-12/+11
| |
* | Modernize memory managementMarc Chevrier2020-03-054-15/+16
| | | | | | | | Update internals of various classes.
* | cmake-gui: set generator field defaults from environmentCode Smith2020-02-062-3/+51
|/ | | | Fixes: #20251
* GlobalGenerator family: modernize memory managementMarc Chevrier2020-01-071-0/+1
|
* Add option to configure Ninja link job pool for CMake's own binariesBrad King2019-10-101-0/+4
| | | | | Create an undocumented `CMake_JOB_POOL_LINK_BIN` option that builders can set to avoid linking too many of our binaries at once.
* Revise include order using clang-format-6.0Kitware Robot2019-10-0111-32/+38
| | | | | Run the `clang-format.bash` script to update our C and C++ code to a new include order `.clang-format`. Use `clang-format` version 6.0.
* Help: fixed typos in PCH / Unity Build docCorentin Plouet2019-09-301-2/+2
| | | | + typos in source code
* clang-tidy: modernize-deprecated-headersRegina Pfeifer2019-09-161-2/+2
|
* clang-tidy: modernize-use-autoRegina Pfeifer2019-09-101-2/+1
| | | | | | Set the MinTypeNameLength option to an impossibly high value in order to limit the diagnostics to iterators. Leave new expressions and cast expressions for later.
generated by cgit v0.12 at 2025-01-25 05:49:01 (GMT)