summaryrefslogtreecommitdiffstats
path: root/Source/cmJsonObjects.cxx
Commit message (Collapse)AuthorAgeFilesLines
* Merge topic 'tidy_inefficient_string'Brad King2019-08-071-3/+3
|\ | | | | | | | | | | | | 18b0330b86 clang-tidy: Enable performance-inefficient-string-concatenation Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !3648
| * clang-tidy: Enable performance-inefficient-string-concatenationSebastian Holtermann2019-08-051-3/+4
| | | | | | | | | | | | | | Enables the clang-tidy test performance-inefficient-string-concatenation and replaces all inefficient string concatenations with `cmStrCat`. Closes: #19555
* | cmStringAlgorithms: cmIsSpace, cmTrimWhitespace, cmEscapeQuotes, cmTokenizeSebastian Holtermann2019-08-051-8/+9
|/ | | | | | | | | | This adds the following functions to `cmStringAlgorithms`: - `cmIsSpace` - `cmTrimWhitespace` (moved from `cmSystemTools::TrimWhitespace`) - `cmEscapeQuotes` (moved from `cmSystemTools::EscapeQuotes`) - `cmTokenize` (moved from `cmSystemTools::tokenize` and adapted to accept `cm::string_view`)
* Refactor checks for whether a target has an import libraryBrad King2019-07-121-1/+3
| | | | Use `HasImportLibrary` for such checks.
* IWYU: Fix handling of <memory> standard headerBrad King2019-07-101-0/+1
| | | | | | | | An old workaround for `std::allocator_traits<>::value_type` lints from IWYU on `std::vector<>` usage breaks IWYU's handling of `<memory>`. Convert the workaround to use the same approach we already use for a workaround of `std::__decay_and_strip<>::::__type` lints. Then update the `<memory>` inclusions to follow the now-correct IWYU lints.
* cmPropertyMap: Use std::string as value container classSebastian Holtermann2019-06-081-1/+0
|
* cmPropertyMap: Add GetList methodSebastian Holtermann2019-06-081-2/+2
|
* Use cmAppend to append ranges to std::vector instancesSebastian Holtermann2019-05-231-2/+2
|
* Use cmSourceFile::GetIsGeneratedSebastian Holtermann2019-02-011-1/+1
|
* cmLocalGenerator: Simplify `GetIncludeDirectories`Sebastian Holtermann2019-01-281-1/+1
| | | | | | | | | | | | | | | | | | This patch strips the `stripImplicitDirs` and `appendAllImplicitDirs` parameters from the `cmLocalGenerator::GetIncludeDirectories` method and makes it a wrapper into the new `cmLocalGenerator::GetIncludeDirectoriesImplicit` method. `cmLocalGenerator::GetIncludeDirectoriesImplicit` is the renamed old implementation of `cmLocalGenerator::GetIncludeDirectories` and still accepts `stripImplicitDirs` and `appendAllImplicitDirs`. The motivation is that there's only *one* case where `cmLocalGenerator::GetIncludeDirectories` is called with the `stripImplicitDirs` parameter being `false` (QtAutoGen), but many other places where it is called using the `true` default value. QtAutoGen is modified to use `cmLocalGenerator::GetIncludeDirectoriesImplicit` directly. In two use cases of `cmLocalGenerator::GetIncludeDirectories` the manually set `true` value for `stripImplicitDirs` is removed.
* clang-tidy: Use emplaceRegina Pfeifer2019-01-171-7/+7
|
* IWYU: Update CMake code for IWYU built with Clang 6Brad King2019-01-151-0/+1
| | | | | IWYU now correctly requires `<utility>` for `std::move`. It also requires a container header when used via a range-based for loop.
* Server mode: Fix regression of hasInstallRuleKyle Edwards2018-12-121-2/+8
| | | | | | | | The introduction of policy CMP0082, to run subdirectory install rules in the correct order, caused a regression in server mode where any directory with a subdirectory is marked as having an install rule even if no "real" install rules are present. This change fixes this regression for server mode.
* clang-tidy: Fix readability-static-accessed-through-instanceRegina Pfeifer2018-11-211-2/+1
| | | | Enable the check in .clang-tidy and fix all warnings.
* cmake-server: Revert "Support codemodel filegroups for INTERFACE_SOURCES"Brad King2018-10-171-175/+39
| | | | | | | | | | | | | Revert commit v3.13.0-rc1~144^2 (cmake-server: Support codemodel filegroups for INTERFACE_SOURCES, 2018-08-10). The changes activate code paths not meant to be used with interface libraries. Another approach will be needed to expose this information later. This revert has to be done by hand because the code in question has been changed somewhat since the changes were made, and was also factored out to another source file. Fixes: #18463
* server: Compile json object generation source separatelyBrad King2018-09-211-12/+16
| | | | | Declare entry points in a dedicated header and compile the source separately instead of including it in the server implementation.
* server: Split json object generation into separate sourceBrad King2018-09-211-0/+819
For now just move the content and `#include` it back in to the original translation unit. That way `git blame` can cleanly track the original lines.