summaryrefslogtreecommitdiffstats
path: root/Source/cmOutputConverter.cxx
Commit message (Collapse)AuthorAgeFilesLines
* Add support for build tree symlink inside source treeBrad King2022-02-281-4/+42
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since commit c564a3e3ff (Ninja: Always compile sources using absolute paths, 2021-05-19, v3.21.0-rc1~129^2), both the Ninja and Makefile generators pass source files and include directories to the compiler as absolute paths. However, in some other contexts within generated build systems, we generate paths that may be relative or absolute. In these contexts, we prefer relative paths, but avoid them when they contain a `../` sequence that leaves both the build tree and the source tree: * When the build tree is outside of the source tree, all paths to the source tree are absolute. * When the build tree is inside the source tree, we previously assumed that it is a real directory such that exiting the build tree with `../` enters the source tree. This allowed paths to the source tree to be relative to the build tree. In the latter case, we previously did not support using a symbolic link inside the source tree to point at the build tree. This is because relative paths to the source tree would be generated with `../` sequences leaving the build tree, but they would jump to the parent of the real build tree, which is not the source tree. Fix this by requiring that `../` sequences stay inside the build tree even if its path appears to be inside the source tree. When the build tree is inside the source tree, all paths to the source tree are now absolute. For consistency, this applies regardless of whether the path to the build tree contains a symbolic link. Fixes: #21819
* cmOutputConverter: Always set relative path top source and binary togetherBrad King2022-02-281-7/+4
| | | | | Refactor to set both at once so we have a single place in the code that knows both have been set.
* cmOutputConverter: Cache Short PathsClemens Wasser2022-01-251-4/+26
| | | | | | | | Cache the Short Paths since we only convert the same few paths anyway and calling `GetShortPathNameW` is really expensive. Also, compile the code path only on Windows hosts since it only runs when using a Windows Shell anyway.
* cmOutputConverter: Quote hyphens in response filesBrendan O'Rourke2021-11-081-4/+16
| | | | Fixes: #20070
* EscapeForCMake: Add wrapQuotes parameterKyle Edwards2021-10-271-3/+6
|
* Source: Fix clang -Wextra-semi warningsSean McBride2021-09-281-1/+1
|
* Move helpers functions from cmStringAlgorithms.h to cmValue.hMarc Chevrier2021-09-211-0/+1
| | | | | Helpers functions related to cmValue semantic are now part of cmValue.h header.
* cmOutputConverter: Adopt relative path conversion helpersBrad King2021-05-171-0/+94
| | | | Move them up from cmLocalGenerator and out of cmStateDirectory.
* clang-tidy: fix `bugprone-reserved-identifier` warningsBen Boeckel2021-01-271-21/+20
|
* Fortran: Add Fortran_PREPROCESS propertyPeter Hill2020-05-211-0/+11
| | | | Issue: #18870
* cmOutputConverter::GetFortranFormat(): delete const char* overloadVitaly Stakhovsky2020-04-271-9/+0
|
* Makefiles: Convert paths with '#' on command-lines to short path on WindowsBrad King2020-04-151-1/+1
| | | | | | | In `ConvertToOutputForExisting` we convert paths with spaces to short paths on Windows for use on command lines, e.g. for include directories. Do the same for paths with `#` since tools like NMake do not have a way to reliably put `#` in variable assignments.
* Ninja: Add multi-config variantKyle Edwards2019-12-131-5/+18
| | | | Co-Authored-by: vector-of-bool <vectorofbool@gmail.com>
* clang-tidy: modernize-deprecated-headersRegina Pfeifer2019-09-161-2/+2
|
* Source code: Use cmExpandList instead of cmSystemTools::ExpandListArgumentSebastian Holtermann2019-08-141-1/+2
|
* cmOutputConverter: Make shell escaping methods cm::string_view basedSebastian Holtermann2019-07-281-57/+55
|
* cmOutputConverter: Let GetFortranFormat accept a cm::string_viewSebastian Holtermann2019-07-281-5/+12
|
* cmOutputConverter: Return bool instead of int in utility functionsSebastian Holtermann2019-07-281-16/+16
|
* cmOutputConverter: Let cmOutputConverterIsShellOperator accept cm::string_viewSebastian Holtermann2019-07-281-2/+2
|
* cmOutputConverter: Let cmOutputConverterIsShellOperator accept cm::string_viewSebastian Holtermann2019-07-281-2/+2
|
* cmOutputConverter: Let EscapeForCMake accept a cm::string_viewSebastian Holtermann2019-07-281-6/+6
|
* cmOutputConverter: Initialize static std::set on constructionSebastian Holtermann2019-06-041-16/+4
|
* cmOutputConverter: move ConvertToRelativePath to cmStateDirectory.Bruno Manganelli2019-01-271-12/+0
|
* cmOutputConverter: Moved ContainedInDirectory to cmStateDirectoryBruno Manganelli2018-12-081-33/+2
|
* cmOutputConverter: Moved ForceToRelativePath to cmSystemBruno Manganelli2018-12-071-75/+1
|
* clang-tidy: Fix readability-static-accessed-through-instanceRegina Pfeifer2018-11-211-1/+1
| | | | Enable the check in .clang-tidy and fix all warnings.
* Using front() and back() instead of calculationsCengizhan Pasaoglu2018-11-061-3/+3
|
* cmStateDirectory: use const std::string& for return valuesVitaly Stakhovsky2018-08-121-2/+2
|
* cmOutputConverter: mark helper functions staticRolf Eike Beer2018-03-061-6/+4
| | | | This allows the linker to entirely drop any symbols of the functions.
* cmOutputConverter: Inline some functions and avoid string re-allocationsFrank Winklmeier2018-02-231-32/+37
| | | | | | | Use std::string (with correct initial size) in cmOutputConverter::Shell__GetArgument instead of ostringstream. This avoids several re-allocations of the string buffer. In addition, convert some of the private static members into inline free functions to avoid function calls.
* Reduce raw string pointers usage.Pavel Solodovnikov2018-01-311-2/+2
| | | | | | | | | | * Change some functions to take `std::string` instead of `const char*` in the following classes: `cmMakeFile`, `cmake`, `cmCoreTryCompile`, `cmSystemTools`, `cmState`, `cmLocalGenerator` and a few others. * Greatly reduce using of `const char*` overloads for `cmSystemTools::MakeDirectory` and `cmSystemTools::RelativePath`. * Remove many redundant `c_str()` conversions throughout the code.
* Meta: modernize old-fashioned loops to range-based `for`.Pavel Solodovnikov2017-09-121-4/+3
| | | | | | Changes done via `clang-tidy` with some manual fine-tuning for the variable naming and `auto` type deduction where appropriate.
* Replace C-style castsDaniel Pfeifer2017-08-271-1/+1
|
* Pass large types by const&, small types by valueDaniel Pfeifer2017-06-031-2/+2
|
* Fix several include-what-you-use findingsDaniel Pfeifer2016-11-081-5/+6
|
* cmState: Split auxiliary classes into separate filesStephen Kelly2016-10-191-0/+2
| | | | | | | Port dependents to the new locations as needed. Leave behind a cmState.h include in cmListFileCache to reduce noise. It is removed in a following commit.
* cmState: Port dependent code to new cmStateSnapshot nameStephen Kelly2016-10-191-1/+1
|
* cmState: Port dependent code to new cmStateDirectory nameStephen Kelly2016-10-191-1/+1
|
* cmOutputConverter: Add a flag for IsUnixStephen Kelly2016-10-061-16/+16
| | | | Remove the need for method parameters to represent the distinction.
* Convert: Inline platform-specific methodsStephen Kelly2016-10-061-16/+3
| | | | They don't provide real value.
* Convert: Extract method to determine if paths are in directoryStephen Kelly2016-10-061-5/+13
| | | | | | The conditional early return can be moved to clients, which would have many benefits, notably making cmOutputConverter independent of directory-specific state.
* Convert: Remove asserts which are duplicated in delegate methodStephen Kelly2016-10-061-7/+0
| | | | | This means that we don't encounter the asserts in the case where we early-return from here.
* Convert: Remove early return checkStephen Kelly2016-10-061-5/+0
| | | | This function delegates to another function which does the same check.
* Convert: Extract local variables for readabilityStephen Kelly2016-10-061-12/+13
|
* Convert: Extract local variablesStephen Kelly2016-10-061-14/+17
| | | | Remove comment made obsolete by them.
* cmOutputConverter: remove unused codeDaniel Pfeifer2016-10-061-9/+0
| | | | | Remove old ConvertToRelativePath function now that all clients have migrated to the new signature.
* Simplify CMake per-source license noticesBrad King2016-09-271-11/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | Per-source copyright/license notice headers that spell out copyright holder names and years are hard to maintain and often out-of-date or plain wrong. Precise contributor information is already maintained automatically by the version control tool. Ultimately it is the receiver of a file who is responsible for determining its licensing status, and per-source notices are merely a convenience. Therefore it is simpler and more accurate for each source to have a generic notice of the license name and references to more detailed information on copyright holders and full license terms. Our `Copyright.txt` file now contains a list of Contributors whose names appeared source-level copyright notices. It also references version control history for more precise information. Therefore we no longer need to spell out the list of Contributors in each source file notice. Replace CMake per-source copyright/license notice headers with a short description of the license and links to `Copyright.txt` and online information available from "https://cmake.org/licensing". The online URL also handles cases of modules being copied out of our source into other projects, so we can drop our notices about replacing links with full license text. Run the `Utilities/Scripts/filter-notices.bash` script to perform the majority of the replacements mechanically. Manually fix up shebang lines and trailing newlines in a few files. Manually update the notices in a few files that the script does not handle.
* cmOutputConverter: Remove now-obsolete Convert methodStephen Kelly2016-09-191-23/+0
|
* Convert: Remove HOME_OUTPUT enum valueStephen Kelly2016-09-191-3/+0
|
* Convert: Simplify switchStephen Kelly2016-09-191-5/+4
| | | | Make it more clear what is happening here.