| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
When using GCC 8's standard library IWYU thinks that `<system_error>`
must be included to get `std::hash`. Add a mapping for `<utility>`.
|
|
|
|
|
|
|
|
|
|
|
|
| |
Run the `clang-format.bash` script to update all our C and C++ code to a
new style defined by `.clang-format`. Use `clang-format` version 6.0.
* If you reached this commit for a line in `git blame`, re-run the blame
operation starting at the parent of this commit to see older history
for the content.
* See the parent commit for instructions to rebase a change across this
style transition commit.
|
|
|
|
|
|
|
|
|
| |
When evaluating `INTERFACE_SYSTEM_INCLUDE_DIRECTORIES`, or evaluating
`INTERFACE_INCLUDE_DIRECTORIES` on an imported target, thread the
compile language through to the generator expression evaluator so
that it can support `$<COMPILE_LANGUAGE:...>`.
Fixes: #17811
|
|
|
|
|
|
|
|
|
|
| |
* Change some functions to take `std::string` instead of
`const char*` in the following classes: `cmMakeFile`, `cmake`,
`cmCoreTryCompile`, `cmSystemTools`, `cmState`, `cmLocalGenerator`
and a few others.
* Greatly reduce using of `const char*` overloads for
`cmSystemTools::MakeDirectory` and `cmSystemTools::RelativePath`.
* Remove many redundant `c_str()` conversions throughout the code.
|
|
|
|
|
| |
- Use `std::move` while inserting temporary results into vectors.
- Change `push_back` to `emplace_back` where appropriate.
|
|\
| |
| |
| |
| |
| |
| |
| | |
239a3ef8 Server-mode: Document protocol version for optional handshake arguments
9b1a3d24 Server-mode: Rename functions to reflect what they do
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !1693
|
| |
| |
| |
| |
| | |
Rename the test* static functions to getOrTest* to better reflect
what they do now.
|
| | |
|
|/
|
|
|
|
|
| |
Add the support of per-source property COMPILE_OPTIONS,
including generator expressions support.
Related: #17507
|
|
|
|
|
|
|
| |
If a CMakeLists.txt file doesn't contain cmake_minimum_required then the
server was crashing. The root cause was the json object model does not
support null and was crashing. Add the null check and use an empty
string in this case.
|
| |
|
|
|
|
| |
Fixes: #17542
|
|\
| |
| |
| | |
revert-server-target-backtraces
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The backtrace information is very repetitive and hugely increases the
size of the codemodel object. We need to remove it until an alternative
representation can be developed. Revert commit v3.10.0-rc1~393^2
(server: Report backtraces in codemodel response, 2017-06-20), except
for the protocol version number (because it indicates other new things).
Unfortunately this is incompatible with clients that expect the
"crossReferences" field in targets. However, the regression in memory
usage is quite serious, especially on large projects, and therefore
breaks even older clients that do not use backtraces. Since the
"crossReferences" field was only provided by one release (3.10.0), it is
simplest to revert it outright for 3.10.1.
Fixes: #17502
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Backtrace information was included by commit 35a52bd1b4 (server: add
"ctestInfo" request to get test info, 2017-10-25) to match that already
provided for targets. However, the backtrace representation uses too
much memory and needs to be dropped. Remove it from test information.
Issue: #17502
|
| |
| |
| |
| |
| |
| | |
This allows users to specify different genex-based compile definitions for each file in a target.
Fixes: #17508
|
| |
| |
| |
| |
| |
| | |
Prepare to add generator expression support to more source properties.
Factor out some duplicated code into a helper to avoid further
duplication.
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | | |
afd9a339 server: return whether or not a target is generator provided
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !1475
|
| | |
| | |
| | |
| | |
| | |
| | | |
Some generators auto-generate targets. For example VS generators create
the ALL_BUILD target. Add the ability to mark targets as generator
provided and return that info through cmake-server codemodel.
|
|\ \ \
| |/ /
|/| |
| | |
| | |
| | |
| | | |
fe2c2b0f server: ctestInfo fix to return all tests
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !1479
|
| | |
| | |
| | |
| | |
| | | |
Prior to this change we were looking at targets. But tests are
associated with directories. This change fixes how we gather all tests.
|
|/ /
| |
| |
| |
| | |
Need to check all generators associated with the project because any of
them may have an install rule.
|
| | |
|
| | |
|
|/
|
|
|
| |
Protocol version is updated to 1.2 since this is a change
to what was released in cmake version 3.10.
|
|
|
|
|
|
|
| |
Fix issues diagnosed by clang-tidy by pre-allocating the vector capacity
before the loop [performance-inefficient-vector-operation].
Signed-off-by: Matthias Maennich <matthias@maennich.net>
|
|
|
|
|
|
| |
Changes done via `clang-tidy` with some manual fine-tuning
for the variable naming and `auto` type deduction
where appropriate.
|
| |
|
|\
| |
| |
| |
| |
| |
| | |
190e3825 Replace C-style casts
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !1176
|
| | |
|
|/ |
|
| |
|
| |
|
|
|
|
|
|
|
| |
CMake's copy of json-cpp is not aware of rvalues yet. It is confusing
to pass the result of std::move to a function that takes a const&
because no move will actually happen. This change may be reverted once
CMake upgrades to a new version of json-cpp.
|
| |
|
|
|
|
| |
Fixes: #16989
|
|
|
|
|
|
|
| |
If a required value is in the cache, it is not necessary to set it
explicitly.
Fixes: #16948, #16988
|
|\
| |
| |
| |
| |
| |
| | |
70272f3c server: Fix crash on missing cache entries
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !1096
|
| |
| |
| |
| | |
Test for nullptr before constructing std::string.
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
cf0ae55d server: Add support for connections that aren't event based
5ddfb6a4 server: Add connection as part of a request
d4f5d35c server: Refactor to make the event loop owned by server object
5acbf08b Tests: Teach Server test to forward exit code from server process
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !552
|
| |/ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Report the source locations (e.g. in `CMakeLists.txt`) for all targets
and target-related statements. This allows IDEs to locate the
statements and automatically edit them when the user adds or removes
files or changes target properties via GUI.
Increment the protocol minor version number to tell clients that the new
information is available.
|
|/
|
|
|
|
| |
It will serve additional minor versions.
Suggested-by: Tobias Hunger <tobias.hunger@qt.io>
|
| |
|
| |
|
| |
|
|
|
|
|
| |
Named enumeration values are much clearer at call sites and add more
type safety.
|
|\
| |
| |
| |
| |
| |
| | |
8285ad51 server-mode: Make CMAKE_HOME_DIRECTORY more reliable
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !611
|
| |
| |
| |
| |
| |
| |
| | |
Make CMAKE_HOME_DIRECTORY detection work more reliably in the face
of symlinks.
Closes #16736
|
| |
| |
| |
| | |
Closes: #16539
|