summaryrefslogtreecommitdiffstats
path: root/Source/cmSystemTools.cxx
Commit message (Collapse)AuthorAgeFilesLines
* Encoding: Fix debug asserts parsing command line options with non-ascii chars.Clinton Stimpson2014-06-171-1/+1
| | | | With MSVC, isspace() will assert with non-ascii characters.
* cmSystemTools: Add callback for StderrBrad King2014-05-151-14/+25
| | | | | | | | | Factor a common callback type out of StdoutCallback. Add an equivalent StderrCallback. While at it, use "size_t" for the data length instead of "int". Teach "ctest --build-and-test" to capture the Stderr callback because output sent through it is part of the logical CMake process output.
* cmSystemTools: Simplify InterruptCallback definitionBrad King2014-05-151-2/+2
| | | | | Use the typedef to declare the member instead of duplicating the type. Use default initialization instead of an explicit zero initializer.
* cmSystemTools: Rename ErrorCallback to MessageCallbackBrad King2014-05-151-9/+8
| | | | | Clarify that it is the callback for the cmSystemTools::Message API. Rename callback clients too.
* Merge topic 'fix-atomic-rename-Windows-sharing-violation'Brad King2014-05-141-2/+4
|\ | | | | | | | | 24bd7ae1 cmSystemTools::RenameFile: Retry on Windows ERROR_SHARING_VIOLATION
| * cmSystemTools::RenameFile: Retry on Windows ERROR_SHARING_VIOLATIONEric Berge2014-05-131-2/+4
| | | | | | | | | | | | | | Add ERROR_SHARING_VIOLATION to the set of errors (previously including only ERROR_ACCESS_DENIED) that cause a rename (MoveFile) on Windows to retry. The condition was observed when two renames to the same target file name were happening simultaneously.
* | cmSystemTools: Remove unreachable return on HP compilerBrad King2014-04-081-1/+1
| | | | | | | | | | | | | | Follow up commit 1de08685 (cmSystemTools: Restore unreachable return to silence warnings, 2014-04-02) by excluding the unreachable return on the HP compiler as well as Clang. Both recognize that it is unreachable and warn.
* | Re-word comment on unreachable return statementsBrad King2014-04-071-1/+1
| | | | | | | | | | Do not use the word "warning" in the comment because CTest launchers match it and CTestCustom.cmake.in does not suppress it.
* | Merge topic 'clang-warnings'Brad King2014-04-031-0/+3
|\ \ | | | | | | | | | | | | 1de08685 cmSystemTools: Restore unreachable return to silence warnings
| * | cmSystemTools: Restore unreachable return to silence warningsBrad King2014-04-021-0/+3
| | | | | | | | | | | | | | | | | | | | | Some compilers do not recognize that the end of copy_data cannot be reached and complain that there is no return statement. Clang warns that there is an unreachable return statement if it appears. Conditionally add the return statement when not building with Clang.
* | | Merge topic 'clang-warnings'Brad King2014-04-011-1/+0
|\ \ \ | |/ / | | | | | | | | | | | | 8c9c4fe1 Remove 'return' statements that can never be reached 50ca77f4 create_test_sourcelist: Initialize variable at declaration
| * | Remove 'return' statements that can never be reachedSean McBride2014-03-311-1/+0
| |/ | | | | | | Clang -Wunreachable-code-return warns otherwise.
* | Remove some c_str() calls.Stephen Kelly2014-03-111-3/+3
| | | | | | | | | | | | Use the clang RemoveCStrCalls tool to automatically migrate the code. This was only run on linux, so does not have any positive or negative effect on other platforms.
* | strings: Remove cmStdString referencesBen Boeckel2014-03-081-41/+9
| | | | | | | | | | | | | | | | | | | | | | Casts from std::string -> cmStdString were high on the list of things taking up time. Avoid such implicit casts across function calls by just using std::string everywhere. The comment that the symbol name is too long is no longer relevant since modern debuggers alias the templates anyways and the size is a non-issue since the underlying methods are generated since it's inherited.
* | stringapi: Take strings in escaping functionsBen Boeckel2014-03-081-3/+4
| |
* | stringapi: Use strings for globbing parametersBen Boeckel2014-03-081-6/+6
| |
* | stringapi: Accept strings when MD5 hashing dataBen Boeckel2014-03-081-2/+2
| |
* | ExpandListArguments: Optimize the parserBen Boeckel2014-02-211-33/+18
|/ | | | | | Optimize cmSystemTools::ExpandListArguments so as not to build a string character-by-character. This avoids excess reallocations of the result string.
* Windows: Make file delete/rename retry configurableBrad King2014-02-121-4/+42
| | | | | | | | | | | | | | | | | | Several CMake operations need to replace files in rapid succession. This commonly fails on Windows due to filesystem lock behavior so we have retry loops. No matter how many times we retry or how long we delay there will inevitably be someone with an environment that needs more. Make the retry count and delay configurable in the Windows Registry keys: {HKCU,HKLM}/Software/Kitware/CMake/Config in DWORD values FilesystemRetryCount = Number of tries FilesystemRetryDelay = Delay in milliseconds between tries Leave the feature undocumented for now to see how it goes.
* Merge topic 'minor-cleanups'Brad King2014-01-071-10/+3
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3917d86 Genex: Add a nullary form for CONFIG 5169130 Help: Document the target properties exported to IMPORTED targets. ee21f1c CompatibleInterface: Test debugging of not-set property. 80e9fe9 Help: Note that language-specific 'built-ins' are set by the project command. 0b5bf8a Help: Mention CMAKE_DISABLE_FIND_PACKAGE_<PackageName> in package docs. 28c865b Tests: simplify Qt4 target usage 6cfe6b8 Help: Fix typo: 'target' -> 'target property' b7deca4 Test: Remove obsolete commented code. 9c9f69f Genex: Make EQUAL support upper case binary literals 6eb3218 Genex: Fix case of methods in the dag checker. 646c6ec Genex: Use a preprocessor loop to implement transitive DAG check. 711fb38 Genex: List transitive properties and methods as a table, not two lists. 802a28f Add cmHasLiteralSuffix API.
| * Add cmHasLiteralSuffix API.Stephen Kelly2014-01-061-10/+3
| |
* | Use cmsys::[io]fstream instead of cmsys_ios::[io]fstream.Clinton Stimpson2014-01-071-6/+7
|/ | | | | Also use SystemTools::Fopen() instead of fopen(). This is to eventually support utf-8 filenames.
* Windows: Use wide-character system APIsClinton Stimpson2013-12-091-11/+21
| | | | | Make CMake compile with -DUNICODE. Make it possible for the 8 bit encoding to eventually be UTF-8 instead ANSI.
* cmSystemTools: Add PrintSingleCommand methodBrad King2013-11-151-0/+17
| | | | | Add a method to print a command line for human reference by simply double-quoting every argument.
* cmSystemTools: Add RunSingleCommand overload for std::vector<std::string>Brad King2013-11-151-1/+17
|
* Refactor internal resource location APIs and initializationBrad King2013-11-121-9/+143
| | | | | | | | | | | | | | | | | | | | Rename cmSystemTools::FindExecutableDirectory to FindCMakeResources. Teach it to compute the locations of cmake, ctest, cpack, ccmake, and cmake-gui executables, and the location of CMAKE_ROOT. Provide this information from static cmSystemTools::Get<resource>() methods. Refactor code that needs these locations to use the new APIs. Teach FindCMakeResources to use the OS X system API to lookup the executable location. When running from the CMake build tree itself, leave a file in the tree that FindCMakeResources can use to read the location of the source tree. This avoids the need to compile the source tree location into a binary that may be installed and used without the source tree. Teach the QtDialog on OS X to create a "cmake-gui" symlink in the build tree next to "cmake" and the other tools, as is already done in the install tree for the application bundle. This ensures a consistent set of executables are available in one directory.
* cmake: Avoid '-E tar' failure to extract symlinks on Windows (#13251)Brad King2013-11-011-0/+8
| | | | | | | If a symlink fails to extract and the host system is Windows then report a warning and skip the entry instead of failing. This will allow archives containing symbolic links to be extracted on Windows with somewhat gracefully degraded behavior.
* cmSystemTools: Re-order extract_tar logicBrad King2013-11-011-20/+21
| | | | | | | Simplify extraction message logic to be easier to follow and to write a newline before any error messages that may be produced. Also flip handling of the archive_write_header return code to handle success in the "then" case and failure in the "else" case.
* cmSystemTools: Drop old RunCommand methodBrad King2013-10-191-358/+0
| | | | | All calls to this method have been replaced by newer infrastructure. Remove it and the supporting cmWin32ProcessExecution class.
* Teach --help-* options to load documentation from .rst filesBrad King2013-10-161-0/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Install the Help directory next to Modules to make it available in CMake distributions. Use cmRST to read Help .rst documents and print them as help output. Add options --help-manual-list --help-manual to list available manuals or print one of them. Implement the options --help-commands --help-modules --help-policies --help-properties --help-variables by mapping to the corresponding manual page. Implement the options --help-command-list --help-module-list --help-policy-list --help-property-list --help-variable-list by globbing the available Help .rst documents of the corresponding type and reading their titles. Implement the options --help-command --help-module --help-policy --help-property --help-variable by globbing the matching Help .rst document(s) and printing them.
* Merge topic 'passthru'Brad King2013-07-311-1/+7
|\ | | | | | | | | 2b473d2 Add option to use stdout/stderr of original terminal in cmake --build
| * Add option to use stdout/stderr of original terminal in cmake --buildPatrick Gansterer2013-07-291-1/+7
| | | | | | | | | | | | Pass the original file handles to the native tool when using the --use-stderr option in the build command. This enables the usage of advanced terminal features like colored output.
* | OS X: If necessary, use xcrun to help find otool used to query install names.Clinton Stimpson2013-07-271-1/+9
|/ | | | | This fixes querying for @rpath install names when using Xcode without the command line tools installed.
* VS: Avoid leaking child process output back to IDE (#14266)Brad King2013-07-161-1/+9
| | | | | | | | | | | | | | The VS IDE sets the environment variable VS_UNICODE_OUTPUT when executing build rules in order to tell MS tools to report output through a back door instead of through stdout/stderr. Unset this variable so that CMake can capture or properly redirect all output from processes it runs even when running inside a VS IDE build environment. This generalizes the special cases fixed by commit 80d045b0 (When GetPrerequisites.cmake runs dumpbin while running inside the VS IDE..., 2008-05-01) and commit 44aff73d (ExternalProject: Avoid bleed-through output when logging, 2011-01-06), so drop special handling of VS_UNICODE_OUTPUT in those instances.
* Merge topic 'make-depends-collapse-paths'Brad King2013-07-021-0/+34
|\ | | | | | | | | 551d334 cmDependsC: Collapse relative include paths
| * cmDependsC: Collapse relative include pathsPavel Shramov2013-06-261-0/+34
| | | | | | | | | | | | | | | | | | While calculating dependencies collapse sequences such as ../../../a/b/c/../../d/e/../../e/f to avoid total path lengths over the Windows path length limit as much as possible.
* | Merge topic 'version-compare-genex'Brad King2013-06-261-5/+10
|\ \ | | | | | | | | | | | | | | | e605528 Add generator expressions for version comparision. 48bb48e De-duplicate version comparison code.
| * | De-duplicate version comparison code.Stephen Kelly2013-06-121-5/+10
| | | | | | | | | | | | | | | Extend the VersionCompare in cmSystemTools to handle 8 components, and port the if command to use that.
* | | Add whitespace after colons in error messages.Stephen Kelly2013-06-211-1/+1
| |/ |/|
* | OS X: Improvements for getting install name of dylib.Clinton Stimpson2013-06-061-1/+4
|/ | | | | In the case of a multi-arch dylib where none of the architectures is the host architecture, otool -D returned multiple install names.
* OS X: Add RPATH support for Mac.Clinton Stimpson2013-06-031-0/+21
| | | | | | | | | RPATH support is activated on targets that have the MACOSX_RPATH property turned on. For install time, it is also useful to set INSTALL_RPATH to help find dependent libraries with an @rpath in their install name. Also adding detection of rpath conflicts when using frameworks.
* cmSystemTools: Generalize TrimWhitespace to all whitespacePetr Kmoch2013-03-271-2/+2
| | | | | Modify cmSystemTools::TrimWhitespace() to remove all leading and trailing whitespace, not just spaces.
* Fix cmSystemTools::RenameFile race on WindowsBrad King2013-02-041-31/+20
| | | | | | | | | | | | | | | Since commit d46d8df0 (Re-implemented cmGeneratedFileStream to look like a real stream and replace the destination file atomically, 2004-11-03) our RenameFile implementation tries to deal with MoveFile not replacing read-only files. In order to avoid the Get/SetFileAttributes pair we used stat to test for existence of the destination file. This has a race in which the destination could be created between the test for existence and the MoveFile call. Remove the stat call and use GetFileAttributes to detect whether the file exists. This shortens the race but does not eliminate it. Use a loop to try multiple times in case we lose the race. While at it, drop Win9x support and always use MoveFileEx.
* Merge topic 'use-cmsys-auto_ptr'Brad King2012-11-271-1/+0
|\ | | | | | | | | ddc0520 Always use the auto_ptr from cmsys.
| * Always use the auto_ptr from cmsys.Stephen Kelly2012-11-201-1/+0
| | | | | | | | | | | | This is for consistency throughout cmake. The cmsys version exists becaues uses of auto_ptr types as return types does not work with some implementations in ancient compilers.
* | CMake: Fix infinite loop untarring corrupt tar fileDavid Cole2012-11-261-2/+5
|/ | | | Suggested-by: Robert Maynard <robert.maynard@kitware.com>
* Merge topic 'kwsys-environ-cleanup'David Cole2012-05-011-35/+14
|\ | | | | | | | | | | e48796b KWSys: Fix SystemTools environment memory handling (#13156) b10c5cb CTest: Simplify environment save/restore
| * CTest: Simplify environment save/restoreBrad King2012-04-241-35/+14
| | | | | | | | | | | | | | | | Replace use of AppendEnv/RestoreEnv pairs with instances of SaveRestoreEnvironment. Simplify the signature of AppendEnv and use it in place of similar loops elsewhere. Move the RestoreEnv implementation inside the SaveRestoreEnvironment destructor which is the only place left that calls it.
* | Merge topic 'mac_environ'David Cole2012-04-251-0/+3
|\ \ | |/ |/| | | | | a90d478 [OSX] Fixed undefined symbol when linking CMakeLib into shared library
| * [OSX] Fixed undefined symbol when linking CMakeLib into shared libraryKonstantin Tokarev2012-03-031-0/+3
| |