summaryrefslogtreecommitdiffstats
path: root/Source/cmXCodeObject.cxx
Commit message (Collapse)AuthorAgeFilesLines
* Xcode: use ranged for loops, cleanup existing for loopsCraig Scott2017-11-101-15/+11
| | | | | | | | | | The changes are mostly converting old-style explicit iterator for loops into ranged for statements. A number of for loops had already been changed over, but local variables had been left behind instead of being absorbed into the ranged for statement, so these have been cleaned up too. A couple of minor improvements were made in areas already being updated by the for loop changes to slightly simplify the code or to avoid unnecessary conversions between `const char*` and `std::string`.
* Fix some occurrences of readability-braces-around-statementsMatthias Maennich2017-09-281-1/+2
| | | | | | Fix issues diagnosed by clang-tidy [readability-braces-around-statements] Signed-off-by: Matthias Maennich <matthias@maennich.net>
* Convert some leftover loops to C++11 range-based loopMatthias Maennich2017-09-281-3/+3
| | | | | | Fix issues diagnosed by clang-tidy [modern-loop-convert] Signed-off-by: Matthias Maennich <matthias@maennich.net>
* Fix some occurrences of readability-avoid-const-params-in-declsMatthias Maennich2017-09-281-3/+3
| | | | | | Fix issues diagnosed by clang-tidy [readability-avoid-const-params-in-decls] Signed-off-by: Matthias Maennich <matthias@maennich.net>
* Fix some occurrences using string by value rather than by const&Matthias Maennich2017-09-281-1/+1
| | | | | | | | Fix issues diagnosed by clang-tidy - performance-unnecessary-value-param - performance-unnecessary-copy-initialization Signed-off-by: Matthias Maennich <matthias@maennich.net>
* Use C++11 nullptr (cont.)Matthias Maennich2017-09-191-4/+4
| | | | | | | Fix remaining occurrences of the issue addressed in commit 5962db4389 (Use C++11 nullptr, 2017-08-22) that are only showing up on macOS. Signed-off-by: Matthias Maennich <matthias@maennich.net>
* Access string npos without instancePavel Solodovnikov2017-06-011-2/+2
|
* iwyu: Fix OSX specific issuesDaniel Pfeifer2016-11-221-2/+3
|
* Simplify CMake per-source license noticesBrad King2016-09-271-11/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | Per-source copyright/license notice headers that spell out copyright holder names and years are hard to maintain and often out-of-date or plain wrong. Precise contributor information is already maintained automatically by the version control tool. Ultimately it is the receiver of a file who is responsible for determining its licensing status, and per-source notices are merely a convenience. Therefore it is simpler and more accurate for each source to have a generic notice of the license name and references to more detailed information on copyright holders and full license terms. Our `Copyright.txt` file now contains a list of Contributors whose names appeared source-level copyright notices. It also references version control history for more precise information. Therefore we no longer need to spell out the list of Contributors in each source file notice. Replace CMake per-source copyright/license notice headers with a short description of the license and links to `Copyright.txt` and online information available from "https://cmake.org/licensing". The online URL also handles cases of modules being copied out of our source into other projects, so we can drop our notices about replacing links with full license text. Run the `Utilities/Scripts/filter-notices.bash` script to perform the majority of the replacements mechanically. Manually fix up shebang lines and trailing newlines in a few files. Manually update the notices in a few files that the script does not handle.
* Xcode: Add function to conditionally add Xcode AttributesGregor Jasny2016-06-171-0/+16
|
* Revise C++ coding style using clang-formatKitware Robot2016-05-161-116/+93
| | | | | | | | | | | | | Run the `Utilities/Scripts/clang-format.bash` script to update all our C++ code to a new style defined by `.clang-format`. Use `clang-format` version 3.8. * If you reached this commit for a line in `git blame`, re-run the blame operation starting at the parent of this commit to see older history for the content. * See the parent commit for instructions to rebase a change across this style transition commit.
* Remove `//------...` horizontal separator commentsBrad King2016-05-091-9/+0
| | | | | | | | | | | | | | | | | | | | | | | | Modern editors provide plenty of ways to visually separate functions. Drop the explicit comments that previously served this purpose. Use the following command to automate the change: $ git ls-files -z -- \ "*.c" "*.cc" "*.cpp" "*.cxx" "*.h" "*.hh" "*.hpp" "*.hxx" | egrep -z -v "^Source/cmCommandArgumentLexer\." | egrep -z -v "^Source/cmCommandArgumentParser(\.y|\.cxx|Tokens\.h)" | egrep -z -v "^Source/cmDependsJavaLexer\." | egrep -z -v "^Source/cmDependsJavaParser(\.y|\.cxx|Tokens\.h)" | egrep -z -v "^Source/cmExprLexer\." | egrep -z -v "^Source/cmExprParser(\.y|\.cxx|Tokens\.h)" | egrep -z -v "^Source/cmFortranLexer\." | egrep -z -v "^Source/cmFortranParser(\.y|\.cxx|Tokens\.h)" | egrep -z -v "^Source/cmListFileLexer\." | egrep -z -v "^Source/cm_sha2" | egrep -z -v "^Source/(kwsys|CursesDialog/form)/" | egrep -z -v "^Utilities/(KW|cm).*/" | xargs -0 sed -i '/^\(\/\/---*\|\/\*---*\*\/\)$/ {d;}' This avoids modifying third-party sources and generated sources.
* Help clang-format wrap after braces on long initializer listsBrad King2016-05-061-0/+1
| | | | | | Add a long comment inside a few braced initializer lists in order to convince clang-format to break after the opening brace and format the list without indenting every value past the opening brace.
* Source: Stabilize include orderBrad King2016-04-291-0/+1
| | | | | Each source file has a logical first include file. Include it in an isolated block so that tools that sort includes do not move them.
* Xcode: Refactor block writes to allow any level of nestingRobert Goulet2016-02-241-63/+63
| | | | Reviewed-by: Gregor Jasny <gjasny@googlemail.com>
* Xcode: Escape all backslashes in strings (#15328)Gregor Jasny2016-01-071-2/+2
| | | | | | | | | | Before this change backslashes in strings were escaped during compile flags adds via AppendFlag(). But global flags like OTHER_CPLUSPLUSFLAGS are not added as flags but as plain strings so they were not escaped properly. Now the escaping is performed within cmXCodeObject::PrintString() which ensures that strings are always encoded.
* Xcode: Invert quoting logic to whitelist of charactersGregor Jasny2015-08-051-1/+5
| | | | | | | Our explicit list of characters that require quoting does not account for non-ascii characters (e.g. UTF-8) that also need quoting. Invert the logic to quote a string unless it contains exclusively a set of characters we whitelist.
* Xcode: Quote strings containing a tilde (#15672)Gregor Jasny2015-07-311-1/+1
| | | | | | | | | Since commit v3.3.0-rc1~183^2 (Xcode: Refine quoting rules for Strings, 2015-04-09) we no longer quote strings containing a period ('.'). However, file names like "icon29x29~ipad.png" still need quoting because they contain a tilde ('~'). Add tilde to our explicit list of characters that need quoting because such file names will no longer happen to be quoted because they contain a period.
* Xcode: Refine quoting rules for StringsGregor Jasny2015-04-171-1/+1
| | | | | $ and . do not need to be quoted, but brackets and * must be to not confuse the Xcode parser.
* Xcode: Let PrintComment decide if the comment is non-emptyGregor Jasny2015-04-171-4/+1
|
* Xcode: PrintComment will prepend a whitespace itself before the commentGregor Jasny2015-04-171-3/+2
|
* Xcode: Do not add whitespace after attribute group opening braceGregor Jasny2015-04-171-1/+5
| | | | | | This suppresses the extra space that would be generated if the separator is a space. The conditional block is also used in this form elsewhere.
* Xcode: Properly indent PBXFileReference and PBXBuildFileGregor Jasny2015-04-171-1/+1
| | | | Move indent factor change behind indention of start-of-line.
* Xcode: Indent using tabsGregor Jasny2015-04-171-1/+1
|
* Xcode: Also quote strings containing // (#15487)Gregor Jasny2015-04-041-0/+1
| | | | | | Otherwise those will be interpreted as start of a comment Signed-off-by: Gregor Jasny <gjasny@googlemail.com>
* strings: Remove cmStdString referencesBen Boeckel2014-03-081-3/+3
| | | | | | | | | | | Casts from std::string -> cmStdString were high on the list of things taking up time. Avoid such implicit casts across function calls by just using std::string everywhere. The comment that the symbol name is too long is no longer relevant since modern debuggers alias the templates anyways and the size is a non-issue since the underlying methods are generated since it's inherited.
* stringapi: Use strings for AddString methodsBen Boeckel2014-03-081-1/+1
| | | | It gets turned into a string anyways, so pass them in.
* Xcode: Each target dependency edge needs a unique object (#13935)Brad King2013-02-191-1/+0
| | | | | | | | | | | | | Generate a unique PBXTargetDependency and PBXContainerItemProxy for every edge in the dependency graph as required by the Xcode format. Xcode only accidentally loads project files that re-use the same PBXTargetDependency for every edge leading to a single target. If one is removed by hand in the IDE then Xcode may crash due to dangling references from the others. Since cmGlobalXCodeGenerator::AddDependTarget is called exactly once for every edge in the target dependency graph we do not need to keep track of which edges have been visited to avoid generating duplicates.
* Remove trailing whitespace from most CMake and C/C++ codeKitware Robot2012-08-131-12/+12
| | | | | | | | | | | | | | | | | Our Git commit hooks disallow modification or addition of lines with trailing whitespace. Wipe out all remnants of trailing whitespace everywhere except third-party code. Run the following shell code: git ls-files -z -- \ bootstrap doxygen.config '*.readme' \ '*.c' '*.cmake' '*.cpp' '*.cxx' \ '*.el' '*.f' '*.f90' '*.h' '*.in' '*.in.l' '*.java' \ '*.mm' '*.pike' '*.py' '*.txt' '*.vim' | egrep -z -v '^(Utilities/cm|Source/(kwsys|CursesDialog/form)/)' | egrep -z -v '^(Modules/CPack\..*\.in)' | xargs -0 sed -i 's/ \+$//'
* Xcode: Save object id values in CMakeCache.txt (#11690)David Cole2011-08-241-19/+21
| | | | | | | | | For project and target objects, save their ids in CMakeCache.txt. Hopefully, that will be enough to allow user settings to be saved across multiple CMake generate operations. Other object types may also need their ids saved: if so, more code than this commit will be necessary...
* Xcode: Quote ',' in Xcode string values (#12259)Johan Björk2011-08-041-1/+1
|
* XCode: Also qoute [] as needed to set build-configurations.Johan Björk2011-04-071-10/+20
|
* Xcode: Quote string values containing '$' (#11244)Mikkel Krautz2010-09-201-1/+1
| | | | | Allow use of $(STANDARD_32BIT_ARCHS) as CMAKE_OSX_ARCHITECTURES. The expanded value must remain a single string.
* Convert CMake to OSI-approved BSD LicenseBrad King2009-09-281-14/+9
| | | | | | | This converts the CMake license to a pure 3-clause OSI-approved BSD License. We drop the previous license clause requiring modified versions to be plainly marked. We also update the CMake copyright to cover the full development time range.
* ENH: Simplify string attributes in Xcode generatorBrad King2008-09-021-25/+33
| | | | | | | This change cleans up the implementation of cmXCodeObject to avoid un-escaping and re-escaping string values. There is no need to store the string in escaped form. It can be escaped once when it is printed out to the generated project file.
* ENH: fix for 64 bit cmake on macBill Hoffman2008-05-091-0/+4
|
* ENH: Improvements to the Xcode generator. Build frameworks using native Copy ↵David Cole2007-08-141-3/+31
| | | | Headers and Copy Bundle Resources phases. Fix bugs: eliminate folders with no names, ensure source files show up in multiple targets, remove empty utility targets from Sources subtrees, ensure that fileRefs only show up once in each grouping folder.
* STYLE: fix some kwstyle errorsBill Hoffman2007-07-271-0/+16
|
* ENH: @ must be escaped in xcode projectsBill Hoffman2007-05-271-1/+1
|
* BUG: fix for quotes in strings for flags #4022Bill Hoffman2007-02-211-1/+3
|
* STYLE: fix line lengthKen Martin2006-05-121-3/+6
|
* ENH: Add copy stages for bundle filesAndy Cedilnik2006-03-291-0/+1
|
* BUG: some UNIX fixes for my m_ commitKen Martin2006-03-151-22/+22
|
* STYLE: some m_ to this-> cleanupKen Martin2006-03-151-44/+44
|
* STYLE: fix line lengthsBill Hoffman2006-03-101-2/+4
|
* ENH: more chars need quotesBill Hoffman2005-11-181-1/+1
|
* ENH: fixes for xcode21 and build styles and comments in the generated projectBill Hoffman2005-11-161-20/+74
|
* ENH: add real support for Xcode21Bill Hoffman2005-09-021-2/+4
|
* ENH: fix bug in target linkingBill Hoffman2005-02-071-5/+23
|
* ENH: this version can build cmakeBill Hoffman2005-02-041-1/+4
|