summaryrefslogtreecommitdiffstats
path: root/Source
Commit message (Collapse)AuthorAgeFilesLines
* Merge branch 'backport-find-no-name' into find-no-nameBrad King2019-08-281-1/+1
|\
| * find_path: Fix crash on empty old-style list of namesBrad King2019-08-281-1/+1
| | | | | | | | Fixes: #19651
* | CMake Nightly Date StampKitware Robot2019-08-281-1/+1
| |
* | Merge topic 'cmake-initial-cache-dirs'Brad King2019-08-271-10/+7
|\ \ | | | | | | | | | | | | | | | | | | 4ca0526f8a cmake: Pass -S and -B into PreLoad.cmake and -C scripts Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !3709
| * | cmake: Pass -S and -B into PreLoad.cmake and -C scriptsPeter Waller2019-08-271-10/+7
| | | | | | | | | | | | | | | | | | | | | Before this, it was not possible to see what the source or build directories were set to on the command line. Fixes: #19619
* | | Merge topic 'swift-version'Brad King2019-08-272-0/+12
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | 369c48ee43 Swift: honour `-swift-version` in Ninja generator Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !3685
| * | | Swift: honour `-swift-version` in Ninja generatorSaleem Abdulrasool2019-08-262-0/+12
| | | | | | | | | | | | | | | | | | | | | | | | Swift has supported `CMAKE_Swift_LANGUAGE_VERSION` and `Swift_LANGUAGE_VERSION` but didn't apply that to Ninja generated targets. Consider the property when calculating the flags.
* | | | Merge topic 'ctest-CLICOLOR_FORCE'Brad King2019-08-271-0/+5
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 074a6a8cf6 CTest: Add env var CLICOLOR_FORCE to force color output Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !3733
| * | | | CTest: Add env var CLICOLOR_FORCE to force color outputMarin Baron2019-08-261-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | Base impl on `Source/kwsys/Terminal.c:kwsysTerminalStreamIsVT100`. This enables pipes/logs with colors.
* | | | | Merge topic 'alpine-cpu_zero'Brad King2019-08-271-0/+2
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1902e39746 cmAffinity: Add include for CPU_ZERO on Alpine Linux Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !3740
| * | | | | cmAffinity: Add include for CPU_ZERO on Alpine LinuxBrad King2019-08-271-0/+2
| | |_|_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The definition of `CPU_ZERO` requires `<string.h>` to be included explicitly for `memset`. Since IWYU does not agree on other Linux platforms, use a pragma to silence the warning. Fixes: #19643
* | | | | Merge topic 'cmGlobalGenerator-compilerId-lifetime'Brad King2019-08-271-7/+4
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 17ce0c29ad cmGlobalGenerator: Fix CheckCompilerIdCompatibility local var lifetime Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !3741
| * | | | | cmGlobalGenerator: Fix CheckCompilerIdCompatibility local var lifetimeBrad King2019-08-261-7/+4
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | Save the value of the compiler id variable in storage we own so that mutating it based on a policy does not invalidate the local value for later comparisons. This was identified by Clang AddressSanitizer.
* | | | | Merge topic 'ninja_additional_clean_files_custom_target'Brad King2019-08-272-0/+4
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | d040f3f1ee Tests: Extend MakeClean test to test various target types 3ed8cffe73 Ninja: Add support for ADDITIONAL_CLEAN_FILES in custom targets Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !3739
| * | | | | Ninja: Add support for ADDITIONAL_CLEAN_FILES in custom targetsSebastian Holtermann2019-08-262-0/+4
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This enables the support for `ADDITIONAL_CLEAN_FILES` in custom targets using the ninja generator. Fixes: #19641
* | | | | CMake Nightly Date StampKitware Robot2019-08-271-1/+1
| | | | |
* | | | | Merge topic 'pvs-cleanup'Brad King2019-08-268-45/+27
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7fe3e874d5 cmCPackLog: Fix support for multiple log message tags 74f2c0ea56 cmCTestTestHandler: Remove extra layer of parentheses 7c2767ef3b cmCTestMultiProcessHandler: Explain testRun ownership in comments 303e813438 CTest: Simplify some boolean conditions 51565abe79 cmMessageCommand: Remove extra layer of parentheses b1cfaf7b91 cmVSSetupHelper: Remove unused SmartBSTR copy operations 3f4c4e7afe cmVSSetupHelper: Fix SmartBSTR copy operations a8ca5aea94 cmMakefileTargetGenerator: Check for null before using a pointer ... Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: Daniel Pfeifer <daniel@pfeifer-mail.de> Acked-by: Artalus <artalus-mail@yandex.ru> Merge-request: !3715
| * | | | | cmCPackLog: Fix support for multiple log message tagsBrad King2019-08-261-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix logic from commit bbf1c2d275 (ENH: More improvements and add logging, 2006-01-02, v2.4.0~712) to append to the accumulated tag string instead of overwriting it for each type of message. Issue: #19610
| * | | | | cmCTestTestHandler: Remove extra layer of parenthesesBrad King2019-08-261-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | A condition in `ComputeTestListForRerunFailed` contained an extra layer of parentheses. Remove them. The condition itself is correct because an empty list means "all tests" so we want to include the current test. Issue: #19610
| * | | | | cmCTestMultiProcessHandler: Explain testRun ownership in commentsBrad King2019-08-261-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The ownership semantics of the 'testRun' variable are subtle and may fool static analysers. Add comments explaining them for now. Later some refactoring could be done to clarify the code. Issue: #19610
| * | | | | CTest: Simplify some boolean conditionsBrad King2019-08-262-4/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Directly compare two boolean values instead of spelling out accepted combinations. Issue: #19610
| * | | | | cmMessageCommand: Remove extra layer of parenthesesBrad King2019-08-261-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The logic checking `CMAKE_WARN_DEPRECATED` contained an unnecessary layer of parentheses. The condition is of the form `!IsSet || IsOn` which is correct because the documentation says that the behavior is enabled unless the variable is explicitly set to a false value. Issue: #19610
| * | | | | cmVSSetupHelper: Remove unused SmartBSTR copy operationsBrad King2019-08-261-22/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | For our use case we do not actually need to copy these. Mark the operations as `= delete` to simplify the code.
| * | | | | cmVSSetupHelper: Fix SmartBSTR copy operationsBrad King2019-08-261-2/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix the SmartBSTR copy constructor and copy assignment operator added by commit 18c8278b62 (VS: Add helper class to interact with Visual Studio Installer, 2016-12-14, v3.8.0-rc1~93^2~4) to use the string from the source of the copy. Issue: #19610
| * | | | | cmMakefileTargetGenerator: Check for null before using a pointerBrad King2019-08-261-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix the order of logic added by commit 7740ccd1a4 (ENH: some cleanup of the makefile generator, 2006-02-14, v2.4.0~517) to check for allocation failure ('new' returns null) before using the pointer. Issue: #19610
| * | | | | cmGlobalVisualStudioGenerator: Fix buffer sizes used with RegEnumKeyExWBrad King2019-08-221-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In commit 0b9906c2fb (Windows: Use wide-character system APIs, 2013-12-04, v3.0.0-rc1~254^2) several buffer size computations had to be updated to multiply by `sizeof(wchar_t)`, but for RegEnumKeyExW we were already computing the correct number of characters with a division which was accidentally converted to a multiplication. Use `cm::size` to compute the number of characters in the buffer instead. Issue: #19610
| * | | | | cmGlobalVisualStudioGenerator: Fix buffer sizes used RegQueryValueExWBrad King2019-08-221-5/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In commit 0b9906c2fb (Windows: Use wide-character system APIs, 2013-12-04, v3.0.0-rc1~254^2) several buffer size computations had to be updated to multiply by `sizeof(wchar_t)`, but some for RegQueryValueExW were incorrect because the number of bytes was already computed. Issue: #19610
* | | | | | Merge topic 'source_sweep_ostringstream_single'Brad King2019-08-2624-153/+92
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3b2b02825d Source sweep: Replace std::ostringstream when used with a single append Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !3726
| * | | | | | Source sweep: Replace std::ostringstream when used with a single appendSebastian Holtermann2019-08-2324-153/+92
| | |_|_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This replaces `std::ostringstream`, when it is written to only once. If the single written argument was numeric, `std::to_string` is used instead. Otherwise, the single written argument is used directly instead of the `std::ostringstream::str()` invocation.
* | | | | | Merge topic 'source_sweep_cmExpandedList'Brad King2019-08-2662-318/+186
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | aaf59120bf Source sweep: Replace cmExpandList with the shorter cmExpandedList Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !3725
| * | | | | | Source sweep: Replace cmExpandList with the shorter cmExpandedListSebastian Holtermann2019-08-2362-318/+186
| |/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This replaces the code pattern ``` std::vector<std::string> args; cmExpandList(valueStr, args, ...) ``` with ``` std::vector<std::string> args = cmExpandedList(valueStr, ...) ```
* | | | | | Merge topic 'list-subcommand-table'Brad King2019-08-261-111/+43
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | b14bcd9123 cmListCommand: Use cmSubcommandTable Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !3723
| * | | | | | cmListCommand: Use cmSubcommandTableRegina Pfeifer2019-08-221-111/+43
| | |/ / / / | |/| | | |
* | | | | | Merge topic 'string-subcommand-table'Brad King2019-08-261-130/+65
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 66c2714f22 cmStringCommand: Use cmSubcommandTable Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !3721
| * | | | | | cmStringCommand: Use cmSubcommandTableRegina Pfeifer2019-08-221-130/+65
| |/ / / / /
* | | | | | Merge topic 'group_not_track'Brad King2019-08-265-34/+49
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2a71a0390c ctest: rename TRACK to GROUP Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: Zack Galbreath <zack.galbreath@kitware.com> Merge-request: !3707
| * | | | | | ctest: rename TRACK to GROUPZack Galbreath2019-08-225-34/+49
| | |_|_|_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Update command-line options, script variables, and documentation to use the term "group" instead of "track". The old terms are still available for now, but they are now undocumented. This makes our terminology more consistent with CDash. The goal of this change is to make it more clear to our users how CTest and CDash interact with each other.
* | | | | | Merge topic 'warnings_skip_color'Brad King2019-08-262-9/+22
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2079267959 ctest_build: ignore ANSI color Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !3702
| * | | | | | ctest_build: ignore ANSI colorZack Galbreath2019-08-222-9/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Ignore ANSI color when scraping logs for errors and warnings
* | | | | | | Merge topic 'optional'Brad King2019-08-263-1/+382
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 197c5e12ad Source: Add cm::optional 170fcd715f Extend C++17 feature checks to require std::optional Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: Sebastian Holtermann <sebholt@web.de> Merge-request: !3644
| * | | | | | | Source: Add cm::optionalKyle Edwards2019-08-232-0/+378
| | | | | | | |
| * | | | | | | Extend C++17 feature checks to require std::optionalBrad King2019-08-231-1/+4
| | |/ / / / / | |/| | | | |
* | | | | | | CMake Nightly Date StampKitware Robot2019-08-261-1/+1
| | | | | | |
* | | | | | | CMake Nightly Date StampKitware Robot2019-08-251-1/+1
| |_|_|_|_|/ |/| | | | |
* | | | | | CMake Nightly Date StampKitware Robot2019-08-241-1/+1
| |_|_|/ / |/| | | |
* | | | | Merge topic 'ctest-json-REQUIRED_FILES'Brad King2019-08-231-2/+2
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5778880d20 CTest: Fix --show-only=json-v1 output with REQUIRED_FILES property Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !3719
| * | | | | CTest: Fix --show-only=json-v1 output with REQUIRED_FILES propertyBrad King2019-08-221-2/+2
| | |_|_|/ | |/| | | | | | | | | | | | | Fixes: #19629
* | | | | Merge topic 'source_sweep_cmStrCat'Brad King2019-08-23175-2949/+1960
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 9b334397f5 Source sweep: Use cmStrCat for string concatenation Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: Rolf Eike Beer <eike@sf-mail.de> Acked-by: Daniel Pfeifer <daniel@pfeifer-mail.de> Merge-request: !3699
| * | | | | Source sweep: Use cmStrCat for string concatenationSebastian Holtermann2019-08-22175-2949/+1960
| | |_|_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch is generated by a python script that uses regular expressions to search for string concatenation patterns of the kind ``` std::string str = <ARG0>; str += <ARG1>; str += <ARG2>; ... ``` and replaces them with a single `cmStrCat` call ``` std::string str = cmStrCat(<ARG0>, <ARG1>, <ARG2>, ...); ``` If any `<ARGX>` is itself a concatenated string of the kind ``` a + b + c + ...; ``` then `<ARGX>` is split into multiple arguments for the `cmStrCat` call. If there's a sequence of literals in the `<ARGX>`, then all literals in the sequence are concatenated and merged into a single literal argument for the `cmStrCat` call. Single character strings are converted to single char arguments for the `cmStrCat` call. `std::to_string(...)` wrappings are removed from `cmStrCat` arguments, because it supports numeric types as well as string types. `arg.substr(x)` arguments to `cmStrCat` are replaced with `cm::string_view(arg).substr(x)`
* | | | | CMake Nightly Date StampKitware Robot2019-08-231-1/+1
|/ / / /