summaryrefslogtreecommitdiffstats
path: root/Source
Commit message (Collapse)AuthorAgeFilesLines
* Fix transitive usage requirements through same-name imported targetsBrad King2018-09-107-47/+45
| | | | | | | | | | If two imported targets in different directories have the same name we should still be able to propagate transitive usage requirements from both. Fix the DAG checker to work with target pointers instead of target names since the pointers will not be duplicated even if the names are. Fixes: #18345
* genex: Simplify cmGeneratorExpressionInterpreterBrad King2018-09-079-87/+36
| | | | | | | | | All callers were constructing with a non-empty target name using the target whose pointer was passed anyway. Drop this argument. Simplify logic accordingly. Re-order constructor arguments to match the cmCompiledGeneratorExpression::Evaluate arguments. Also remove unnecessary getters.
* Fix dependency propagation through same-name imported targetsBrad King2018-09-075-41/+44
| | | | | | | | | | If two imported targets in different directories have the same name we should still be able to propagate transitive link dependencies from both. Fix the target and link dependency analyzers to de-duplicate targets using target pointers rather than target names since the pointers will not be duplicated even if the names are. Issue: #18345
* cmLinkItem: Convert to a "sum type" over a string and target pointerBrad King2018-09-079-66/+144
| | | | | | | | | Avoid exposing the item name implicitly as std::string. When the item is a target, avoid storing a second copy of its name. Most link item construction is paired with calls to `FindTargetToLink` to get the possible target pointer. Rename these methods to `ResolveLinkItem` and refactor them to construct the entire item.
* Merge topic 'grd-stdstring'Brad King2018-09-0613-23/+21
|\ | | | | | | | | | | | | 4d89830d71 cmMakefile: Make GetRequiredDefinition return std::string Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !2347
| * cmMakefile: Make GetRequiredDefinition return std::stringVitaly Stakhovsky2018-09-0513-23/+21
| | | | | | | | | | | | | | In all cases the return value is converted to std::string anyway. Also remove unnecessary `c_str()` calls in arguments to `GetRequiredDefinition`.
* | Merge topic 'isonoff-cstr'Brad King2018-09-0624-43/+40
|\ \ | | | | | | | | | | | | | | | | | | 6f16be6a62 Remove unnecessary c_str() calls Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !2346
| * | Remove unnecessary c_str() callsVitaly Stakhovsky2018-09-0524-43/+40
| |/ | | | | | | Use the new IsOn(),IsOff() overloads.
* | CMake Nightly Date StampKitware Robot2018-09-061-1/+1
| |
* | Merge topic 'cmake-gui-align-text'Brad King2018-09-051-0/+3
|\ \ | | | | | | | | | | | | | | | | | | 13a2751ca6 cmake-gui: Align source and binary directory path text Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !2344
| * | cmake-gui: Align source and binary directory path textZeex2018-09-041-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | Text inputs for "where is the source code" and "where to build the binaries" had different amount of left spacing, so the two paths were not aligned. This could create a feeling that you typed something wrong in the input even though the paths were identical or had a common root path.
* | | Merge topic 'vs-CMakeLists.txt'Brad King2018-09-051-1/+5
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | 0b82e68f2f VS: Restore CMakeLists.txt references in each target Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !2349
| * | | VS: Restore CMakeLists.txt references in each targetBrad King2018-09-051-1/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The custom command de-duplication added by commit v3.12.0-rc1~171^2 (VS: Generate a custom command only in the least dependent target, 2018-03-23) accidentally also applied to the `CMakeLists.txt` file reference we put in each target. This file reference comes with a custom command that has no dependencies and that is safe to run repeatedly across multiple targets (via internal stamp checking). Therefore it should be excluded from the de-duplication so that `CMakeLists.txt` references appear in all targets for human reference. Fixes: #18310
* | | | CMake Nightly Date StampKitware Robot2018-09-051-1/+1
| |_|/ |/| |
* | | Merge topic 'cmakeServerSourcesForInterfaceLibraries'Brad King2018-09-042-40/+184
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | d74c2282ea cmake-server: Support codemodel filegroups for INTERFACE_SOURCES Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: Tobias Hunger <tobias.hunger@gmail.com> Acked-by: Markus Enzenberger <markus.enzenberger@gmail.com> Merge-request: !2282
| * | | cmake-server: Support codemodel filegroups for INTERFACE_SOURCESJustin Goshi2018-08-302-40/+184
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This change returns information for INTERFACE_SOURCES. We add a flag to the filegroup to indicate if the target represents interface sources. Protocol version is updated to 1.3 since this is a change to what was released in cmake version 3.12.
* | | | Merge topic 'improve-isonoff'Brad King2018-09-042-35/+68
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1bfe6991ff cmSystemTools: Re-implement IsOn,IsOff with manual branching 1fa0f2bd03 cmSystemTools: Add IsOn(),IsOff() overloads accepting std::string Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: vvs31415 <vstakhovsky@fastmail.com> Merge-request: !2336
| * | | | cmSystemTools: Re-implement IsOn,IsOff with manual branchingBrad King2018-08-311-35/+56
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Replace use of std::string allocation, std::set lookups, and toupper conversions with explicit manual logic to do case-insensitive recognition of a specific set of strings.
| * | | | cmSystemTools: Add IsOn(),IsOff() overloads accepting std::stringVitaly Stakhovsky2018-08-312-0/+12
| | | | |
* | | | | CMake Nightly Date StampKitware Robot2018-09-041-1/+1
| | | | |
* | | | | CMake Nightly Date StampKitware Robot2018-09-031-1/+1
| |_|_|/ |/| | |
* | | | CMake Nightly Date StampKitware Robot2018-09-021-1/+1
| | | |
* | | | CMake Nightly Date StampKitware Robot2018-09-011-1/+1
| | | |
* | | | Merge topic 'vs-winrt-default'Brad King2018-08-311-2/+4
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | e78a0c8e8a VS: Add option to tell generator that platfrom is WinRT by default Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !2315
| * | | | VS: Add option to tell generator that platfrom is WinRT by defaultMikhail Korolev2018-08-301-2/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Create a ``CMAKE_VS_WINRT_BY_DEFAULT`` variable to indicate this. Fixes: #18286
* | | | | Merge topic 'gg-stdstring'Brad King2018-08-313-16/+16
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4e94f6447a cmGlobalGenerator::AddInstallComponent(): Accept std::string argument Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !2332
| * | | | | cmGlobalGenerator::AddInstallComponent(): Accept std::string argumentVitaly Stakhovsky2018-08-303-16/+16
| | | | | |
* | | | | | Merge topic 'file-alt-httpauth'Brad King2018-08-311-0/+8
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 31301b46a7 file: Allow DOWNLOAD/UPLOAD using alternate authentication methods Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !2320
| * | | | | | file: Allow DOWNLOAD/UPLOAD using alternate authentication methodsClinton Stimpson2018-08-301-0/+8
| | |/ / / / | |/| | | |
* | | | | | Merge topic 'no-sanitizer-logfile'Brad King2018-08-311-2/+2
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5aaaee5e9e ctest_memcheck: Change failure to find log file from error to warning Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !2323
| * | | | | | ctest_memcheck: Change failure to find log file from error to warningBetsy McPhail2018-08-281-2/+2
| | |_|/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Sanitizers do not create a log file when no defects are found. Therefore, it is currently impossible for ctest_memcheck to set both `CAPTURE_CMAKE_ERROR` and `RETURN_VALUE` to zero. With defects, `CAPTURE_CMAKE_ERROR`=0 and `RETURN_VALUE`=-1, as expected. With no defects, `CAPTURE_CMAKE_ERROR`=-1 and `RETURN_VALUE`=0.
* | | | | | Merge topic 'ctest-WARNING-not-error'Brad King2018-08-311-0/+1
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | fde61d3ad3 CTest: Add error exception for sphinx-build WARNING messages Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !2325
| * | | | | | CTest: Add error exception for sphinx-build WARNING messagesTim2018-08-301-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Sphinx-build warnings look like this: ../path/to/file.rst:105: WARNING: This is not an error. CTest detects these as errors by this regex: ([^ :]+):([0-9]+): ([^ \\t]) Add an exception as we already have for lower-case `: warning`.
* | | | | | | CMake Nightly Date StampKitware Robot2018-08-311-1/+1
| |_|_|/ / / |/| | | | |
* | | | | | Merge topic 'minor-cleanup'Brad King2018-08-302-15/+12
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | fb73edf70c cmake: Drop unnecessary working mode checks bd7dd6d414 cmake: Declare VariableWatch member only when used Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !2326
| * | | | | | cmake: Drop unnecessary working mode checksBrad King2018-08-291-13/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In `cmake::Run` we return before `Configure` or `Generate` when not working in normal mode so they do not need mode checks. While at it, remove a long-outdated comment about when to save the cache.
| * | | | | | cmake: Declare VariableWatch member only when usedBrad King2018-08-291-2/+6
| | |/ / / / | |/| | | |
* | | | | | Merge topic 'cpack-ext-stage-and-run'Brad King2018-08-303-21/+52
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4a0f664aaf CPackExt: Add CPACK_EXT_ENABLE_STAGING and CPACK_EXT_PACKAGE_SCRIPT Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !2272
| * | | | | | CPackExt: Add CPACK_EXT_ENABLE_STAGING and CPACK_EXT_PACKAGE_SCRIPTNils Gladitz2018-08-143-21/+52
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | CPACK_EXT_ENABLE_STAGING enables optional staging and CPACK_EXT_PACKAGE_SCRIPT allows to specify an optional script file that can package staged files via an external packaging tool. Issue: #18236
* | | | | | | Merge topic 'cstr-remove'Brad King2018-08-301-8/+8
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 95084a313d cmVisualStudio10TargetGenerator: clean up c_str()s Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !2322
| * | | | | | | cmVisualStudio10TargetGenerator: clean up c_str()sVitaly Stakhovsky2018-08-281-8/+8
| | |/ / / / / | |/| | | | |
* | | | | | | Merge topic 'genex-evaluate-stdstring'Brad King2018-08-305-23/+18
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 65ab9ce938 Genex: Return Evaluate results as const std::string& Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !2314
| * | | | | | | Genex: Return Evaluate results as const std::string&Vitaly Stakhovsky2018-08-285-23/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Also remove unused overloads.
* | | | | | | | CMake Nightly Date StampKitware Robot2018-08-301-1/+1
| |_|_|/ / / / |/| | | | | |
* | | | | | | CMake Nightly Date StampKitware Robot2018-08-291-1/+1
| |/ / / / / |/| | | | |
* | | | | | Merge topic 'lg-directory'Brad King2018-08-2811-22/+21
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 50fbfee3a0 cmLocalGenerator: return directories as const std::string& Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !2309
| * | | | | | cmLocalGenerator: return directories as const std::string&Vitaly Stakhovsky2018-08-2711-22/+21
| | | | | | |
* | | | | | | Merge topic 'mk-directory'Brad King2018-08-2821-67/+65
|\ \ \ \ \ \ \ | |_|_|_|/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | c8fd23ec6f cmMakefile: return directories as const std::string& Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !2311
| * | | | | | cmMakefile: return directories as const std::string&Vitaly Stakhovsky2018-08-2721-67/+65
| | | | | | |
* | | | | | | CMake Nightly Date StampKitware Robot2018-08-281-1/+1
| | | | | | |