summaryrefslogtreecommitdiffstats
path: root/Source
Commit message (Collapse)AuthorAgeFilesLines
* cmCTestMultiProcessHandler: Explain testRun ownership in commentsBrad King2019-08-261-0/+3
| | | | | | | | The ownership semantics of the 'testRun' variable are subtle and may fool static analysers. Add comments explaining them for now. Later some refactoring could be done to clarify the code. Issue: #19610
* CTest: Simplify some boolean conditionsBrad King2019-08-262-4/+2
| | | | | | | Directly compare two boolean values instead of spelling out accepted combinations. Issue: #19610
* cmMessageCommand: Remove extra layer of parenthesesBrad King2019-08-261-2/+2
| | | | | | | | | The logic checking `CMAKE_WARN_DEPRECATED` contained an unnecessary layer of parentheses. The condition is of the form `!IsSet || IsOn` which is correct because the documentation says that the behavior is enabled unless the variable is explicitly set to a false value. Issue: #19610
* cmVSSetupHelper: Remove unused SmartBSTR copy operationsBrad King2019-08-261-22/+2
| | | | | For our use case we do not actually need to copy these. Mark the operations as `= delete` to simplify the code.
* cmVSSetupHelper: Fix SmartBSTR copy operationsBrad King2019-08-261-2/+4
| | | | | | | | | Fix the SmartBSTR copy constructor and copy assignment operator added by commit 18c8278b62 (VS: Add helper class to interact with Visual Studio Installer, 2016-12-14, v3.8.0-rc1~93^2~4) to use the string from the source of the copy. Issue: #19610
* cmMakefileTargetGenerator: Check for null before using a pointerBrad King2019-08-261-4/+4
| | | | | | | | Fix the order of logic added by commit 7740ccd1a4 (ENH: some cleanup of the makefile generator, 2006-02-14, v2.4.0~517) to check for allocation failure ('new' returns null) before using the pointer. Issue: #19610
* cmGlobalVisualStudioGenerator: Fix buffer sizes used with RegEnumKeyExWBrad King2019-08-221-4/+4
| | | | | | | | | | | In commit 0b9906c2fb (Windows: Use wide-character system APIs, 2013-12-04, v3.0.0-rc1~254^2) several buffer size computations had to be updated to multiply by `sizeof(wchar_t)`, but for RegEnumKeyExW we were already computing the correct number of characters with a division which was accidentally converted to a multiplication. Use `cm::size` to compute the number of characters in the buffer instead. Issue: #19610
* cmGlobalVisualStudioGenerator: Fix buffer sizes used RegQueryValueExWBrad King2019-08-221-5/+4
| | | | | | | | | In commit 0b9906c2fb (Windows: Use wide-character system APIs, 2013-12-04, v3.0.0-rc1~254^2) several buffer size computations had to be updated to multiply by `sizeof(wchar_t)`, but some for RegQueryValueExW were incorrect because the number of bytes was already computed. Issue: #19610
* Merge topic 'cmCommand_refactor'Brad King2019-08-2270-2042/+1568
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6ab28b9413 cmCommand refactor: cmStringCommand 36f32d3604 cmCommand refactor: cmSetPropertyCommand 7c83c19205 cmCommand refactor: cmSetDirectoryPropertiesCommand 9413952c42 cmCommand refactor: cmCMakePolicyCommand 07ea93de54 cmCommand refactor: cmWriteFileCommand ca3b9186bb cmCommand refactor: cmVariableWatchCommand b1acc711f4 cmCommand refactor: cmRemoveCommand 413a960391 cmCommand refactor: cmCMakeHostSystemInformationCommand ... Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !3673
| * cmCommand refactor: cmStringCommandGabor Bencze2019-08-203-221/+241
| |
| * cmCommand refactor: cmSetPropertyCommandGabor Bencze2019-08-203-198/+256
| |
| * cmCommand refactor: cmSetDirectoryPropertiesCommandGabor Bencze2019-08-203-40/+21
| |
| * cmCommand refactor: cmCMakePolicyCommandGabor Bencze2019-08-204-77/+66
| |
| * cmCommand refactor: cmWriteFileCommandGabor Bencze2019-08-203-33/+11
| |
| * cmCommand refactor: cmVariableWatchCommandGabor Bencze2019-08-203-31/+12
| |
| * cmCommand refactor: cmRemoveCommandGabor Bencze2019-08-203-30/+9
| |
| * cmCommand refactor: cmCMakeHostSystemInformationCommandGabor Bencze2019-08-203-82/+57
| |
| * cmCommand refactor: cmUnsetCommandGabor Bencze2019-08-203-33/+12
| |
| * cmCommand refactor: cmSiteNameCommandGabor Bencze2019-08-203-32/+11
| |
| * cmCommand refactor: cmSetCommandGabor Bencze2019-08-203-39/+18
| |
| * cmCommand refactor: cmSeparateArgumentsCommandGabor Bencze2019-08-203-34/+12
| |
| * cmCommand refactor: cmParseArgumentsCommandGabor Bencze2019-08-203-47/+24
| |
| * cmCommand refactor: cmOptionCommandGabor Bencze2019-08-203-38/+17
| |
| * cmCommand refactor: CmMessageCommandGabor Bencze2019-08-203-40/+20
| |
| * cmCommand refactor: cmMathCommandGabor Bencze2019-08-203-41/+25
| |
| * cmCommand refactor: cmMarkAsAdvancedCommandGabor Bencze2019-08-203-32/+10
| |
| * cmCommand refactor: cmMakeDirectoryCommandGabor Bencze2019-08-203-32/+10
| |
| * cmCommand refactor: cmListCommandGabor Bencze2019-08-203-224/+244
| |
| * cmCommand refactor: cmMacroCommandGabor Bencze2019-08-203-27/+10
| |
| * cmCommand refactor: cmIncludeGuardCommandGabor Bencze2019-08-203-31/+10
| |
| * cmCommand refactor: cmIncludeCommandGabor Bencze2019-08-203-48/+29
| |
| * cmCommand_refactor: cmGetPropertyCommandGabor Bencze2019-08-203-162/+187
| |
| * cmCommand refactor: cmGetFilenameComponentCommandGabor Bencze2019-08-203-37/+16
| |
| * cmCommand refactor: cmGetDirectoryPropertyCommandGabor Bencze2019-08-203-42/+29
| |
| * cmCommand refactor: cmGetCMakePropertyCommandGabor Bencze2019-08-203-31/+12
| |
| * cmCommand refactor: cmFunctionCommandGabor Bencze2019-08-203-27/+10
| |
| * cmCommand refactor: cmForEachCommandGabor Bencze2019-08-203-39/+21
| |
| * cmCommand refactor: cmExecuteProcessCommandGabor Bencze2019-08-203-61/+46
| |
| * cmCommand refactor: cmExecProgramCommandGabor Bencze2019-08-203-47/+25
| |
| * cmCommand refactor: cmContinueCommandGabor Bencze2019-08-203-33/+15
| |
| * cmCommand refactor: cmConfigureFileCommandGabor Bencze2019-08-203-73/+37
| |
| * cmCommand refactor: cmCMakeMinimumRequiredGabor Bencze2019-08-203-49/+34
| |
| * cmCommand refactor: cmBreakCommandGabor Bencze2019-08-203-31/+11
| |
* | Merge topic 'isolate-declarations'Brad King2019-08-2225-48/+102
|\ \ | | | | | | | | | | | | | | | | | | d331021255 clang-tidy: isolate declarations for readability Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !3704
| * | clang-tidy: isolate declarations for readabilityRegina Pfeifer2019-08-2025-48/+102
| |/
* | CMake Nightly Date StampKitware Robot2019-08-221-1/+1
| |
* | Merge topic 'double-export-error-message-install'Brad King2019-08-214-18/+33
|\ \ | | | | | | | | | | | | | | | | | | | | | d17580909f cmExportInstallFileGenerator: improve error message a18100898a cmInstallExportGenerator: add a method for the file destination Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !3703
| * | cmExportInstallFileGenerator: improve error messageBen Boeckel2019-08-202-18/+27
| | | | | | | | | | | | | | | | | | | | | Following commit 49cfd390 (cmExportBuildFileGenerator: improve error message, 2019-06-26), improve the error message related to installed export sets by referencing the files which contain the exported target ambiguously.
| * | cmInstallExportGenerator: add a method for the file destinationBen Boeckel2019-08-192-0/+6
| | | | | | | | | | | | | | | This will be used in the error message which remarks about a target being exported ambiguously into different installations.
* | | Merge topic 'shared-string'Brad King2019-08-215-28/+33
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | be7807478c cmDefinitions: Reduce allocation of keys and values in MakeClosure e07e2bc8bb bootstrap: Compile cm::String c1787cb5eb cpack.cxx: Re-order include blocks to follow our conventions 141e307484 cmConfigure.h: Tell windows.h not to define min/max macros Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !3669
generated by cgit v0.12 at 2025-01-08 03:05:19 (GMT)