summaryrefslogtreecommitdiffstats
path: root/Source
Commit message (Collapse)AuthorAgeFilesLines
* Merge topic 'filesystem-path-c++03-abi' into release-3.25Brad King2022-10-212-3/+12
|\ | | | | | | | | | | | | | | ee9805ccd1 cm/filesystem: Fix crash with pre-C++11 std::string GNU ABI in C++17 Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: buildbot <buildbot@kitware.com> Merge-request: !7813
| * cm/filesystem: Fix crash with pre-C++11 std::string GNU ABI in C++17Brad King2022-10-202-3/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The `remove_filename` and `replace_extension` methods compute an offset between the whole path in a `std::string` and a part of a path in a `std::string_view`. This is done by subtracting their `.data()` pointers. However, C++17 adds a non-const `.data()` through which modification of the string is allowed. This means the copy-on-write implementation used by the pre-C++11 std::string GNU ABI must reallocate if the string has been copied. Our subtraction then computes an offset between two different allocations, which is undefined behavior. The workaround in commit b3ca4f9ad1 (cm/filesystem: Work around crash when compiled for CYGWIN/MSYS runtime, 2021-04-22, v3.21.0-rc1~271^2~2) avoided the problem by calling the non-const `.data()` to reallocate before constructing the `string_view`. Instead, explicitly call the const `.data()` method on the string, which does not reallocate. Fixes: #22090, #23328
* | CMake 3.25.0-rc2v3.25.0-rc2Brad King2022-10-191-1/+1
| |
* | Merge topic 'cmake-presets-output-junit' into release-3.25Brad King2022-10-196-5/+30
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | bea4ed5430 CTest: Add support for outputJUnitFile in presets 9270a02003 CMakePresets.json: Add outputJUnitFile to test presets schema 757786bb73 Tests: Add test for outputLogFile in CMakePresets.json b68c3596e7 CMakePresets.json: Disallow extra properties in test output schema Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: scivision <michael@scivision.dev> Merge-request: !7806
| * | CTest: Add support for outputJUnitFile in presetsKyle Edwards2022-10-182-5/+16
| | | | | | | | | | | | Fixes: #22400
| * | CMakePresets.json: Add outputJUnitFile to test presets schemaKyle Edwards2022-10-184-0/+14
| | |
* | | Merge topic 'mingw-unc' into release-3.25Brad King2022-10-191-0/+7
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 9777e4c30e MinGW Makefiles: Quote UNC paths on command lines Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: buildbot <buildbot@kitware.com> Merge-request: !7802
| * | | MinGW Makefiles: Quote UNC paths on command linesEd Hartley2022-10-181-0/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | UNC paths (starting with `\\`) need quotes when generating MinGW Makefiles to avoid gmake interpreting the first `\` as an escape character. Fixes: #24061
* | | | Merge topic 'try_compile-CMP0128' into release-3.25Brad King2022-10-191-0/+6
|\ \ \ \ | |/ / / |/| | / | | |/ | |/| | | | | | | | | | 50e90e2828 try_compile: Honor CMP0128 setting in test project Acked-by: Kitware Robot <kwrobot@kitware.com> Reviewed-by: Raul Tambre <raul@tambre.ee> Merge-request: !7803
| * | try_compile: Honor CMP0128 setting in test projectBrad King2022-10-181-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | Some projects pass a raw `-std=` flag to the compiler in the `try_compile` project. If they do not set CMP0128 to NEW, we should not append a `-std=` flag where we did not before the policy was added. Fixes: #24063
| * | CMake 3.23.4v3.23.4Brad King2022-10-041-1/+1
| | |
* | | Merge topic 'revert_nvcc_marking_include_as_system' into release-3.25Brad King2022-10-181-9/+0
|\ \ \ | |_|/ |/| | | | | | | | | | | | | | d0e52219eb CUDA: Revert "Always mark cuda toolkit as system include" Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !7798
| * | CUDA: Revert "Always mark cuda toolkit as system include"Robert Maynard2022-10-171-9/+0
| | | | | | | | | | | | | | | | | | | | | | | | We need to revert this change as it can disable error messages when compiling invalid CUDA code. This reverts commit ea659b155d (CUDA: Always mark cuda toolkit as system include, 2022-06-27, v3.25.0-rc1~269^2).
* | | Xcode: ensure framework with custom output directory can be consumedMarc Chevrier2022-10-141-5/+13
|/ / | | | | | | Fixes: #24046
* | CMake 3.25.0-rc1v3.25.0-rc1Brad King2022-10-121-1/+1
| |
* | Begin 3.25 release versioningBrad King2022-10-111-3/+3
| |
* | CMake Nightly Date StampKitware Robot2022-10-111-1/+1
| |
* | Merge topic 'verify-header-sets-iwyu'Brad King2022-10-101-1/+5
|\ \ | | | | | | | | | | | | | | | | | | | | | 6942234bf5 VERIFY_INTERFACE_HEADER_SETS: Add IWYU pragma: associated to verification file Acked-by: Kitware Robot <kwrobot@kitware.com> Tested-by: buildbot <buildbot@kitware.com> Merge-request: !7762
| * | VERIFY_INTERFACE_HEADER_SETS: Add IWYU pragma: associated to verification fileDaniel Hannon2022-10-071-1/+5
| | |
* | | Merge topic 'cuda_sanitizer_false_positives'Brad King2022-10-101-4/+17
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 59fcbba65e ctest_memcheck: ignore false-positives in CUDA's compute-sanitizer Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: buildbot <buildbot@kitware.com> Merge-request: !7760
| * | | ctest_memcheck: ignore false-positives in CUDA's compute-sanitizerTobias Ribizel2022-10-071-4/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Add a list of false-positive messages from CUDA's compute-sanitizer to the CTest memcheck. Fixes: #24001
* | | | Merge topic 'Intel-Fortran-warn-errors'Brad King2022-10-101-3/+7
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 13f3382b1c Intel/IntelLLVM: Fortran has distinct "-Werror"-like flag ab8a0a106e COMPILE_WARNING_AS_ERROR: Fix internal formatting of options table Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: buildbot <buildbot@kitware.com> Merge-request: !7758
| * | | | COMPILE_WARNING_AS_ERROR: Fix internal formatting of options tableBrad King2022-10-071-3/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In commit 76a08cd253 (COMPILE_WARNING_AS_ERROR: Add options to treat warnings as errors, 2022-04-21, v3.24.0-rc1~173^2) we formatted the options table entries as command-line string fragments. Since they are part of the `CMAKE_${lang}_COMPILE_OPTIONS_*` tables, they should be formatted as `;`-separated lists of compiler options.
* | | | | CMake Nightly Date StampKitware Robot2022-10-101-1/+1
| | | | |
* | | | | CMake Nightly Date StampKitware Robot2022-10-091-1/+1
| | | | |
* | | | | CMake Nightly Date StampKitware Robot2022-10-081-1/+1
| |_|/ / |/| | |
* | | | Merge topic 'clang-tidy-prefer-p-option'Brad King2022-10-071-7/+19
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3f4e0839c4 clang-tidy: Don't append compiler commands if using -p Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !7753
| * | | | clang-tidy: Don't append compiler commands if using -pCraig Scott2022-10-071-7/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When the -p option is given to clang-tidy, it doesn't need the compile command line to be appended. It can get everything it needs from the compile_commands.json file in the directory specified with the -p option. When the compiler being used is not the system default compiler, clang-tidy has been observed to pick up the wrong headers when the compiler command line is given, but not if only the -p option is used. Therefore, don't append the compiler command line if -p is present in the <LANG>_CLANG_TIDY target property. Fixes: #24017
* | | | | Merge topic 'improve-symlink-error-reporting'Brad King2022-10-075-42/+82
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 569fb1893e file(INSTALL): Report "Installing:" for a symlink to a directory 1461ae4933 file(INSTALL): Clarify symlink vs dir conflict errors 85f01a1ec2 file(INSTALL): Improve formatting of symlink creation error aba48bd6ac cmSystemTools: Provide quiet link creation methods Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: buildbot <buildbot@kitware.com> Merge-request: !7706
| * | | | | file(INSTALL): Report "Installing:" for a symlink to a directoryJohn Parent2022-10-061-1/+4
| | | | | |
| * | | | | file(INSTALL): Clarify symlink vs dir conflict errorsJohn Parent2022-10-061-1/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Clarify error reporting in scenario creating a symlink where a directory previously exists.
| * | | | | file(INSTALL): Improve formatting of symlink creation errorBrad King2022-10-061-11/+13
| | | | | | | | | | | | | | | | | | | | | | | | Avoid printing two error messages. Format paths without wrapping.
| * | | | | cmSystemTools: Provide quiet link creation methodsBrad King2022-10-064-30/+50
| | |_|/ / | |/| | | | | | | | | | | | | Offer variants that let the caller handle error messages.
* | | | | Merge topic 'automoc-skip-pch'Brad King2022-10-072-2/+22
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 681714ce20 AUTOMOC: Skip PCH when all sources files skip the PCH file too Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: buildbot <buildbot@kitware.com> Merge-request: !7759
| * | | | | AUTOMOC: Skip PCH when all sources files skip the PCH file tooCristian Adam2022-10-062-2/+22
| |/ / / / | | | | | | | | | | | | | | | Fixes: #23464
* | | | | CMake Nightly Date StampKitware Robot2022-10-071-1/+1
|/ / / /
* | | | Merge topic 'try_compile-more-debug-logging'Brad King2022-10-061-0/+7
|\ \ \ \ | |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | 7e6b2a92a0 try_compile: Report build dir with --debug-trycompile cbf3252975 Tests: Remove stray debugging flag from RunCMake.CheckCompilerFlag case Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !7746
| * | | try_compile: Report build dir with --debug-trycompileMatthew Woehlke2022-10-061-0/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When `--debug-trycompile` is enabled, issue a log (with trace) for every `try_compile` noting what directory is being used for the compilation. This will make it easier to find the corresponding artifacts. Closes: #24022
* | | | Merge topic 'self-target_sources'Brad King2022-10-062-13/+13
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 440822fa5c Source: Fix regression causing CMakeLib sources to be compiled repeatedly Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: buildbot <buildbot@kitware.com> Merge-request: !7748
| * | | | Source: Fix regression causing CMakeLib sources to be compiled repeatedlyBrad King2022-10-052-13/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In commit 4ff8604604 (Build: Do not use variables for sources lists, 2022-08-21) the sources of `CMakeLib` were accidentally made PUBLIC. This causes them to be compiled again in all consuming targets. Make the sources PRIVATE instead.
* | | | | CMake Nightly Date StampKitware Robot2022-10-061-1/+1
|/ / / /
* | | | CMake Nightly Date StampKitware Robot2022-10-051-1/+1
|/ / /
* | | Merge topic 'try_compile-rename-source_from_arg'Brad King2022-10-042-10/+11
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 0f28653ba9 try_compile: Rename SOURCE_FROM_ARG -> SOURCE_FROM_CONTENT Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: buildbot <buildbot@kitware.com> Merge-request: !7733
| * | | try_compile: Rename SOURCE_FROM_ARG -> SOURCE_FROM_CONTENTMatthew Woehlke2022-09-302-10/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change the SOURCE_FROM_ARG keyword to try_compile to SOURCE_FROM_CONTENT (which we can do because it was recently added and hasn't been in a release yet). The new name should be clearer as to what it does, and also more consistent with the CONTENT arguments to some other commands. Also, fix a typo in an error message.
* | | | CMake Nightly Date StampKitware Robot2022-10-041-1/+1
| | | |
* | | | Merge topic 'ci-xcode-14.0'Brad King2022-10-031-2/+7
|\ \ \ \ | | |/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | 9cdf4c9be4 gitlab-ci: update macOS jobs to use Xcode 14.0 5d2c2b2558 Tests: Update RunCMake.XcodeProject iOS cases for Xcode 14.0 12c6fec6b4 Xcode: Drop CMAKE_INTDIR= definition in Swift targets Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !7732
| * | | Xcode: Drop CMAKE_INTDIR= definition in Swift targetsBrad King2022-09-301-2/+7
| | | | | | | | | | | | | | | | | | | | Xcode 14.0 warns that Swift doesn't support definition values. Therefore `CMAKE_INTDIR` is not useful to Swift sources. Drop it.
* | | | CMake Nightly Date StampKitware Robot2022-10-031-1/+1
| | | |
* | | | CMake Nightly Date StampKitware Robot2022-10-021-1/+1
| | | |
* | | | CMake Nightly Date StampKitware Robot2022-10-011-1/+1
| | | |