From 05af537ecc6b89af5f0bb8051b63d08fb105e36b Mon Sep 17 00:00:00 2001 From: Brad King Date: Thu, 7 Dec 2017 09:33:43 -0500 Subject: cmGlobalNinjaGenerator: Avoid using deprecated std::ptr_fun It was deprecated by C++11 and removed by C++17. Use a C++11 lambda. --- Source/cmGlobalNinjaGenerator.cxx | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/Source/cmGlobalNinjaGenerator.cxx b/Source/cmGlobalNinjaGenerator.cxx index d5531cb..4f546bb 100644 --- a/Source/cmGlobalNinjaGenerator.cxx +++ b/Source/cmGlobalNinjaGenerator.cxx @@ -8,7 +8,6 @@ #include "cmsys/FStream.hxx" #include #include -#include #include #include // IWYU pragma: keep #include @@ -114,7 +113,7 @@ std::string cmGlobalNinjaGenerator::EncodeIdent(const std::string& ident, std::ostream& vars) { if (std::find_if(ident.begin(), ident.end(), - std::not1(std::ptr_fun(IsIdentChar))) != ident.end()) { + [](char c) { return !IsIdentChar(c); }) != ident.end()) { static unsigned VarNum = 0; std::ostringstream names; names << "ident" << VarNum++; -- cgit v0.12 From 31c6b9adbff0fd7113ce4b97bc4ad9514615deb8 Mon Sep 17 00:00:00 2001 From: Brad King Date: Wed, 6 Dec 2017 10:53:10 -0500 Subject: Generalize check for C++14 constructs The check for C++14 and cstdio is a special case of the more general problem of checking that the compiler's C++14 mode supports everything we need. Rename the checks accordingly. --- CMakeLists.txt | 4 ++-- Source/Checks/cm_cxx14_check.cmake | 36 ++++++++++++++++++++++++++++++++++++ Source/Checks/cm_cxx14_check.cpp | 5 +++++ Source/Checks/cm_cxx14_cstdio.cmake | 33 --------------------------------- Source/Checks/cm_cxx14_cstdio.cpp | 5 ----- 5 files changed, 43 insertions(+), 40 deletions(-) create mode 100644 Source/Checks/cm_cxx14_check.cmake create mode 100644 Source/Checks/cm_cxx14_check.cpp delete mode 100644 Source/Checks/cm_cxx14_cstdio.cmake delete mode 100644 Source/Checks/cm_cxx14_cstdio.cpp diff --git a/CMakeLists.txt b/CMakeLists.txt index ebeca22..945ae8d 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -64,8 +64,8 @@ if(NOT DEFINED CMAKE_CXX_STANDARD AND NOT CMake_NO_CXX_STANDARD) if (CMAKE_CXX_COMPILER_ID STREQUAL SunPro AND CMAKE_CXX_COMPILER_VERSION VERSION_LESS 5.14) set(CMAKE_CXX_STANDARD 98) else() - include(${CMake_SOURCE_DIR}/Source/Checks/cm_cxx14_cstdio.cmake) - if(NOT CMake_CXX14_CSTDIO_BROKEN) + include(${CMake_SOURCE_DIR}/Source/Checks/cm_cxx14_check.cmake) + if(NOT CMake_CXX14_BROKEN) set(CMAKE_CXX_STANDARD 14) else() set(CMAKE_CXX_STANDARD 11) diff --git a/Source/Checks/cm_cxx14_check.cmake b/Source/Checks/cm_cxx14_check.cmake new file mode 100644 index 0000000..a78ba35 --- /dev/null +++ b/Source/Checks/cm_cxx14_check.cmake @@ -0,0 +1,36 @@ +set(CMake_CXX14_BROKEN 0) +if(CMAKE_CXX_COMPILER_ID MATCHES "GNU|Clang") + if(NOT CMAKE_CXX14_STANDARD_COMPILE_OPTION) + set(CMake_CXX14_WORKS 0) + endif() + if(NOT DEFINED CMake_CXX14_WORKS) + message(STATUS "Checking if compiler supports needed C++14 constructs") + try_compile(CMake_CXX14_WORKS + ${CMAKE_CURRENT_BINARY_DIR} + ${CMAKE_CURRENT_LIST_DIR}/cm_cxx14_check.cpp + CMAKE_FLAGS -DCMAKE_CXX_STANDARD=14 + OUTPUT_VARIABLE OUTPUT + ) + if(CMake_CXX14_WORKS AND "${OUTPUT}" MATCHES "error: no member named.*gets.*in the global namespace") + set_property(CACHE CMake_CXX14_WORKS PROPERTY VALUE 0) + endif() + if(CMake_CXX14_WORKS) + message(STATUS "Checking if compiler supports needed C++14 constructs - yes") + file(APPEND ${CMAKE_BINARY_DIR}${CMAKE_FILES_DIRECTORY}/CMakeOutput.log + "Determining if compiler supports needed C++14 constructs passed with the following output:\n" + "${OUTPUT}\n" + "\n" + ) + else() + message(STATUS "Checking if compiler supports needed C++14 constructs - no") + file(APPEND ${CMAKE_BINARY_DIR}${CMAKE_FILES_DIRECTORY}/CMakeError.log + "Determining if compiler supports needed C++14 constructs failed with the following output:\n" + "${OUTPUT}\n" + "\n" + ) + endif() + endif() + if(NOT CMake_CXX14_WORKS) + set(CMake_CXX14_BROKEN 1) + endif() +endif() diff --git a/Source/Checks/cm_cxx14_check.cpp b/Source/Checks/cm_cxx14_check.cpp new file mode 100644 index 0000000..f5806a9 --- /dev/null +++ b/Source/Checks/cm_cxx14_check.cpp @@ -0,0 +1,5 @@ +#include +int main() +{ + return 0; +} diff --git a/Source/Checks/cm_cxx14_cstdio.cmake b/Source/Checks/cm_cxx14_cstdio.cmake deleted file mode 100644 index 73f7e2e..0000000 --- a/Source/Checks/cm_cxx14_cstdio.cmake +++ /dev/null @@ -1,33 +0,0 @@ -set(CMake_CXX14_CSTDIO_BROKEN 0) -if(CMAKE_CXX_COMPILER_ID MATCHES "GNU|Clang" AND CMAKE_CXX14_STANDARD_COMPILE_OPTION) - if(NOT DEFINED CMake_CXX14_CSTDIO_WORKS) - message(STATUS "Checking if compiler supports C++14 cstdio") - try_compile(CMake_CXX14_CSTDIO_WORKS - ${CMAKE_CURRENT_BINARY_DIR} - ${CMAKE_CURRENT_LIST_DIR}/cm_cxx14_cstdio.cpp - CMAKE_FLAGS -DCMAKE_CXX_STANDARD=14 - OUTPUT_VARIABLE OUTPUT - ) - if(CMake_CXX14_CSTDIO_WORKS AND "${OUTPUT}" MATCHES "error: no member named.*gets.*in the global namespace") - set_property(CACHE CMake_CXX14_CSTDIO_WORKS PROPERTY VALUE 0) - endif() - if(CMake_CXX14_CSTDIO_WORKS) - message(STATUS "Checking if compiler supports C++14 cstdio - yes") - file(APPEND ${CMAKE_BINARY_DIR}${CMAKE_FILES_DIRECTORY}/CMakeOutput.log - "Determining if compiler supports C++14 cstdio passed with the following output:\n" - "${OUTPUT}\n" - "\n" - ) - else() - message(STATUS "Checking if compiler supports C++14 cstdio - no") - file(APPEND ${CMAKE_BINARY_DIR}${CMAKE_FILES_DIRECTORY}/CMakeError.log - "Determining if compiler supports C++14 cstdio failed with the following output:\n" - "${OUTPUT}\n" - "\n" - ) - endif() - endif() - if(NOT CMake_CXX14_CSTDIO_WORKS) - set(CMake_CXX14_CSTDIO_BROKEN 1) - endif() -endif() diff --git a/Source/Checks/cm_cxx14_cstdio.cpp b/Source/Checks/cm_cxx14_cstdio.cpp deleted file mode 100644 index f5806a9..0000000 --- a/Source/Checks/cm_cxx14_cstdio.cpp +++ /dev/null @@ -1,5 +0,0 @@ -#include -int main() -{ - return 0; -} -- cgit v0.12 From 31d59ff3b104f012d5eca9e15c1558e2c67ef495 Mon Sep 17 00:00:00 2001 From: Brad King Date: Wed, 6 Dec 2017 11:06:12 -0500 Subject: Compile CMake as C++17 if supported by the compiler Add a check that a simple source file can compile as C++17 that uses some of the features we need. Do this only when hosted by CMake 3.8 or above because those versions are aware of C++17. Check for unordered_map as we do in bootstrap since commit 375eca7881 (bootstrap: Check support for unordered_map from compiler mode, 2017-11-30). Also maintain the existing C++14 cstdio check. --- CMakeLists.txt | 17 +++++++++++++---- Source/Checks/cm_cxx17_check.cmake | 36 ++++++++++++++++++++++++++++++++++++ Source/Checks/cm_cxx17_check.cpp | 7 +++++++ 3 files changed, 56 insertions(+), 4 deletions(-) create mode 100644 Source/Checks/cm_cxx17_check.cmake create mode 100644 Source/Checks/cm_cxx17_check.cpp diff --git a/CMakeLists.txt b/CMakeLists.txt index 945ae8d..e4d2a9a 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -64,11 +64,20 @@ if(NOT DEFINED CMAKE_CXX_STANDARD AND NOT CMake_NO_CXX_STANDARD) if (CMAKE_CXX_COMPILER_ID STREQUAL SunPro AND CMAKE_CXX_COMPILER_VERSION VERSION_LESS 5.14) set(CMAKE_CXX_STANDARD 98) else() - include(${CMake_SOURCE_DIR}/Source/Checks/cm_cxx14_check.cmake) - if(NOT CMake_CXX14_BROKEN) - set(CMAKE_CXX_STANDARD 14) + if(NOT CMAKE_VERSION VERSION_LESS 3.8) + include(${CMake_SOURCE_DIR}/Source/Checks/cm_cxx17_check.cmake) else() - set(CMAKE_CXX_STANDARD 11) + set(CMake_CXX17_BROKEN 1) + endif() + if(NOT CMake_CXX17_BROKEN) + set(CMAKE_CXX_STANDARD 17) + else() + include(${CMake_SOURCE_DIR}/Source/Checks/cm_cxx14_check.cmake) + if(NOT CMake_CXX14_BROKEN) + set(CMAKE_CXX_STANDARD 14) + else() + set(CMAKE_CXX_STANDARD 11) + endif() endif() endif() endif() diff --git a/Source/Checks/cm_cxx17_check.cmake b/Source/Checks/cm_cxx17_check.cmake new file mode 100644 index 0000000..83d3971 --- /dev/null +++ b/Source/Checks/cm_cxx17_check.cmake @@ -0,0 +1,36 @@ +set(CMake_CXX17_BROKEN 0) +if(CMAKE_CXX_COMPILER_ID MATCHES "GNU|Clang") + if(NOT CMAKE_CXX17_STANDARD_COMPILE_OPTION) + set(CMake_CXX17_WORKS 0) + endif() + if(NOT DEFINED CMake_CXX17_WORKS) + message(STATUS "Checking if compiler supports needed C++17 constructs") + try_compile(CMake_CXX17_WORKS + ${CMAKE_CURRENT_BINARY_DIR} + ${CMAKE_CURRENT_LIST_DIR}/cm_cxx17_check.cpp + CMAKE_FLAGS -DCMAKE_CXX_STANDARD=17 + OUTPUT_VARIABLE OUTPUT + ) + if(CMake_CXX17_WORKS AND "${OUTPUT}" MATCHES "error: no member named.*gets.*in the global namespace") + set_property(CACHE CMake_CXX17_WORKS PROPERTY VALUE 0) + endif() + if(CMake_CXX17_WORKS) + message(STATUS "Checking if compiler supports needed C++17 constructs - yes") + file(APPEND ${CMAKE_BINARY_DIR}${CMAKE_FILES_DIRECTORY}/CMakeOutput.log + "Determining if compiler supports needed C++17 constructs passed with the following output:\n" + "${OUTPUT}\n" + "\n" + ) + else() + message(STATUS "Checking if compiler supports needed C++17 constructs - no") + file(APPEND ${CMAKE_BINARY_DIR}${CMAKE_FILES_DIRECTORY}/CMakeError.log + "Determining if compiler supports needed C++17 constructs failed with the following output:\n" + "${OUTPUT}\n" + "\n" + ) + endif() + endif() + if(NOT CMake_CXX17_WORKS) + set(CMake_CXX17_BROKEN 1) + endif() +endif() diff --git a/Source/Checks/cm_cxx17_check.cpp b/Source/Checks/cm_cxx17_check.cpp new file mode 100644 index 0000000..2cbf1d5 --- /dev/null +++ b/Source/Checks/cm_cxx17_check.cpp @@ -0,0 +1,7 @@ +#include +#include + +int main() +{ + return 0; +} -- cgit v0.12