From f20a4257f2889387fcbf540b29b16f10843f2f9e Mon Sep 17 00:00:00 2001 From: Stephen Kelly Date: Wed, 18 Feb 2015 00:44:45 +0100 Subject: cmMakefile: Add flag to result and manipulate in place. Rather than creating a string, manipulating it, and then copying it to the result. --- Source/cmMakefile.cxx | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/Source/cmMakefile.cxx b/Source/cmMakefile.cxx index 0d0c60a..6fd569e 100644 --- a/Source/cmMakefile.cxx +++ b/Source/cmMakefile.cxx @@ -1340,11 +1340,11 @@ void cmMakefile::AddDefineFlag(const char* flag) void cmMakefile::AddDefineFlag(const char* flag, std::string& dflags) { // remove any \n\r - std::string ret = flag; - std::replace(ret.begin(), ret.end(), '\n', ' '); - std::replace(ret.begin(), ret.end(), '\r', ' '); - dflags += " "; - dflags += ret; + std::string::size_type initSize = dflags.size(); + dflags += std::string(" ") + flag; + std::string::iterator flagStart = dflags.begin() + initSize + 1; + std::replace(flagStart, dflags.end(), '\n', ' '); + std::replace(flagStart, dflags.end(), '\r', ' '); } -- cgit v0.12