From ec76a9c22fc11edd22d6fe65fc75ab9609322c88 Mon Sep 17 00:00:00 2001 From: Brad King Date: Wed, 9 Nov 2022 16:54:46 -0500 Subject: cmake-gui: Restore embedded version information in Windows binary Refactoring in commit 89a1e1c1be (Build: Link w/ `OBJECT` library is OK since 3.12, 2022-08-21, v3.25.0-rc1~97^2~19) dropped the `.res` object containing this information from the `cmake-gui` link line. Restore it. --- Source/QtDialog/CMakeLists.txt | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/Source/QtDialog/CMakeLists.txt b/Source/QtDialog/CMakeLists.txt index a41b237..c90b7ee 100644 --- a/Source/QtDialog/CMakeLists.txt +++ b/Source/QtDialog/CMakeLists.txt @@ -254,12 +254,17 @@ target_link_libraries( CMakeGUIMainLib PUBLIC CMakeGUILib - CMakeGUIQRCLib - $ ) add_executable(cmake-gui WIN32 MACOSX_BUNDLE CMakeGUIExec.cxx) -target_link_libraries(cmake-gui CMakeGUIMainLib ManifestLib Qt${INSTALLED_QT_VERSION}::Core) +target_link_libraries(cmake-gui + PRIVATE + CMakeGUIMainLib + CMakeGUIQRCLib + $ + ManifestLib + Qt${INSTALLED_QT_VERSION}::Core + ) if(WIN32) target_sources(CMakeGUIMainLib INTERFACE CMakeSetup.rc) -- cgit v0.12