From 18372afcd433cab570cbfa1223d05c604b1480b9 Mon Sep 17 00:00:00 2001 From: Kyle Edwards Date: Fri, 9 Oct 2020 13:50:36 -0400 Subject: Help: Fix documentation for Ninja Multi-Config's build.ninja --- Help/generator/Ninja Multi-Config.rst | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/Help/generator/Ninja Multi-Config.rst b/Help/generator/Ninja Multi-Config.rst index e6c7a1c..112db74 100644 --- a/Help/generator/Ninja Multi-Config.rst +++ b/Help/generator/Ninja Multi-Config.rst @@ -21,8 +21,7 @@ are intended to be run with ``ninja -f build-.ninja``. A ``cmake --build . --config `` will always use ``build-.ninja`` to build. If no ``--config`` argument is specified, ``cmake --build .`` will -default to ``build-Debug.ninja``, unless a ``build.ninja`` is generated (see -below), in which case that will be used instead. +use ``build.ninja``. Each ``build-.ninja`` file contains ```` targets as well as ``:`` targets, where ```` is the same as the -- cgit v0.12 From f4215ee57d53decea1623f60da2a598d035bf74a Mon Sep 17 00:00:00 2001 From: Kyle Edwards Date: Fri, 9 Oct 2020 13:51:01 -0400 Subject: Ninja Multi-Config: Fix segfault when installing an export Fixes: #21290 --- Source/cmGlobalNinjaGenerator.cxx | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/Source/cmGlobalNinjaGenerator.cxx b/Source/cmGlobalNinjaGenerator.cxx index 6b9a0f3..985f430 100644 --- a/Source/cmGlobalNinjaGenerator.cxx +++ b/Source/cmGlobalNinjaGenerator.cxx @@ -2532,14 +2532,14 @@ bool cmGlobalNinjaMultiGenerator::OpenBuildFileStreams() return false; } - if (!this->DefaultFileConfig.empty()) { - if (!this->OpenFileStream(this->DefaultFileStream, NINJA_BUILD_FILE)) { - return false; - } - *this->DefaultFileStream - << "# Build using rules for '" << this->DefaultFileConfig << "'.\n\n" - << "include " << GetNinjaImplFilename(this->DefaultFileConfig) << "\n\n"; + if (!this->OpenFileStream(this->DefaultFileStream, NINJA_BUILD_FILE)) { + return false; } + *this->DefaultFileStream << "# Build using rules for '" + << this->DefaultFileConfig << "'.\n\n" + << "include " + << GetNinjaImplFilename(this->DefaultFileConfig) + << "\n\n"; // Write a comment about this file. *this->CommonFileStream -- cgit v0.12