From d7159f9591282d719ec7e43af0fa3e49639f14c1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C4=90o=C3=A0n=20Tr=E1=BA=A7n=20C=C3=B4ng=20Danh?= Date: Thu, 24 Jun 2021 21:58:51 +0700 Subject: Ninja: Fix LINK_WHAT_YOU_USE link flag placement Move `-Wl,--no-as-needed` from the `` placeholder to ``, as it is in the Makefile generators. Fixes: #22342 --- Source/cmNinjaNormalTargetGenerator.cxx | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/Source/cmNinjaNormalTargetGenerator.cxx b/Source/cmNinjaNormalTargetGenerator.cxx index 9a48047..5a4c652 100644 --- a/Source/cmNinjaNormalTargetGenerator.cxx +++ b/Source/cmNinjaNormalTargetGenerator.cxx @@ -1156,16 +1156,15 @@ void cmNinjaNormalTargetGenerator::WriteLinkStatement( this->AddModuleDefinitionFlag(linkLineComputer.get(), vars["LINK_FLAGS"], config); + if (gt->GetPropertyAsBool("LINK_WHAT_YOU_USE")) { + vars["LINK_FLAGS"] += " -Wl,--no-as-needed"; + } vars["LINK_FLAGS"] = globalGen->EncodeLiteral(vars["LINK_FLAGS"]); vars["MANIFESTS"] = this->GetManifests(config); vars["AIX_EXPORTS"] = this->GetAIXExports(config); vars["LINK_PATH"] = frameworkPath + linkPath; - std::string lwyuFlags; - if (gt->GetPropertyAsBool("LINK_WHAT_YOU_USE")) { - lwyuFlags = " -Wl,--no-as-needed"; - } // Compute architecture specific link flags. Yes, these go into a different // variable for executables, probably due to a mistake made when duplicating @@ -1174,7 +1173,6 @@ void cmNinjaNormalTargetGenerator::WriteLinkStatement( std::string t = vars["FLAGS"]; localGen.AddArchitectureFlags(t, gt, this->TargetLinkLanguage(config), config); - t += lwyuFlags; vars["FLAGS"] = t; } else { std::string t = vars["ARCH_FLAGS"]; @@ -1182,7 +1180,6 @@ void cmNinjaNormalTargetGenerator::WriteLinkStatement( config); vars["ARCH_FLAGS"] = t; t.clear(); - t += lwyuFlags; localGen.AddLanguageFlagsForLinking( t, gt, this->TargetLinkLanguage(config), config); vars["LANGUAGE_COMPILE_FLAGS"] = t; -- cgit v0.12