From 9fa49dc3ad039ed0e1213afcd0da70a064991d27 Mon Sep 17 00:00:00 2001 From: David Cole Date: Wed, 28 Jul 2010 08:16:08 -0400 Subject: ExternalProject: Remove 'unknown keyword' warning (#11034) The intent was to warn about misspelled keyword arguments, but the effect was to warn about valid argument values far too often. Let's stop annoying and confusing people. --- Modules/ExternalProject.cmake | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/Modules/ExternalProject.cmake b/Modules/ExternalProject.cmake index b74f207..43e7126 100644 --- a/Modules/ExternalProject.cmake +++ b/Modules/ExternalProject.cmake @@ -154,8 +154,8 @@ function(_ep_parse_arguments f name ns args) # correctly based on target properties. # # We loop through ARGN and consider the namespace starting with an - # upper-case letter followed by at least two more upper-case letters - # or underscores to be keywords. + # upper-case letter followed by at least two more upper-case letters, + # numbers or underscores to be keywords. set(key) foreach(arg IN LISTS args) @@ -166,14 +166,6 @@ function(_ep_parse_arguments f name ns args) NOT arg MATCHES "^(TRUE|FALSE)$") if(_ep_keywords_${f} AND arg MATCHES "${_ep_keywords_${f}}") set(is_value 0) - else() - if(NOT (key STREQUAL "COMMAND") - AND NOT (key STREQUAL "CVS_MODULE") - AND NOT (key STREQUAL "DEPENDS") - AND NOT (key STREQUAL "DOWNLOAD_COMMAND") - ) - message(AUTHOR_WARNING "unknown ${f} keyword: ${arg}") - endif() endif() endif() -- cgit v0.12