From a805a897a8dcf9bee7f95280a8a169646f85bb96 Mon Sep 17 00:00:00 2001 From: Ben Boeckel Date: Tue, 22 Nov 2022 14:33:02 -0500 Subject: clang-tidy: fix `bugprone-parent-virtual-call` lints --- Source/cmGlobalVisualStudio10Generator.cxx | 1 + Source/cmGlobalVisualStudio11Generator.cxx | 1 + Source/cmGlobalVisualStudio8Generator.cxx | 2 ++ 3 files changed, 4 insertions(+) diff --git a/Source/cmGlobalVisualStudio10Generator.cxx b/Source/cmGlobalVisualStudio10Generator.cxx index e83ed7a..6931301 100644 --- a/Source/cmGlobalVisualStudio10Generator.cxx +++ b/Source/cmGlobalVisualStudio10Generator.cxx @@ -799,6 +799,7 @@ std::string cmGlobalVisualStudio10Generator::FindDevEnvCommand() } // Skip over the cmGlobalVisualStudio8Generator implementation because // we expect a real devenv and do not want to look for VCExpress. + // NOLINTNEXTLINE(bugprone-parent-virtual-call) return this->cmGlobalVisualStudio71Generator::FindDevEnvCommand(); } diff --git a/Source/cmGlobalVisualStudio11Generator.cxx b/Source/cmGlobalVisualStudio11Generator.cxx index 1155dfc..3ad10eb 100644 --- a/Source/cmGlobalVisualStudio11Generator.cxx +++ b/Source/cmGlobalVisualStudio11Generator.cxx @@ -243,6 +243,7 @@ bool cmGlobalVisualStudio11Generator::UseFolderProperty() const // Intentionally skip up to the top-level class implementation. // Folders are not supported by the Express editions in VS10 and earlier, // but they are in VS11 Express and above. + // NOLINTNEXTLINE(bugprone-parent-virtual-call) return cmGlobalGenerator::UseFolderProperty(); } diff --git a/Source/cmGlobalVisualStudio8Generator.cxx b/Source/cmGlobalVisualStudio8Generator.cxx index bc04d4c..2f25217 100644 --- a/Source/cmGlobalVisualStudio8Generator.cxx +++ b/Source/cmGlobalVisualStudio8Generator.cxx @@ -150,6 +150,7 @@ void cmGlobalVisualStudio8Generator::Configure() bool cmGlobalVisualStudio8Generator::UseFolderProperty() const { + // NOLINTNEXTLINE(bugprone-parent-virtual-call) return IsExpressEdition() ? false : cmGlobalGenerator::UseFolderProperty(); } @@ -381,6 +382,7 @@ bool cmGlobalVisualStudio8Generator::ComputeTargetDepends() { // Skip over the cmGlobalVisualStudioGenerator implementation! // We do not need the support that VS <= 7.1 needs. + // NOLINTNEXTLINE(bugprone-parent-virtual-call) return this->cmGlobalGenerator::ComputeTargetDepends(); } -- cgit v0.12