From ad47e6e5bc4822dc5bc9d82ae1d7590aee4ece95 Mon Sep 17 00:00:00 2001 From: Stephen Kelly Date: Sun, 21 Jun 2015 19:57:15 +0200 Subject: cmMakefile: Inline ReadListFileInternal into caller. --- Source/cmMakefile.cxx | 27 +++++++++++---------------- Source/cmMakefile.h | 2 -- 2 files changed, 11 insertions(+), 18 deletions(-) diff --git a/Source/cmMakefile.cxx b/Source/cmMakefile.cxx index b02cfc8..c4400d1 100644 --- a/Source/cmMakefile.cxx +++ b/Source/cmMakefile.cxx @@ -595,22 +595,6 @@ bool cmMakefile::ReadListFile(const char* listfile, this->MarkVariableAsUsed("CMAKE_CURRENT_LIST_FILE"); this->MarkVariableAsUsed("CMAKE_CURRENT_LIST_DIR"); - this->ReadListFileInternal(listFile); - this->CheckForUnusedVariables(); - - this->AddDefinition("CMAKE_PARENT_LIST_FILE", currentParentFile.c_str()); - this->AddDefinition("CMAKE_CURRENT_LIST_FILE", currentFile.c_str()); - this->AddDefinition("CMAKE_CURRENT_LIST_DIR", - cmSystemTools::GetFilenamePath(currentFile).c_str()); - this->MarkVariableAsUsed("CMAKE_PARENT_LIST_FILE"); - this->MarkVariableAsUsed("CMAKE_CURRENT_LIST_FILE"); - this->MarkVariableAsUsed("CMAKE_CURRENT_LIST_DIR"); - - return true; -} - -void cmMakefile::ReadListFileInternal(cmListFile const& listFile) -{ // Enforce balanced blocks (if/endif, function/endfunction, etc.). LexicalPushPop lexScope(this); @@ -632,6 +616,17 @@ void cmMakefile::ReadListFileInternal(cmListFile const& listFile) break; } } + this->CheckForUnusedVariables(); + + this->AddDefinition("CMAKE_PARENT_LIST_FILE", currentParentFile.c_str()); + this->AddDefinition("CMAKE_CURRENT_LIST_FILE", currentFile.c_str()); + this->AddDefinition("CMAKE_CURRENT_LIST_DIR", + cmSystemTools::GetFilenamePath(currentFile).c_str()); + this->MarkVariableAsUsed("CMAKE_PARENT_LIST_FILE"); + this->MarkVariableAsUsed("CMAKE_CURRENT_LIST_FILE"); + this->MarkVariableAsUsed("CMAKE_CURRENT_LIST_DIR"); + + return true; } //---------------------------------------------------------------------------- diff --git a/Source/cmMakefile.h b/Source/cmMakefile.h index 9896d5b..8ea6e13 100644 --- a/Source/cmMakefile.h +++ b/Source/cmMakefile.h @@ -917,8 +917,6 @@ private: bool ReadListFile(const char* listfile, bool requireProjectCommand); - void ReadListFileInternal(cmListFile const& listFile); - bool ParseDefineFlag(std::string const& definition, bool remove); bool EnforceUniqueDir(const std::string& srcPath, -- cgit v0.12