From 5058fb5401d1b07f4074bd6f1e4281008bf1b65f Mon Sep 17 00:00:00 2001 From: Brad King Date: Fri, 29 May 2020 08:14:39 -0400 Subject: VS: Drop StdOutEncoding with VS 16.6 pending investigation The `StdOutEncoding` added to `.vcxproj` files since commit bc877a7e94 (Add support to indicate UTF-8 custom command pipe output encoding, 2020-04-08) breaks custom commands with symbolic outputs on VS 16.6.0. Disable it pending further investigation and possibly a fix in VS. Issue: #20769 --- Source/cmVisualStudio10TargetGenerator.cxx | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/Source/cmVisualStudio10TargetGenerator.cxx b/Source/cmVisualStudio10TargetGenerator.cxx index de88182..8cb933b 100644 --- a/Source/cmVisualStudio10TargetGenerator.cxx +++ b/Source/cmVisualStudio10TargetGenerator.cxx @@ -4951,7 +4951,10 @@ std::string cmVisualStudio10TargetGenerator::GetCMakeFilePath( return path; } -void cmVisualStudio10TargetGenerator::WriteStdOutEncodingUtf8(Elem& e1) +void cmVisualStudio10TargetGenerator::WriteStdOutEncodingUtf8(Elem& /* e1 */) { - e1.Element("StdOutEncoding", "UTF-8"); + // FIXME: As of VS 16.6.0, this breaks custom commands with symbolic outputs. + // See https://gitlab.kitware.com/cmake/cmake/-/issues/20769 for details. + // Disable it for now. + // e1.Element("StdOutEncoding", "UTF-8"); } -- cgit v0.12