From a70df0d6f08aaf87b9a1337eed5fba06ca5701d5 Mon Sep 17 00:00:00 2001 From: Josef Angstenberger Date: Thu, 30 Jul 2020 00:47:32 +0200 Subject: Compiler/TI: Avoid generic variable name in macro In commit a548a52230 (Compiler/TI: Refactor C/CXX to use a common file, 2020-07-11) a variable named `prefix` has been introduced. It is set in the callers namespace because it was defined inside a macro, not a function. Avoid such generic variable name. --- Modules/Compiler/TI.cmake | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/Modules/Compiler/TI.cmake b/Modules/Compiler/TI.cmake index 9f2e813..d59fd49 100644 --- a/Modules/Compiler/TI.cmake +++ b/Modules/Compiler/TI.cmake @@ -8,21 +8,20 @@ if(__COMPILER_TI) endif() set(__COMPILER_TI 1) -macro(__compiler_ti lang) - string(TOLOWER ${lang} prefix) - if("x${lang}" STREQUAL "xCXX") - set(prefix "cpp") - endif() +set(__COMPILER_TI_SOURCE_FLAG_C "--c_file") +set(__COMPILER_TI_SOURCE_FLAG_CXX "--cpp_file") +set(__COMPILER_TI_SOURCE_FLAG_ASM "--asm_file") +macro(__compiler_ti lang) set(CMAKE_${lang}_RESPONSE_FILE_FLAG "--cmd_file=") set(CMAKE_INCLUDE_FLAG_${lang} "--include_path=") set(CMAKE_DEPFILE_FLAGS_${lang} "--preproc_with_compile --preproc_dependency=") - set(CMAKE_${lang}_CREATE_PREPROCESSED_SOURCE " --preproc_only --${prefix}_file= --output_file=") - set(CMAKE_${lang}_CREATE_ASSEMBLY_SOURCE " --compile_only --skip_assembler --${prefix}_file= --output_file=") + set(CMAKE_${lang}_CREATE_PREPROCESSED_SOURCE " --preproc_only ${__COMPILER_TI_SOURCE_FLAG_${lang}}= --output_file=") + set(CMAKE_${lang}_CREATE_ASSEMBLY_SOURCE " --compile_only --skip_assembler ${__COMPILER_TI_SOURCE_FLAG_${lang}}= --output_file=") - set(CMAKE_${lang}_COMPILE_OBJECT " --compile_only --${prefix}_file= --output_file=") + set(CMAKE_${lang}_COMPILE_OBJECT " --compile_only ${__COMPILER_TI_SOURCE_FLAG_${lang}}= --output_file=") set(CMAKE_${lang}_ARCHIVE_CREATE " qr ") set(CMAKE_${lang}_ARCHIVE_APPEND " qa ") -- cgit v0.12