From 37c2f722fcae58f2834a061f52f2ddb78dac2fb2 Mon Sep 17 00:00:00 2001 From: Brad King Date: Fri, 29 Oct 2021 09:10:38 -0400 Subject: find_program: Explicitly skip WindowsApps/python*.exe app installer links Windows provide a "python" executable like this: %USERPROFILE%\AppData\Local\Microsoft\WindowsApps\python.exe It is actually a Windows app exec link. If it points to an app installer, avoid mistaking it for a working Python. --- Source/cmFindProgramCommand.cxx | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/Source/cmFindProgramCommand.cxx b/Source/cmFindProgramCommand.cxx index 1c87625..9a4b063 100644 --- a/Source/cmFindProgramCommand.cxx +++ b/Source/cmFindProgramCommand.cxx @@ -104,6 +104,26 @@ struct cmFindProgramHelper } bool FileIsExecutable(std::string const& file) const { +#ifdef _WIN32 + if (!this->FileIsExecutableCMP0109(file)) { + return false; + } + // Pretend the Windows "python" app installer alias does not exist. + if (cmSystemTools::LowerCase(file).find("/windowsapps/python") != + std::string::npos) { + std::string dest; + if (cmSystemTools::ReadSymlink(file, dest) && + cmHasLiteralSuffix(dest, "\\AppInstallerPythonRedirector.exe")) { + return false; + } + } + return true; +#else + return this->FileIsExecutableCMP0109(file); +#endif + } + bool FileIsExecutableCMP0109(std::string const& file) const + { switch (this->PolicyCMP0109) { case cmPolicies::OLD: return cmSystemTools::FileExists(file, true); -- cgit v0.12