From e80dc2ad7fd8cde15ad62ffd7743eba20fbc8524 Mon Sep 17 00:00:00 2001 From: Betsy McPhail Date: Wed, 11 Oct 2017 19:39:04 -0400 Subject: cmCTest: Remove dead code The option 'ctest-config' is ignored. --- Help/manual/ctest.1.rst | 7 ------- Source/cmCTest.cxx | 10 +++------- Source/cmCTest.h | 1 - Source/ctest.cxx | 2 -- 4 files changed, 3 insertions(+), 17 deletions(-) diff --git a/Help/manual/ctest.1.rst b/Help/manual/ctest.1.rst index 423f1ca..d586e22 100644 --- a/Help/manual/ctest.1.rst +++ b/Help/manual/ctest.1.rst @@ -338,13 +338,6 @@ Options This is useful if the build will not finish in one day. -``--ctest-config`` - The configuration file used to initialize CTest state when submitting dashboards. - - This option tells CTest to use different initialization file instead - of CTestConfiguration.tcl. This way multiple initialization files - can be used for example to submit to multiple dashboards. - ``--overwrite`` Overwrite CTest configuration option. diff --git a/Source/cmCTest.cxx b/Source/cmCTest.cxx index 37ff901..92da9ab 100644 --- a/Source/cmCTest.cxx +++ b/Source/cmCTest.cxx @@ -282,7 +282,6 @@ cmCTest::cmCTest() this->GlobalTimeout = 0; this->LastStopTimeout = 24 * 60 * 60; this->CompressXMLFiles = false; - this->CTestConfigFile.clear(); this->ScheduleType.clear(); this->StopTime.clear(); this->NextDayStopTime = false; @@ -623,12 +622,9 @@ bool cmCTest::UpdateCTestConfiguration() if (this->SuppressUpdatingCTestConfiguration) { return true; } - std::string fileName = this->CTestConfigFile; - if (fileName.empty()) { - fileName = this->BinaryDir + "/CTestConfiguration.ini"; - if (!cmSystemTools::FileExists(fileName.c_str())) { - fileName = this->BinaryDir + "/DartConfiguration.tcl"; - } + std::string fileName = this->BinaryDir + "/CTestConfiguration.ini"; + if (!cmSystemTools::FileExists(fileName.c_str())) { + fileName = this->BinaryDir + "/DartConfiguration.tcl"; } cmCTestLog(this, HANDLER_VERBOSE_OUTPUT, "UpdateCTestConfiguration from :" << fileName << "\n"); diff --git a/Source/cmCTest.h b/Source/cmCTest.h index dbd67dc..a2d6fc3 100644 --- a/Source/cmCTest.h +++ b/Source/cmCTest.h @@ -487,7 +487,6 @@ private: /** Map of configuration properties */ typedef std::map CTestConfigurationMap; - std::string CTestConfigFile; // TODO: The ctest configuration should be a hierarchy of // configuration option sources: command-line, script, ini file. // Then the ini file can get re-loaded whenever it changes without diff --git a/Source/ctest.cxx b/Source/ctest.cxx index f6466fa..ad5fec0 100644 --- a/Source/ctest.cxx +++ b/Source/ctest.cxx @@ -104,8 +104,6 @@ static const char* cmDocumentationOptions[][2] = { { "--test-timeout", "The time limit in seconds, internal use only." }, { "--test-load", "CPU load threshold for starting new parallel tests." }, { "--tomorrow-tag", "Nightly or experimental starts with next day tag." }, - { "--ctest-config", "The configuration file used to initialize CTest state " - "when submitting dashboards." }, { "--overwrite", "Overwrite CTest configuration option." }, { "--extra-submit [;]", "Submit extra files to the dashboard." }, { "--force-new-ctest-process", -- cgit v0.12 From 7904b659ea71fdac47e72edd8309c72b4f7d7e8b Mon Sep 17 00:00:00 2001 From: Betsy McPhail Date: Wed, 11 Oct 2017 19:42:11 -0400 Subject: Tests: Remove incorrect use of 'test-timeout' option --- Tests/RunCMake/CTestCommandLine/RunCMakeTest.cmake | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Tests/RunCMake/CTestCommandLine/RunCMakeTest.cmake b/Tests/RunCMake/CTestCommandLine/RunCMakeTest.cmake index e936dab..0fafea5 100644 --- a/Tests/RunCMake/CTestCommandLine/RunCMakeTest.cmake +++ b/Tests/RunCMake/CTestCommandLine/RunCMakeTest.cmake @@ -102,7 +102,7 @@ function(run_TestLoad name load) add_test(TestLoad1 \"${CMAKE_COMMAND}\" -E echo \"test of --test-load\") add_test(TestLoad2 \"${CMAKE_COMMAND}\" -E echo \"test of --test-load\") ") - run_cmake_command(${name} ${CMAKE_CTEST_COMMAND} -j2 --test-load ${load} --test-timeout 5) + run_cmake_command(${name} ${CMAKE_CTEST_COMMAND} -j2 --test-load ${load}) endfunction() # Tests for the --test-load feature of ctest -- cgit v0.12 From 9d3aa95ca4c20d9eb47e8a588c9279c6f37bb4a9 Mon Sep 17 00:00:00 2001 From: Betsy McPhail Date: Wed, 8 Nov 2017 12:18:56 -0500 Subject: Help: Divide ctest(1) manual options into sections --- Help/manual/ctest.1.rst | 201 +++++++++++++++++++++++++++--------------------- 1 file changed, 114 insertions(+), 87 deletions(-) diff --git a/Help/manual/ctest.1.rst b/Help/manual/ctest.1.rst index d586e22..0a6b1dd 100644 --- a/Help/manual/ctest.1.rst +++ b/Help/manual/ctest.1.rst @@ -3,12 +3,18 @@ ctest(1) ******** +.. contents:: + Synopsis ======== .. parsed-literal:: ctest [] + ctest --build-generator + [...] [-- ...] [--test-command ] + ctest (-D | -M -T | -S