From a4c48afbbca19ab348d008ae2c8e8aa8ac09983f Mon Sep 17 00:00:00 2001 From: Brad King Date: Mon, 6 Jun 2022 11:32:32 -0400 Subject: Utilities/Release: Drop unnecessary system API definitions for Linux We previously defined `_POSIX_C_SOURCE` and friends while building binary packages in order to minimize the version of glibc needed at runtime. The definitions were added by commit facc240a45 (Utilities/Release: Add docker specs to build and test Linux binaries, 2019-08-23, v3.16.0-rc1~184^2~2), but came from older packaging scripts that were removed by commit 689fdbfc61 (Utilities/Release: Drop linux64 script in favor of docker build, 2019-08-27, v3.16.0-rc1~184^2). Those older scripts were meant for use in a hand-maintained environment. Now that we use base images of old CentOS versions to establish the build environment, our builds are already limited to older glibc versions (glibc 2.12 from centos6 on x86_64, and 2.17 from centos7 on aarch64). Our old system API definitions no longer affect the glibc version required by the binaries. Drop them to avoid potential conflicts with system API definitions added by changes like commit f034b0f663 (CMake compilation: do not use compiler extensions, 2020-03-14, v3.18.0-rc1~494^2) and commit c7c3e39e4f (Utilities: Activate POSIX APIs even without compiler extensions, 2022-06-02). --- Utilities/Release/linux/aarch64/cache.txt | 3 --- Utilities/Release/linux/x86_64/cache.txt | 3 --- 2 files changed, 6 deletions(-) diff --git a/Utilities/Release/linux/aarch64/cache.txt b/Utilities/Release/linux/aarch64/cache.txt index ebfed73..87851d5 100644 --- a/Utilities/Release/linux/aarch64/cache.txt +++ b/Utilities/Release/linux/aarch64/cache.txt @@ -3,9 +3,6 @@ CMAKE_BUILD_TYPE:STRING=Release CMAKE_C_STANDARD:STRING=11 CMAKE_CXX_STANDARD:STRING=14 -# Require only older APIs where possible. -CMAKE_C_FLAGS:STRING=-D_POSIX_C_SOURCE=199506L -D_POSIX_SOURCE=1 -D_SVID_SOURCE=1 -D_BSD_SOURCE=1 - # Link C++ library statically. CMAKE_EXE_LINKER_FLAGS:STRING=-static-libstdc++ -static-libgcc diff --git a/Utilities/Release/linux/x86_64/cache.txt b/Utilities/Release/linux/x86_64/cache.txt index a422af3..d32c3dd 100644 --- a/Utilities/Release/linux/x86_64/cache.txt +++ b/Utilities/Release/linux/x86_64/cache.txt @@ -3,9 +3,6 @@ CMAKE_BUILD_TYPE:STRING=Release CMAKE_C_STANDARD:STRING=11 CMAKE_CXX_STANDARD:STRING=14 -# Require only older APIs where possible. -CMAKE_C_FLAGS:STRING=-D_POSIX_C_SOURCE=199506L -D_POSIX_SOURCE=1 -D_SVID_SOURCE=1 -D_BSD_SOURCE=1 - # Link C++ library statically. CMAKE_EXE_LINKER_FLAGS:STRING=-static-libstdc++ -static-libgcc -- cgit v0.12