From 90f91e4d217e64c5a68c8069500b83329eaee6b9 Mon Sep 17 00:00:00 2001 From: Alex Turbov Date: Sat, 6 Jul 2019 02:53:32 +0300 Subject: Refactor: Replace a "magic" number w/ a named constant --- Source/cmProjectCommand.cxx | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/Source/cmProjectCommand.cxx b/Source/cmProjectCommand.cxx index a4ed300..c08ad0f 100644 --- a/Source/cmProjectCommand.cxx +++ b/Source/cmProjectCommand.cxx @@ -220,13 +220,14 @@ bool cmProjectCommand::InitialPass(std::vector const& args, return true; } + constexpr std::size_t MAX_VERSION_COMPONENTS = 4u; std::string vs; - char vb[4][64]; - unsigned int v[4] = { 0, 0, 0, 0 }; + char vb[MAX_VERSION_COMPONENTS][64]; + unsigned int v[MAX_VERSION_COMPONENTS] = { 0, 0, 0, 0 }; int vc = sscanf(version.c_str(), "%u.%u.%u.%u", &v[0], &v[1], &v[2], &v[3]); - for (int i = 0; i < 4; ++i) { - if (i < vc) { + for (auto i = 0u; i < MAX_VERSION_COMPONENTS; ++i) { + if (int(i) < vc) { sprintf(vb[i], "%u", v[i]); vs += &"."[size_t(i == 0)]; vs += vb[i]; -- cgit v0.12