From 6c2af9d302f1c893219f2aad014a2b183bb438a1 Mon Sep 17 00:00:00 2001 From: Brad King Date: Tue, 25 Sep 2018 10:41:29 -0400 Subject: cmListFileCache: Add missing assertion in backtrace Top method We can only get the top of a stack that has at least one call. Update the method's comment accordingly. --- Source/cmListFileCache.cxx | 1 + Source/cmListFileCache.h | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/Source/cmListFileCache.cxx b/Source/cmListFileCache.cxx index e465e1a..4d7e1e2 100644 --- a/Source/cmListFileCache.cxx +++ b/Source/cmListFileCache.cxx @@ -377,6 +377,7 @@ cmListFileBacktrace cmListFileBacktrace::Pop() const cmListFileContext const& cmListFileBacktrace::Top() const { assert(this->TopEntry); + assert(!this->TopEntry->IsBottom()); return this->TopEntry->Context; } diff --git a/Source/cmListFileCache.h b/Source/cmListFileCache.h index 2c91f7a..faddec7 100644 --- a/Source/cmListFileCache.h +++ b/Source/cmListFileCache.h @@ -144,7 +144,7 @@ public: cmListFileBacktrace Pop() const; // Get the context at the top of the backtrace. - // Returns an empty context if the backtrace is empty. + // This may be called only if Empty() would return false. cmListFileContext const& Top() const; // Print the top of the backtrace. -- cgit v0.12