From d6cf89c0d48cc8689a9d6219846b21a210557ed3 Mon Sep 17 00:00:00 2001 From: Rolf Eike Beer Date: Wed, 18 Mar 2020 18:52:36 +0100 Subject: remove needless check for std::string::substr() Passing npos is legal and means "rest of the string". --- Source/CPack/IFW/cmCPackIFWPackage.cxx | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/Source/CPack/IFW/cmCPackIFWPackage.cxx b/Source/CPack/IFW/cmCPackIFWPackage.cxx index 9a9cd56..56a74c5 100644 --- a/Source/CPack/IFW/cmCPackIFWPackage.cxx +++ b/Source/CPack/IFW/cmCPackIFWPackage.cxx @@ -55,8 +55,7 @@ cmCPackIFWPackage::DependenceStruct::DependenceStruct( if (dashPos != std::string::npos) { pos = dashPos; } - this->Name = - pos == std::string::npos ? dependence : dependence.substr(0, pos); + this->Name = dependence.substr(0, pos); } std::string cmCPackIFWPackage::DependenceStruct::NameWithCompare() const -- cgit v0.12