From 0f6fc388ea0c539d783e8f74715b5049112a52f6 Mon Sep 17 00:00:00 2001 From: Anakin Skywalker <hex7c3@gmail.com> Date: Fri, 5 Feb 2021 20:43:13 +0000 Subject: AddFileDependencies: Avoid leaking temporary variable Convert `add_file_dependencies` to a function. Simplify the implementation using `set_property` with `APPEND`. --- Modules/AddFileDependencies.cmake | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/Modules/AddFileDependencies.cmake b/Modules/AddFileDependencies.cmake index 598a52f..c038858 100644 --- a/Modules/AddFileDependencies.cmake +++ b/Modules/AddFileDependencies.cmake @@ -9,20 +9,13 @@ Add dependencies to a source file. .. code-block:: cmake - ADD_FILE_DEPENDENCIES(<source> <files>) + add_file_dependencies(<source> <files>) Adds the given ``<files>`` to the dependencies of file ``<source>``. #]=======================================================================] -macro(ADD_FILE_DEPENDENCIES _file) +function(add_file_dependencies _file) - get_source_file_property(_deps ${_file} OBJECT_DEPENDS) - if (_deps) - set(_deps ${_deps} ${ARGN}) - else () - set(_deps ${ARGN}) - endif () + set_property(SOURCE "${_file}" APPEND PROPERTY OBJECT_DEPENDS "${ARGN}") - set_source_files_properties(${_file} PROPERTIES OBJECT_DEPENDS "${_deps}") - -endmacro() +endfunction() -- cgit v0.12