From 7ed7db88a4c3efb93b0ee21e94aaef94e4d89e9d Mon Sep 17 00:00:00 2001 From: Craig Scott Date: Sun, 14 Feb 2021 15:24:25 +1100 Subject: CPackIFW: Fix cppcheck warnings The cppcheck warnings about uninitialised variables are likely harmless, since they are initialised in ParseResource() anyway. Fix the warnings anyway to reduce linting noise. The warning about a single argument non-explicit constructor is worth fixing in general. --- Source/CPack/IFW/cmCPackIFWInstaller.cxx | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/Source/CPack/IFW/cmCPackIFWInstaller.cxx b/Source/CPack/IFW/cmCPackIFWInstaller.cxx index 359fc56..d3c39e8 100644 --- a/Source/CPack/IFW/cmCPackIFWInstaller.cxx +++ b/Source/CPack/IFW/cmCPackIFWInstaller.cxx @@ -275,9 +275,8 @@ void cmCPackIFWInstaller::ConfigureFromOptions() class cmCPackIFWResourcesParser : public cmXMLParser { public: - cmCPackIFWResourcesParser(cmCPackIFWInstaller* i) + explicit cmCPackIFWResourcesParser(cmCPackIFWInstaller* i) : installer(i) - , file(false) { this->path = i->Directory + "/resources"; } @@ -296,7 +295,9 @@ public: } cmCPackIFWInstaller* installer; - bool file, hasFiles, hasErrors; + bool file = false; + bool hasFiles = false; + bool hasErrors = false; std::string path, basePath; protected: -- cgit v0.12