From 32cb564bea57af007d03fa31d80a0177057fc901 Mon Sep 17 00:00:00 2001
From: Regina Pfeifer <regina@mailbox.org>
Date: Thu, 6 Dec 2018 22:52:39 +0100
Subject: clang-tidy: Remove redundant member initializations
---
.clang-tidy | 1 -
Source/CTest/cmCTestGIT.cxx | 4 +---
Source/CTest/cmCTestSubmitHandler.cxx | 1 -
Source/cmComputeLinkDepends.h | 3 +--
Source/cmComputeLinkInformation.h | 3 +--
Source/cmCustomCommand.cxx | 1 -
Source/cmDefinitions.h | 3 +--
Source/cmExportCommand.cxx | 4 +---
Source/cmExtraCodeBlocksGenerator.cxx | 1 -
Source/cmExtraCodeLiteGenerator.cxx | 3 +--
Source/cmExtraEclipseCDT4Generator.cxx | 1 -
Source/cmExtraKateGenerator.cxx | 1 -
Source/cmExtraSublimeTextGenerator.cxx | 1 -
Source/cmFindPackageCommand.cxx | 42 +++++++++++----------------------
Source/cmGeneratedFileStream.cxx | 10 ++------
Source/cmGlobalNinjaGenerator.cxx | 2 --
Source/cmInstallCommandArguments.cxx | 4 +---
Source/cmLinkItem.cxx | 6 ++---
Source/cmListFileCache.h | 7 ++----
Source/cmLocalUnixMakefileGenerator3.h | 1 -
Source/cmNinjaNormalTargetGenerator.cxx | 6 -----
Source/cmNinjaTargetGenerator.cxx | 2 --
Source/cmStatePrivate.h | 3 +--
Source/cmStateSnapshot.cxx | 1 -
Source/cmString.hxx | 3 +--
Source/cmStringReplaceHelper.h | 1 -
26 files changed, 29 insertions(+), 86 deletions(-)
diff --git a/.clang-tidy b/.clang-tidy
index b35bc65..20f1bf1 100644
--- a/.clang-tidy
+++ b/.clang-tidy
@@ -33,7 +33,6 @@ readability-*,\
-readability-inconsistent-declaration-parameter-name,\
-readability-named-parameter,\
-readability-redundant-declaration,\
--readability-redundant-member-init,\
-readability-simplify-boolean-expr,\
"
HeaderFilterRegex: 'Source/cm[^/]*\.(h|hxx|cxx)$'
diff --git a/Source/CTest/cmCTestGIT.cxx b/Source/CTest/cmCTestGIT.cxx
index 97c6b4f..471ab88 100644
--- a/Source/CTest/cmCTestGIT.cxx
+++ b/Source/CTest/cmCTestGIT.cxx
@@ -478,9 +478,7 @@ private:
unsigned long Time;
long TimeZone;
Person()
- : Name()
- , EMail()
- , Time(0)
+ : Time(0)
, TimeZone(0)
{
}
diff --git a/Source/CTest/cmCTestSubmitHandler.cxx b/Source/CTest/cmCTestSubmitHandler.cxx
index 67c669c..3042480 100644
--- a/Source/CTest/cmCTestSubmitHandler.cxx
+++ b/Source/CTest/cmCTestSubmitHandler.cxx
@@ -119,7 +119,6 @@ static size_t cmCTestSubmitHandlerCurlDebugCallback(CURL* /*unused*/,
}
cmCTestSubmitHandler::cmCTestSubmitHandler()
- : HTTPProxy()
{
this->Initialize();
}
diff --git a/Source/cmComputeLinkDepends.h b/Source/cmComputeLinkDepends.h
index 66fb1e6..a81f705 100644
--- a/Source/cmComputeLinkDepends.h
+++ b/Source/cmComputeLinkDepends.h
@@ -39,8 +39,7 @@ public:
bool IsSharedDep;
bool IsFlag;
LinkEntry()
- : Item()
- , Target(nullptr)
+ : Target(nullptr)
, IsSharedDep(false)
, IsFlag(false)
{
diff --git a/Source/cmComputeLinkInformation.h b/Source/cmComputeLinkInformation.h
index e00d230..202bebd 100644
--- a/Source/cmComputeLinkInformation.h
+++ b/Source/cmComputeLinkInformation.h
@@ -31,8 +31,7 @@ public:
struct Item
{
Item()
- : Value()
- , IsPath(true)
+ : IsPath(true)
, Target(nullptr)
{
}
diff --git a/Source/cmCustomCommand.cxx b/Source/cmCustomCommand.cxx
index e87eb1e..3f9f3f7 100644
--- a/Source/cmCustomCommand.cxx
+++ b/Source/cmCustomCommand.cxx
@@ -15,7 +15,6 @@ cmCustomCommand::cmCustomCommand(cmMakefile const* mf,
, Byproducts(byproducts)
, Depends(depends)
, CommandLines(commandLines)
- , Backtrace()
, Comment(comment ? comment : "")
, WorkingDirectory(workingDirectory ? workingDirectory : "")
, HaveComment(comment != nullptr)
diff --git a/Source/cmDefinitions.h b/Source/cmDefinitions.h
index 4ab5be6..9a97255 100644
--- a/Source/cmDefinitions.h
+++ b/Source/cmDefinitions.h
@@ -48,8 +48,7 @@ private:
public:
Def()
- : std_string()
- , Exists(false)
+ : Exists(false)
, Used(false)
{
}
diff --git a/Source/cmExportCommand.cxx b/Source/cmExportCommand.cxx
index f965a29..3706a3c 100644
--- a/Source/cmExportCommand.cxx
+++ b/Source/cmExportCommand.cxx
@@ -25,9 +25,7 @@ class cmExecutionStatus;
#endif
cmExportCommand::cmExportCommand()
- : cmCommand()
- , ArgumentGroup()
- , Targets(&Helper, "TARGETS")
+ : Targets(&Helper, "TARGETS")
, Append(&Helper, "APPEND", &ArgumentGroup)
, ExportSetName(&Helper, "EXPORT", &ArgumentGroup)
, Namespace(&Helper, "NAMESPACE", &ArgumentGroup)
diff --git a/Source/cmExtraCodeBlocksGenerator.cxx b/Source/cmExtraCodeBlocksGenerator.cxx
index 07a60de..d70352f 100644
--- a/Source/cmExtraCodeBlocksGenerator.cxx
+++ b/Source/cmExtraCodeBlocksGenerator.cxx
@@ -33,7 +33,6 @@ http://forums.codeblocks.org/index.php/topic,6789.0.html
*/
cmExtraCodeBlocksGenerator::cmExtraCodeBlocksGenerator()
- : cmExternalMakefileProjectGenerator()
{
}
diff --git a/Source/cmExtraCodeLiteGenerator.cxx b/Source/cmExtraCodeLiteGenerator.cxx
index 28106d1..194f0ac 100644
--- a/Source/cmExtraCodeLiteGenerator.cxx
+++ b/Source/cmExtraCodeLiteGenerator.cxx
@@ -21,8 +21,7 @@
#include <utility>
cmExtraCodeLiteGenerator::cmExtraCodeLiteGenerator()
- : cmExternalMakefileProjectGenerator()
- , ConfigName("NoConfig")
+ : ConfigName("NoConfig")
, CpuCount(2)
{
}
diff --git a/Source/cmExtraEclipseCDT4Generator.cxx b/Source/cmExtraEclipseCDT4Generator.cxx
index adb14ec..e7f3ada 100644
--- a/Source/cmExtraEclipseCDT4Generator.cxx
+++ b/Source/cmExtraEclipseCDT4Generator.cxx
@@ -41,7 +41,6 @@ void AppendDictionary(cmXMLWriter& xml, const char* key, T const& value)
}
cmExtraEclipseCDT4Generator::cmExtraEclipseCDT4Generator()
- : cmExternalMakefileProjectGenerator()
{
this->SupportsVirtualFolders = true;
this->GenerateLinkedResources = true;
diff --git a/Source/cmExtraKateGenerator.cxx b/Source/cmExtraKateGenerator.cxx
index 9410690..a9ed7fe 100644
--- a/Source/cmExtraKateGenerator.cxx
+++ b/Source/cmExtraKateGenerator.cxx
@@ -17,7 +17,6 @@
#include <vector>
cmExtraKateGenerator::cmExtraKateGenerator()
- : cmExternalMakefileProjectGenerator()
{
}
diff --git a/Source/cmExtraSublimeTextGenerator.cxx b/Source/cmExtraSublimeTextGenerator.cxx
index 882d39f..0a1886a 100644
--- a/Source/cmExtraSublimeTextGenerator.cxx
+++ b/Source/cmExtraSublimeTextGenerator.cxx
@@ -55,7 +55,6 @@ cmExtraSublimeTextGenerator::GetFactory()
}
cmExtraSublimeTextGenerator::cmExtraSublimeTextGenerator()
- : cmExternalMakefileProjectGenerator()
{
this->ExcludeBuildFolder = false;
}
diff --git a/Source/cmFindPackageCommand.cxx b/Source/cmFindPackageCommand.cxx
index bf928fc..b045c49 100644
--- a/Source/cmFindPackageCommand.cxx
+++ b/Source/cmFindPackageCommand.cxx
@@ -1676,8 +1676,7 @@ class cmFileList
{
public:
cmFileList()
- : First()
- , Last(nullptr)
+ : Last(nullptr)
{
}
virtual ~cmFileList() {}
@@ -1710,8 +1709,7 @@ class cmFindPackageFileList : public cmFileList
{
public:
cmFindPackageFileList(cmFindPackageCommand* fpc, bool use_suffixes = true)
- : cmFileList()
- , FPC(fpc)
+ : FPC(fpc)
, UseSuffixes(use_suffixes)
{
}
@@ -1753,13 +1751,11 @@ class cmFileListGeneratorFixed : public cmFileListGeneratorBase
{
public:
cmFileListGeneratorFixed(std::string const& str)
- : cmFileListGeneratorBase()
- , String(str)
+ : String(str)
{
}
cmFileListGeneratorFixed(cmFileListGeneratorFixed const& r)
- : cmFileListGeneratorBase()
- , String(r.String)
+ : String(r.String)
{
}
@@ -1782,13 +1778,11 @@ class cmFileListGeneratorEnumerate : public cmFileListGeneratorBase
{
public:
cmFileListGeneratorEnumerate(std::vector<std::string> const& v)
- : cmFileListGeneratorBase()
- , Vector(v)
+ : Vector(v)
{
}
cmFileListGeneratorEnumerate(cmFileListGeneratorEnumerate const& r)
- : cmFileListGeneratorBase()
- , Vector(r.Vector)
+ : Vector(r.Vector)
{
}
@@ -1817,14 +1811,12 @@ public:
cmFileListGeneratorProject(std::vector<std::string> const& names,
cmFindPackageCommand::SortOrderType so,
cmFindPackageCommand::SortDirectionType sd)
- : cmFileListGeneratorBase()
- , Names(names)
+ : Names(names)
{
this->SetSort(so, sd);
}
cmFileListGeneratorProject(cmFileListGeneratorProject const& r)
- : cmFileListGeneratorBase()
- , Names(r.Names)
+ : Names(r.Names)
{
this->SetSort(r.SortOrder, r.SortDirection);
}
@@ -1888,14 +1880,12 @@ class cmFileListGeneratorMacProject : public cmFileListGeneratorBase
public:
cmFileListGeneratorMacProject(std::vector<std::string> const& names,
const char* ext)
- : cmFileListGeneratorBase()
- , Names(names)
+ : Names(names)
, Extension(ext)
{
}
cmFileListGeneratorMacProject(cmFileListGeneratorMacProject const& r)
- : cmFileListGeneratorBase()
- , Names(r.Names)
+ : Names(r.Names)
, Extension(r.Extension)
{
}
@@ -1941,14 +1931,12 @@ class cmFileListGeneratorCaseInsensitive : public cmFileListGeneratorBase
{
public:
cmFileListGeneratorCaseInsensitive(std::string const& str)
- : cmFileListGeneratorBase()
- , String(str)
+ : String(str)
{
}
cmFileListGeneratorCaseInsensitive(
cmFileListGeneratorCaseInsensitive const& r)
- : cmFileListGeneratorBase()
- , String(r.String)
+ : String(r.String)
{
}
@@ -1985,13 +1973,11 @@ class cmFileListGeneratorGlob : public cmFileListGeneratorBase
{
public:
cmFileListGeneratorGlob(std::string const& str)
- : cmFileListGeneratorBase()
- , Pattern(str)
+ : Pattern(str)
{
}
cmFileListGeneratorGlob(cmFileListGeneratorGlob const& r)
- : cmFileListGeneratorBase()
- , Pattern(r.Pattern)
+ : Pattern(r.Pattern)
{
}
diff --git a/Source/cmGeneratedFileStream.cxx b/Source/cmGeneratedFileStream.cxx
index 186ec8c..789a399 100644
--- a/Source/cmGeneratedFileStream.cxx
+++ b/Source/cmGeneratedFileStream.cxx
@@ -12,8 +12,6 @@
#endif
cmGeneratedFileStream::cmGeneratedFileStream(Encoding encoding)
- : cmGeneratedFileStreamBase()
- , Stream()
{
#ifdef CMAKE_BUILD_WITH_CMAKE
if (encoding != codecvt::None) {
@@ -105,9 +103,7 @@ void cmGeneratedFileStream::SetCompressionExtraExtension(bool ext)
}
cmGeneratedFileStreamBase::cmGeneratedFileStreamBase()
- : Name()
- , TempName()
- , CopyIfDifferent(false)
+ : CopyIfDifferent(false)
, Okay(false)
, Compress(false)
, CompressExtraExtension(true)
@@ -115,9 +111,7 @@ cmGeneratedFileStreamBase::cmGeneratedFileStreamBase()
}
cmGeneratedFileStreamBase::cmGeneratedFileStreamBase(std::string const& name)
- : Name()
- , TempName()
- , CopyIfDifferent(false)
+ : CopyIfDifferent(false)
, Okay(false)
, Compress(false)
, CompressExtraExtension(true)
diff --git a/Source/cmGlobalNinjaGenerator.cxx b/Source/cmGlobalNinjaGenerator.cxx
index 5316b19..dcd2585 100644
--- a/Source/cmGlobalNinjaGenerator.cxx
+++ b/Source/cmGlobalNinjaGenerator.cxx
@@ -447,8 +447,6 @@ cmGlobalNinjaGenerator::cmGlobalNinjaGenerator(cmake* cm)
, BuildFileStream(nullptr)
, RulesFileStream(nullptr)
, CompileCommandsStream(nullptr)
- , Rules()
- , AllDependencies()
, UsingGCCOnWindows(false)
, ComputingUnknownDependencies(false)
, PolicyCMP0058(cmPolicies::WARN)
diff --git a/Source/cmInstallCommandArguments.cxx b/Source/cmInstallCommandArguments.cxx
index 06eb8a6..538aa9f 100644
--- a/Source/cmInstallCommandArguments.cxx
+++ b/Source/cmInstallCommandArguments.cxx
@@ -17,9 +17,7 @@ const std::string cmInstallCommandArguments::EmptyString;
cmInstallCommandArguments::cmInstallCommandArguments(
const std::string& defaultComponent)
- : Parser()
- , ArgumentGroup()
- , Destination(&Parser, "DESTINATION", &ArgumentGroup)
+ : Destination(&Parser, "DESTINATION", &ArgumentGroup)
, Component(&Parser, "COMPONENT", &ArgumentGroup)
, NamelinkComponent(&Parser, "NAMELINK_COMPONENT", &ArgumentGroup)
, ExcludeFromAll(&Parser, "EXCLUDE_FROM_ALL", &ArgumentGroup)
diff --git a/Source/cmLinkItem.cxx b/Source/cmLinkItem.cxx
index 121731d..f0d76df 100644
--- a/Source/cmLinkItem.cxx
+++ b/Source/cmLinkItem.cxx
@@ -7,8 +7,7 @@
#include <utility> // IWYU pragma: keep
cmLinkItem::cmLinkItem()
- : String()
- , Target(nullptr)
+ : Target(nullptr)
{
}
@@ -21,8 +20,7 @@ cmLinkItem::cmLinkItem(std::string const& n, cmListFileBacktrace const& bt)
cmLinkItem::cmLinkItem(cmGeneratorTarget const* t,
cmListFileBacktrace const& bt)
- : String()
- , Target(t)
+ : Target(t)
, Backtrace(bt)
{
}
diff --git a/Source/cmListFileCache.h b/Source/cmListFileCache.h
index 9e4a833..95b55a0 100644
--- a/Source/cmListFileCache.h
+++ b/Source/cmListFileCache.h
@@ -54,8 +54,7 @@ struct cmListFileArgument
Bracket
};
cmListFileArgument()
- : Value()
- , Delim(Unquoted)
+ : Delim(Unquoted)
, Line(0)
{
}
@@ -82,9 +81,7 @@ public:
std::string FilePath;
long Line;
cmListFileContext()
- : Name()
- , FilePath()
- , Line(0)
+ : Line(0)
{
}
diff --git a/Source/cmLocalUnixMakefileGenerator3.h b/Source/cmLocalUnixMakefileGenerator3.h
index 869ef1e..6d6288d 100644
--- a/Source/cmLocalUnixMakefileGenerator3.h
+++ b/Source/cmLocalUnixMakefileGenerator3.h
@@ -268,7 +268,6 @@ private:
std::string Language;
LocalObjectEntry()
: Target(nullptr)
- , Language()
{
}
LocalObjectEntry(cmGeneratorTarget* t, const std::string& lang)
diff --git a/Source/cmNinjaNormalTargetGenerator.cxx b/Source/cmNinjaNormalTargetGenerator.cxx
index c953d20..324afbf 100644
--- a/Source/cmNinjaNormalTargetGenerator.cxx
+++ b/Source/cmNinjaNormalTargetGenerator.cxx
@@ -37,13 +37,7 @@ class cmCustomCommand;
cmNinjaNormalTargetGenerator::cmNinjaNormalTargetGenerator(
cmGeneratorTarget* target)
: cmNinjaTargetGenerator(target)
- , TargetNameOut()
- , TargetNameSO()
- , TargetNameReal()
- , TargetNameImport()
- , TargetNamePDB()
, TargetLinkLanguage("")
- , DeviceLinkObject()
{
this->TargetLinkLanguage = target->GetLinkerLanguage(this->GetConfigName());
if (target->GetType() == cmStateEnums::EXECUTABLE) {
diff --git a/Source/cmNinjaTargetGenerator.cxx b/Source/cmNinjaTargetGenerator.cxx
index 7ac8d1b..228c9fb 100644
--- a/Source/cmNinjaTargetGenerator.cxx
+++ b/Source/cmNinjaTargetGenerator.cxx
@@ -54,10 +54,8 @@ cmNinjaTargetGenerator::cmNinjaTargetGenerator(cmGeneratorTarget* target)
: cmCommonTargetGenerator(target)
, MacOSXContentGenerator(nullptr)
, OSXBundleGenerator(nullptr)
- , MacContentFolders()
, LocalGenerator(
static_cast<cmLocalNinjaGenerator*>(target->GetLocalGenerator()))
- , Objects()
{
MacOSXContentGenerator = new MacOSXContentGeneratorType(this);
}
diff --git a/Source/cmStatePrivate.h b/Source/cmStatePrivate.h
index e76f2af..ec0ed6c 100644
--- a/Source/cmStatePrivate.h
+++ b/Source/cmStatePrivate.h
@@ -50,8 +50,7 @@ struct cmStateDetail::PolicyStackEntry : public cmPolicies::PolicyMap
{
typedef cmPolicies::PolicyMap derived;
PolicyStackEntry(bool w = false)
- : derived()
- , Weak(w)
+ : Weak(w)
{
}
PolicyStackEntry(derived const& d, bool w)
diff --git a/Source/cmStateSnapshot.cxx b/Source/cmStateSnapshot.cxx
index a649f5e..a4305e6 100644
--- a/Source/cmStateSnapshot.cxx
+++ b/Source/cmStateSnapshot.cxx
@@ -28,7 +28,6 @@
cmStateSnapshot::cmStateSnapshot(cmState* state)
: State(state)
- , Position()
{
}
diff --git a/Source/cmString.hxx b/Source/cmString.hxx
index 1623a43..e5ece52 100644
--- a/Source/cmString.hxx
+++ b/Source/cmString.hxx
@@ -625,8 +625,7 @@ private:
// Internal constructor for view of statically allocated string.
String(string_view v, Private)
- : string_()
- , view_(v)
+ : view_(v)
{
}
diff --git a/Source/cmStringReplaceHelper.h b/Source/cmStringReplaceHelper.h
index 938325a..3e76d86 100644
--- a/Source/cmStringReplaceHelper.h
+++ b/Source/cmStringReplaceHelper.h
@@ -46,7 +46,6 @@ private:
}
RegexReplacement(int n)
: Number(n)
- , Value()
{
}
RegexReplacement() {}
--
cgit v0.12