From 49017cddab23702d8228a195f64934e61ab7667e Mon Sep 17 00:00:00 2001 From: Stephen Kelly Date: Wed, 5 Aug 2015 18:41:53 +0200 Subject: cmGeneratorTarget: Move IsNullImpliedByLinkLibraries from cmTarget. --- Source/cmGeneratorTarget.cxx | 12 ++++++++++-- Source/cmGeneratorTarget.h | 3 +++ Source/cmTarget.cxx | 7 ------- Source/cmTarget.h | 3 --- 4 files changed, 13 insertions(+), 12 deletions(-) diff --git a/Source/cmGeneratorTarget.cxx b/Source/cmGeneratorTarget.cxx index 2f2fb3b..3651da6 100644 --- a/Source/cmGeneratorTarget.cxx +++ b/Source/cmGeneratorTarget.cxx @@ -3928,7 +3928,7 @@ PropertyType checkInterfacePropertyCompatibility(cmGeneratorTarget const* tgt, .find(p) != tgt->Target->GetProperties().end(); const bool impliedByUse = - tgt->Target->IsNullImpliedByLinkLibraries(p); + tgt->IsNullImpliedByLinkLibraries(p); assert((impliedByUse ^ explicitlySet) || (!impliedByUse && !explicitlySet)); @@ -5046,6 +5046,14 @@ cmGeneratorTarget::GetLinkImplementationLibrariesInternal( } //---------------------------------------------------------------------------- +bool +cmGeneratorTarget::IsNullImpliedByLinkLibraries(const std::string &p) const +{ + return this->LinkImplicitNullProperties.find(p) + != this->LinkImplicitNullProperties.end(); +} + +//---------------------------------------------------------------------------- void cmGeneratorTarget::ComputeLinkImplementationLibraries( const std::string& config, cmOptionalLinkImplementation& impl, @@ -5130,7 +5138,7 @@ void cmGeneratorTarget::ComputeLinkImplementationLibraries( { if (!this->GetProperty(*it)) { - this->Target->LinkImplicitNullProperties.insert(*it); + this->LinkImplicitNullProperties.insert(*it); } } cge->GetMaxLanguageStandard(this->Target, diff --git a/Source/cmGeneratorTarget.h b/Source/cmGeneratorTarget.h index 77d3b99..f0f6d41 100644 --- a/Source/cmGeneratorTarget.h +++ b/Source/cmGeneratorTarget.h @@ -317,6 +317,8 @@ public: typedef std::map CompileInfoMapType; mutable CompileInfoMapType CompileInfoMap; + bool IsNullImpliedByLinkLibraries(const std::string &p) const; + /** Get the name of the compiler pdb file for the target. */ std::string GetCompilePDBName(const std::string& config="") const; @@ -486,6 +488,7 @@ private: std::vector CompileFeaturesEntries; std::vector CompileDefinitionsEntries; std::vector SourceEntries; + mutable std::set LinkImplicitNullProperties; void ExpandLinkItems(std::string const& prop, std::string const& value, std::string const& config, cmTarget const* headTarget, diff --git a/Source/cmTarget.cxx b/Source/cmTarget.cxx index c20ce83..af7fe2e 100644 --- a/Source/cmTarget.cxx +++ b/Source/cmTarget.cxx @@ -2554,13 +2554,6 @@ const char* cmTarget::GetExportMacro() const } //---------------------------------------------------------------------------- -bool cmTarget::IsNullImpliedByLinkLibraries(const std::string &p) const -{ - return this->LinkImplicitNullProperties.find(p) - != this->LinkImplicitNullProperties.end(); -} - -//---------------------------------------------------------------------------- void cmTarget::GetObjectLibrariesCMP0026(std::vector& objlibs) const { diff --git a/Source/cmTarget.h b/Source/cmTarget.h index dda5384..a3a8063 100644 --- a/Source/cmTarget.h +++ b/Source/cmTarget.h @@ -326,8 +326,6 @@ public: void AppendBuildInterfaceIncludes(); - bool IsNullImpliedByLinkLibraries(const std::string &p) const; - std::string GetDebugGeneratorExpressions(const std::string &value, cmTarget::LinkLibraryType llt) const; @@ -439,7 +437,6 @@ private: std::set SystemIncludeDirectories; std::set LinkDirectoriesEmmitted; std::set Utilities; - mutable std::set LinkImplicitNullProperties; std::map UtilityBacktraces; cmPolicies::PolicyMap PolicyMap; std::string Name; -- cgit v0.12