From 89403bf87f21d9bccb9c73afb5df914cb88ec9ee Mon Sep 17 00:00:00 2001 From: "Yury G. Kudryashov" Date: Wed, 29 Feb 2012 11:49:42 +0400 Subject: Rename UsedCommands to FinalPassCommands When I read 'UsedCommands' I thought that it holds all commands used in the file, not only those that have FinalPass(). --- Source/cmMakefile.cxx | 10 +++++----- Source/cmMakefile.h | 8 +------- 2 files changed, 6 insertions(+), 12 deletions(-) diff --git a/Source/cmMakefile.cxx b/Source/cmMakefile.cxx index fdf5b31..a715f06 100644 --- a/Source/cmMakefile.cxx +++ b/Source/cmMakefile.cxx @@ -210,9 +210,9 @@ cmMakefile::~cmMakefile() { delete *i; } - for(unsigned int i=0; i < this->UsedCommands.size(); i++) + for(unsigned int i=0; i < this->FinalPassCommands.size(); i++) { - delete this->UsedCommands[i]; + delete this->FinalPassCommands[i]; } std::vector::iterator pos; for (pos = this->FunctionBlockers.begin(); @@ -421,7 +421,7 @@ bool cmMakefile::ExecuteCommand(const cmListFileFunction& lff, else if(pcmd->HasFinalPass()) { // use the command - this->UsedCommands.push_back(pcmd.release()); + this->FinalPassCommands.push_back(pcmd.release()); } } else if ( this->GetCMakeInstance()->GetWorkingMode() == cmake::SCRIPT_MODE @@ -813,8 +813,8 @@ void cmMakefile::FinalPass() // give all the commands a chance to do something // after the file has been parsed before generation - for(std::vector::iterator i = this->UsedCommands.begin(); - i != this->UsedCommands.end(); ++i) + for(std::vector::iterator i = this->FinalPassCommands.begin(); + i != this->FinalPassCommands.end(); ++i) { (*i)->FinalPass(); } diff --git a/Source/cmMakefile.h b/Source/cmMakefile.h index 1c46a73..f1f318a 100644 --- a/Source/cmMakefile.h +++ b/Source/cmMakefile.h @@ -620,12 +620,6 @@ public: */ bool CanIWriteThisFile(const char* fileName); - /** - * Get the vector of used command instances. - */ - const std::vector& GetUsedCommands() const - {return this->UsedCommands;} - #if defined(CMAKE_BUILD_WITH_CMAKE) /** * Get the vector source groups. @@ -913,7 +907,7 @@ protected: std::vector SourceGroups; #endif - std::vector UsedCommands; + std::vector FinalPassCommands; cmLocalGenerator* LocalGenerator; bool IsFunctionBlocked(const cmListFileFunction& lff, cmExecutionStatus &status); -- cgit v0.12