From 85aceda0262bff58a0126b2d4e75756e0507fe3c Mon Sep 17 00:00:00 2001 From: Ben Boeckel Date: Mon, 29 Oct 2018 15:49:44 -0400 Subject: cmNinjaNormalTargetGenerator: don't use `|| true` for link-what-you-use With the `|| true`, a linker error before running link-what-you-use would also use the `|| true` fragment and unconditionally succeed. Just skip the addition since `--lwyu=` ignores the return value anyways. Fixes #18524 --- Source/cmNinjaNormalTargetGenerator.cxx | 1 - 1 file changed, 1 deletion(-) diff --git a/Source/cmNinjaNormalTargetGenerator.cxx b/Source/cmNinjaNormalTargetGenerator.cxx index 6436969..1386706 100644 --- a/Source/cmNinjaNormalTargetGenerator.cxx +++ b/Source/cmNinjaNormalTargetGenerator.cxx @@ -506,7 +506,6 @@ std::vector cmNinjaNormalTargetGenerator::ComputeLinkCmd() gt.GetFullPath(cfgName, cmStateEnums::RuntimeBinaryArtifact, /*realname=*/true)); cmakeCommand += targetOutputReal; - cmakeCommand += " || true"; linkCmds.push_back(std::move(cmakeCommand)); } return linkCmds; -- cgit v0.12