From 50ca77f4a03b05c380c923f737e0b3aa00a4cf7d Mon Sep 17 00:00:00 2001
From: Sean McBride <sean@rogue-research.com>
Date: Fri, 28 Mar 2014 11:10:37 -0400
Subject: create_test_sourcelist: Initialize variable at declaration

Clang -Wconditional-uninitialized warns otherwise.
---
 Templates/TestDriver.cxx.in | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/Templates/TestDriver.cxx.in b/Templates/TestDriver.cxx.in
index 82537ef..0e0a872 100644
--- a/Templates/TestDriver.cxx.in
+++ b/Templates/TestDriver.cxx.in
@@ -58,7 +58,7 @@ static char* lowercase(const char *string)
 
 int main(int ac, char *av[])
 {
-  int i, NumTests, testNum, partial_match;
+  int i, NumTests, testNum = 0, partial_match;
   char *arg, *test_name;
   int count;
   int testToRun = -1;
@@ -81,7 +81,6 @@ int main(int ac, char *av[])
       }
     printf("To run a test, enter the test number: ");
     fflush(stdout);
-    testNum = 0;
     if( scanf("%d", &testNum) != 1 )
       {
       printf("Couldn't parse that input as a number\n");
-- 
cgit v0.12


From 8c9c4fe1a6d0c660c7e4e4c1af2cdf2e889fbfbd Mon Sep 17 00:00:00 2001
From: Sean McBride <sean@rogue-research.com>
Date: Fri, 28 Mar 2014 11:42:09 -0400
Subject: Remove 'return' statements that can never be reached

Clang -Wunreachable-code-return warns otherwise.
---
 Source/CursesDialog/cmCursesOptionsWidget.cxx | 1 -
 Source/cmSystemTools.cxx                      | 1 -
 2 files changed, 2 deletions(-)

diff --git a/Source/CursesDialog/cmCursesOptionsWidget.cxx b/Source/CursesDialog/cmCursesOptionsWidget.cxx
index 652b2df..d97c737 100644
--- a/Source/CursesDialog/cmCursesOptionsWidget.cxx
+++ b/Source/CursesDialog/cmCursesOptionsWidget.cxx
@@ -59,7 +59,6 @@ bool cmCursesOptionsWidget::HandleInput(int& key, cmCursesMainForm*, WINDOW* w)
     {
     return false;
     }
-  return false;
 }
 
 void cmCursesOptionsWidget::AddOption(std::string const & option )
diff --git a/Source/cmSystemTools.cxx b/Source/cmSystemTools.cxx
index ff05975..2f5f493 100644
--- a/Source/cmSystemTools.cxx
+++ b/Source/cmSystemTools.cxx
@@ -1662,7 +1662,6 @@ long copy_data(struct archive *ar, struct archive *aw)
       return (r);
       }
     }
-  return r;
 }
 
 bool extract_tar(const char* outFileName, bool verbose,
-- 
cgit v0.12