From dcaea54898cccb9ac1f675a395ac1793d1abfcfc Mon Sep 17 00:00:00 2001 From: Brad King Date: Mon, 23 Sep 2024 14:39:58 -0400 Subject: cmCTestCurl: Clarify names and logic using optional --- Source/CTest/cmCTestCurl.cxx | 4 ++-- Source/CTest/cmCTestSubmitHandler.cxx | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Source/CTest/cmCTestCurl.cxx b/Source/CTest/cmCTestCurl.cxx index 7137e63..6f887f3 100644 --- a/Source/CTest/cmCTestCurl.cxx +++ b/Source/CTest/cmCTestCurl.cxx @@ -84,11 +84,11 @@ bool cmCTestCurl::InitCurl() return false; } cmCurlSetCAInfo(this->Curl); - if (this->CurlOpts.TLSVersionOpt) { + if (this->CurlOpts.TLSVersionOpt.has_value()) { curl_easy_setopt(this->Curl, CURLOPT_SSLVERSION, *this->CurlOpts.TLSVersionOpt); } - if (this->CurlOpts.TLSVerifyOpt) { + if (this->CurlOpts.TLSVerifyOpt.has_value()) { curl_easy_setopt(this->Curl, CURLOPT_SSL_VERIFYPEER, *this->CurlOpts.TLSVerifyOpt ? 1 : 0); } diff --git a/Source/CTest/cmCTestSubmitHandler.cxx b/Source/CTest/cmCTestSubmitHandler.cxx index f05b874..91dea55 100644 --- a/Source/CTest/cmCTestSubmitHandler.cxx +++ b/Source/CTest/cmCTestSubmitHandler.cxx @@ -181,7 +181,7 @@ bool cmCTestSubmitHandler::SubmitUsingHTTP( curl = cm_curl_easy_init(); if (curl) { cmCurlSetCAInfo(curl); - if (curlOpts.TLSVersionOpt) { + if (curlOpts.TLSVersionOpt.has_value()) { cm::optional tlsVersionStr = cmCurlPrintTLSVersion(*curlOpts.TLSVersionOpt); cmCTestOptionalLog( @@ -191,7 +191,7 @@ bool cmCTestSubmitHandler::SubmitUsingHTTP( this->Quiet); curl_easy_setopt(curl, CURLOPT_SSLVERSION, *curlOpts.TLSVersionOpt); } - if (curlOpts.TLSVerifyOpt) { + if (curlOpts.TLSVerifyOpt.has_value()) { cmCTestOptionalLog(this->CTest, HANDLER_VERBOSE_OUTPUT, " Set CURLOPT_SSL_VERIFYPEER to " << (*curlOpts.TLSVerifyOpt ? "on" : "off") -- cgit v0.12