From 23370344427ce8da470ff6266a675150457fdda2 Mon Sep 17 00:00:00 2001 From: Stephen Kelly Date: Sat, 25 Apr 2015 16:29:54 +0200 Subject: cmDefinitions: Remove unused Set return value. --- Source/cmDefinitions.cxx | 8 +++----- Source/cmDefinitions.h | 2 +- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/Source/cmDefinitions.cxx b/Source/cmDefinitions.cxx index 6a27659..d5f6ebc 100644 --- a/Source/cmDefinitions.cxx +++ b/Source/cmDefinitions.cxx @@ -45,13 +45,12 @@ cmDefinitions::SetInternal(const std::string& key, Def const& def) if(this->Up || def.Exists) { // In lower scopes we store keys, defined or not. - return (this->Map[key] = def); + this->Map[key] = def; } else { // In the top-most scope we need not store undefined keys. this->Map.erase(key); - return this->NoDef; } } @@ -63,10 +62,9 @@ const char* cmDefinitions::Get(const std::string& key) } //---------------------------------------------------------------------------- -const char* cmDefinitions::Set(const std::string& key, const char* value) +void cmDefinitions::Set(const std::string& key, const char* value) { - Def const& def = this->SetInternal(key, Def(value)); - return def.Exists? def.c_str() : 0; + this->SetInternal(key, Def(value)); } //---------------------------------------------------------------------------- diff --git a/Source/cmDefinitions.h b/Source/cmDefinitions.h index ab588ee..690df1f 100644 --- a/Source/cmDefinitions.h +++ b/Source/cmDefinitions.h @@ -38,7 +38,7 @@ public: const char* Get(const std::string& key); /** Set (or unset if null) a value associated with a key. */ - const char* Set(const std::string& key, const char* value); + void Set(const std::string& key, const char* value); /** Get the set of all local keys. */ std::set LocalKeys() const; -- cgit v0.12