From 12f0e13c5f546a721d893adedba327c18c5c9e5e Mon Sep 17 00:00:00 2001 From: Stephen Kelly Date: Sat, 26 Sep 2015 17:50:55 +0200 Subject: QtAutogen: Simplify generator initialization API. --- Source/cmGlobalGenerator.cxx | 21 +++++++++++---------- Source/cmGlobalGenerator.h | 5 +---- 2 files changed, 12 insertions(+), 14 deletions(-) diff --git a/Source/cmGlobalGenerator.cxx b/Source/cmGlobalGenerator.cxx index 50906b8..5848a88 100644 --- a/Source/cmGlobalGenerator.cxx +++ b/Source/cmGlobalGenerator.cxx @@ -1251,8 +1251,8 @@ bool cmGlobalGenerator::Compute() #ifdef CMAKE_BUILD_WITH_CMAKE // Iterate through all targets and set up automoc for those which have // the AUTOMOC, AUTOUIC or AUTORCC property set - AutogensType autogens; - this->CreateQtAutoGeneratorsTargets(autogens); + std::vector autogenTargets = + this->CreateQtAutoGeneratorsTargets(); #endif unsigned int i; @@ -1266,10 +1266,10 @@ bool cmGlobalGenerator::Compute() this->InitGeneratorTargets(); #ifdef CMAKE_BUILD_WITH_CMAKE - for (AutogensType::iterator it = autogens.begin(); it != autogens.end(); - ++it) + for (std::vector::iterator it = autogenTargets.begin(); + it != autogenTargets.end(); ++it) { - it->first.SetupAutoGenerateTarget(it->second); + cmQtAutoGenerators::SetupAutoGenerateTarget(*it); } #endif @@ -1405,8 +1405,11 @@ bool cmGlobalGenerator::ComputeTargetDepends() } //---------------------------------------------------------------------------- -void cmGlobalGenerator::CreateQtAutoGeneratorsTargets(AutogensType &autogens) +std::vector +cmGlobalGenerator::CreateQtAutoGeneratorsTargets() { + std::vector autogenTargets; + #ifdef CMAKE_BUILD_WITH_CMAKE for(unsigned int i=0; i < this->LocalGenerators.size(); ++i) { @@ -1458,13 +1461,11 @@ void cmGlobalGenerator::CreateQtAutoGeneratorsTargets(AutogensType &autogens) ->GetMakefile()->FindTarget(*ti, true); cmQtAutoGenerators::InitializeAutogenTarget( this->LocalGenerators[i], target); - cmQtAutoGenerators autogen; - autogens.push_back(std::make_pair(autogen, target)); + autogenTargets.push_back(target); } } -#else - (void)autogens; #endif + return autogenTargets; } //---------------------------------------------------------------------------- diff --git a/Source/cmGlobalGenerator.h b/Source/cmGlobalGenerator.h index 83cbc3f..f3dd713 100644 --- a/Source/cmGlobalGenerator.h +++ b/Source/cmGlobalGenerator.h @@ -41,7 +41,6 @@ class cmTarget; class cmInstallTargetGenerator; class cmInstallFilesGenerator; class cmExportBuildFileGenerator; -class cmQtAutoGenerators; /** \class cmGlobalGenerator * \brief Responsible for overseeing the generation process for the entire tree @@ -385,9 +384,7 @@ protected: virtual bool CheckALLOW_DUPLICATE_CUSTOM_TARGETS() const; - typedef std::vector > AutogensType; - void CreateQtAutoGeneratorsTargets(AutogensType& autogens); + std::vector CreateQtAutoGeneratorsTargets(); std::string SelectMakeProgram(const std::string& makeProgram, const std::string& makeDefault = "") const; -- cgit v0.12