From bd49ae5109cb8bf0fc1110bab8b829f5f28bfdd9 Mon Sep 17 00:00:00 2001
From: Sebastian Holtermann <sebholt@xwmw.org>
Date: Thu, 7 Dec 2017 11:53:49 +0100
Subject: Autogen: Fix library dependency forwarding to _autogen target

Library dependencies of the origin target were forwarded to the
_autogen target as source file dependencies. This is fixed by
forwarding the dependencies as target dependencies instead.

Issue: #17278
---
 Source/cmQtAutoGeneratorInitializer.cxx | 45 ++++++++++++++++-----------------
 1 file changed, 22 insertions(+), 23 deletions(-)

diff --git a/Source/cmQtAutoGeneratorInitializer.cxx b/Source/cmQtAutoGeneratorInitializer.cxx
index bd692a2..14743de 100644
--- a/Source/cmQtAutoGeneratorInitializer.cxx
+++ b/Source/cmQtAutoGeneratorInitializer.cxx
@@ -821,40 +821,39 @@ void cmQtAutoGeneratorInitializer::InitCustomTargets()
       this->Target->Target->AddPreBuildCommand(cc);
     } else {
 
-      // Convert file dependencies std::set to std::vector
-      std::vector<std::string> autogenDepends(autogenDependFiles.begin(),
-                                              autogenDependFiles.end());
-
       // Add link library target dependencies to the autogen target
       // dependencies
-      for (std::string const& config : this->ConfigsList) {
-        cmLinkImplementationLibraries const* libs =
-          this->Target->GetLinkImplementationLibraries(config);
-        if (libs != nullptr) {
-          for (cmLinkItem const& item : libs->Libraries) {
-            cmGeneratorTarget const* libTarget = item.Target;
-            if ((libTarget != nullptr) &&
-                !StaticLibraryCycle(this->Target, libTarget, config)) {
-              std::string util;
-              if (this->ConfigsList.size() > 1) {
-                util += "$<$<CONFIG:";
-                util += config;
-                util += ">:";
-              }
-              util += libTarget->GetName();
-              if (this->ConfigsList.size() > 1) {
-                util += ">";
+      {
+        // add_dependencies/addUtility do not support generator expressions.
+        // We depend only on the libraries found in all configs therefore.
+        std::map<cmGeneratorTarget const*, std::size_t> commonTargets;
+        for (std::string const& config : this->ConfigsList) {
+          cmLinkImplementationLibraries const* libs =
+            this->Target->GetLinkImplementationLibraries(config);
+          if (libs != nullptr) {
+            for (cmLinkItem const& item : libs->Libraries) {
+              cmGeneratorTarget const* libTarget = item.Target;
+              if ((libTarget != nullptr) &&
+                  !StaticLibraryCycle(this->Target, libTarget, config)) {
+                // Increment target config count
+                commonTargets[libTarget]++;
               }
-              autogenDepends.push_back(util);
             }
           }
         }
+        for (auto const& item : commonTargets) {
+          if (item.second == this->ConfigsList.size()) {
+            autogenDependTargets.insert(item.first->Target);
+          }
+        }
       }
 
       // Create autogen target
       cmTarget* autogenTarget = makefile->AddUtilityCommand(
         this->AutogenTargetName, cmMakefile::TargetOrigin::Generator, true,
-        this->DirWork.c_str(), /*byproducts=*/autogenProvides, autogenDepends,
+        this->DirWork.c_str(), /*byproducts=*/autogenProvides,
+        std::vector<std::string>(autogenDependFiles.begin(),
+                                 autogenDependFiles.end()),
         commandLines, false, autogenComment.c_str());
       // Create autogen generator target
       localGen->AddGeneratorTarget(
-- 
cgit v0.12