From a58e3c7e8b2d38a788c284b2fdc21c3da1935fd3 Mon Sep 17 00:00:00 2001 From: Brad King Date: Thu, 1 Oct 2020 15:31:12 -0400 Subject: ci: Skip the Module.ExternalData test on Windows This test spuriously fails too frequently and breaks our pipelines. Pending further investigation into the race causing the failure, skip the test on Windows for now. The module is well covered by the test on other platforms anyway. --- .gitlab/ci/ctest_exclusions.cmake | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/.gitlab/ci/ctest_exclusions.cmake b/.gitlab/ci/ctest_exclusions.cmake index b885a6a..a68a693 100644 --- a/.gitlab/ci/ctest_exclusions.cmake +++ b/.gitlab/ci/ctest_exclusions.cmake @@ -13,6 +13,15 @@ if (CTEST_CMAKE_GENERATOR MATCHES "Visual Studio") "^ExternalProjectUpdateSetup$") endif () +if (CMAKE_HOST_WIN32) + list(APPEND test_exclusions + # This test often fails with an undiagnosed subtle race due to the test + # re-using the same objects for many files. Some copy operations fail + # to open their input with ERROR_SHARING_VIOLATION. + "^Module.ExternalData$" + ) +endif() + string(REPLACE ";" "|" test_exclusions "${test_exclusions}") if (test_exclusions) set(test_exclusions "(${test_exclusions})") -- cgit v0.12