From 28513a5fbaa5e1ea326c54b4e5edd1d302c257dd Mon Sep 17 00:00:00 2001 From: Brad King Date: Fri, 18 Nov 2022 09:09:36 -0500 Subject: Tests: Honor CMake_TEST_NO_NETWORK in RunCMake.file-DOWNLOAD Most of the test uses `file://` URLs instead of hitting the network. However, a case covering an invalid hostname does try to make a real connection, expecting it to fail DNS resolution. Turn off that case if we are asked not to hit the network during testing. --- Tests/RunCMake/CMakeLists.txt | 2 +- Tests/RunCMake/file-DOWNLOAD/RunCMakeTest.cmake | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/Tests/RunCMake/CMakeLists.txt b/Tests/RunCMake/CMakeLists.txt index 4e0783d..0fe4919 100644 --- a/Tests/RunCMake/CMakeLists.txt +++ b/Tests/RunCMake/CMakeLists.txt @@ -466,7 +466,7 @@ add_RunCMake_test(ctest_fixtures) add_RunCMake_test(define_property) add_RunCMake_test(file -DCYGWIN=${CYGWIN} -DMSYS=${MSYS}) add_RunCMake_test(file-CHMOD -DMSYS=${MSYS}) -add_RunCMake_test(file-DOWNLOAD) +add_RunCMake_test(file-DOWNLOAD -DCMake_TEST_NO_NETWORK=${CMake_TEST_NO_NETWORK}) add_RunCMake_test(file-RPATH -DCMAKE_SYSTEM_NAME=${CMAKE_SYSTEM_NAME}) add_RunCMake_test(find_file) add_RunCMake_test(find_library -DCYGWIN=${CYGWIN} -DMSYS=${MSYS}) diff --git a/Tests/RunCMake/file-DOWNLOAD/RunCMakeTest.cmake b/Tests/RunCMake/file-DOWNLOAD/RunCMakeTest.cmake index 01da3fc..565f440 100644 --- a/Tests/RunCMake/file-DOWNLOAD/RunCMakeTest.cmake +++ b/Tests/RunCMake/file-DOWNLOAD/RunCMakeTest.cmake @@ -14,10 +14,13 @@ run_cmake(tls-verify-not-set) run_cmake(pass-not-set) run_cmake(no-save-hash) -run_cmake(bad-hostname) run_cmake(basic) run_cmake(EXPECTED_HASH) run_cmake(file-without-path) run_cmake(no-file) run_cmake(range) run_cmake(SHOW_PROGRESS) + +if(NOT CMake_TEST_NO_NETWORK) + run_cmake(bad-hostname) +endif() -- cgit v0.12