From 304ab71db0fa68ff5cfe5e63adac6ade76ef6f31 Mon Sep 17 00:00:00 2001 From: Daniel Pfeifer Date: Thu, 28 Apr 2016 00:48:15 +0200 Subject: Clang-Tidy: Give entire compiler command line to clant-tidy tool The tool expects the entire compiler command, including `cc`. It will automatically skip that and extract the options it needs. --- Source/cmcmd.cxx | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/Source/cmcmd.cxx b/Source/cmcmd.cxx index 0b9518c..19f3886 100644 --- a/Source/cmcmd.cxx +++ b/Source/cmcmd.cxx @@ -382,12 +382,14 @@ int cmcmd::ExecuteCMakeCommand(std::vector& args) if (!tidy.empty()) { // Construct the clang-tidy command line by taking what was given - // and adding all the arguments we give to the compiler. + // and adding our compiler command line. The clang-tidy tool will + // automatically skip over the compiler itself and extract the + // options. std::vector tidy_cmd; cmSystemTools::ExpandListArgument(tidy, tidy_cmd, true); tidy_cmd.push_back(sourceFile); tidy_cmd.push_back("--"); - tidy_cmd.insert(tidy_cmd.end(), orig_cmd.begin()+1, orig_cmd.end()); + tidy_cmd.insert(tidy_cmd.end(), orig_cmd.begin(), orig_cmd.end()); // Run the tidy command line. Capture its stdout and hide its stderr. std::string stdOut; -- cgit v0.12