From 1aa4f97c9737fa077d2279c422f68ac6facde782 Mon Sep 17 00:00:00 2001 From: Craig Scott Date: Sun, 28 Mar 2021 12:18:09 +1100 Subject: cmCTestGenericHandler: Remove unused Command member This was causing a cppcheck warning about an uninitialized member in the constructor. Since nothing was using it, remove it. --- Source/CTest/cmCTestGenericHandler.h | 4 ---- Source/CTest/cmCTestUpdateCommand.cxx | 1 - 2 files changed, 5 deletions(-) diff --git a/Source/CTest/cmCTestGenericHandler.h b/Source/CTest/cmCTestGenericHandler.h index 6f44545..e846fd9 100644 --- a/Source/CTest/cmCTestGenericHandler.h +++ b/Source/CTest/cmCTestGenericHandler.h @@ -13,7 +13,6 @@ #include "cmCTest.h" #include "cmSystemTools.h" -class cmCTestCommand; class cmGeneratedFileStream; class cmMakefile; @@ -107,8 +106,6 @@ public: void AddMultiOption(const std::string& optionName, const std::string& value); std::vector GetMultiOption(const std::string& op) const; - void SetCommand(cmCTestCommand* command) { this->Command = command; } - void SetSubmitIndex(int idx) { this->SubmitIndex = idx; } int GetSubmitIndex() { return this->SubmitIndex; } @@ -134,6 +131,5 @@ protected: t_StringToMultiString PersistentMultiOptions; t_StringToString LogFileNames; - cmCTestCommand* Command; int SubmitIndex; }; diff --git a/Source/CTest/cmCTestUpdateCommand.cxx b/Source/CTest/cmCTestUpdateCommand.cxx index 0ba2c41..797cb01 100644 --- a/Source/CTest/cmCTestUpdateCommand.cxx +++ b/Source/CTest/cmCTestUpdateCommand.cxx @@ -75,7 +75,6 @@ cmCTestGenericHandler* cmCTestUpdateCommand::InitializeHandler() cmCTestUpdateHandler* handler = this->CTest->GetUpdateHandler(); handler->Initialize(); - handler->SetCommand(this); if (source_dir.empty()) { this->SetError("source directory not specified. Please use SOURCE tag"); return nullptr; -- cgit v0.12