From b82052feb861f111b2373b2261dcf30a37c31b65 Mon Sep 17 00:00:00 2001 From: Smit tay Date: Sun, 2 May 2021 14:55:16 +0200 Subject: Help/dev/review: Clarify instructions to update existing merge requests --- Help/dev/review.rst | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/Help/dev/review.rst b/Help/dev/review.rst index 10ff87b..198e100 100644 --- a/Help/dev/review.rst +++ b/Help/dev/review.rst @@ -20,8 +20,10 @@ creating a *merge request* ("MR"). The new MR will appear on the process is managed by the merge request page for the change. During the review process, the MR submitter should address review comments -or test failures by updating the MR with a (force-)push of the topic -branch. The update initiates a new round of review. +or test failures by updating their local topic branch to fix their commits +(e.g. via ``git commit --amend`` or ``git rebase -i``), and then issuing a +(force-)push of the topic branch to their remote (e.g. ``git push --force``). +This will automatically initiate a new round of review on the existing MR. We recommend that users enable the "Remove source branch when merge request is accepted" option when creating the MR or by editing it. -- cgit v0.12