summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDimitri van Heesch <dimitri@stack.nl>2015-07-25 19:13:45 (GMT)
committerDimitri van Heesch <dimitri@stack.nl>2015-07-25 19:13:45 (GMT)
commitf88c49aa678f7d5e5facd7734358548d0d32722f (patch)
tree144672e5245a9a770cf192b042db35c0a68c7565
parent45e153f2238d0fa031d147cfe207e52b913845eb (diff)
parent64adce8b82c332b3855cdfaaa71afc984ffc4ca9 (diff)
downloadDoxygen-f88c49aa678f7d5e5facd7734358548d0d32722f.zip
Doxygen-f88c49aa678f7d5e5facd7734358548d0d32722f.tar.gz
Doxygen-f88c49aa678f7d5e5facd7734358548d0d32722f.tar.bz2
Merge pull request #365 from jcrada/master
Fixes bug 485701: Angle brackets (< and >) not escaped in HTML formula alt text
-rw-r--r--src/htmldocvisitor.cpp20
1 files changed, 2 insertions, 18 deletions
diff --git a/src/htmldocvisitor.cpp b/src/htmldocvisitor.cpp
index 99d6fdd..0ce4030 100644
--- a/src/htmldocvisitor.cpp
+++ b/src/htmldocvisitor.cpp
@@ -1902,24 +1902,8 @@ void HtmlDocVisitor::filterQuotedCdataAttr(const char* str)
{
case '&': m_t << "&amp;"; break;
case '"': m_t << "&quot;"; break;
- // For SGML compliance, and given the SGML declaration for HTML syntax,
- // it's enough to replace these two, provided that the declaration
- // for the HTML version we generate (and as supported by the browser)
- // specifies that all the other symbols used in rawVal are
- // within the right character class (i.e., they're not
- // some multinational weird characters not in the BASESET).
- // We assume that 1) the browser will support whatever is remaining
- // in the formula and 2) the TeX formulae are generally governed
- // by even stricter character restrictions so it should be enough.
- //
- // On some incompliant browsers, additional translation of
- // '>' and '<' into "&gt;" and "&lt;", respectively, might be needed;
- // but I'm unaware of particular modern (last 4 years) versions
- // with such problems, so let's not do it for performance.
- // Also, some brousers will (wrongly) not process the entity references
- // inside the attribute value and show the &...; form instead,
- // so we won't create entites unless necessary to minimize clutter there.
- // --vassilii
+ case '<': m_t << "&lt;"; break;
+ case '>': m_t << "&gt;"; break;
default: m_t << c;
}
}