From e97e5f0b35f6a70b9d69f1290a6c7e3685409b91 Mon Sep 17 00:00:00 2001 From: albert-github Date: Mon, 15 Mar 2021 12:52:09 +0100 Subject: Warnings regarding Internal inconsistency: namespace in IDL n the ACE TAO package we find a number of warnings like: ``` .../ACE_TAO/ACE/html/libtao-doc/security/TAO_Security.tag:1: error: Internal inconsistency: namespace in IDL not module, library or constant group .../ACE_TAO/TAO/orbsvcs/orbsvcs/CosEventChannelAdmin.idl:30: error: Internal inconsistency: namespace in IDL not module, library or constant group ``` There are a number of reasons for these warnings a.o. IDL modules not handled properly but seen as namespaces and when type is not an IDL modules a warning is given. This happens especially when the module is documented with `@namespace` or there is a namespace definition with the same name in a C++ file (which is just a mapping between IDL and C++). Based on the discussion in https://github.com/DOCGroup/ACE_TAO/pull/1450#issuecomment-799277574 and the results from pull request #8429 a new version has been crated with just the extra test this just removes all Internal inconsistency warnings. --- src/namespacedef.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/namespacedef.cpp b/src/namespacedef.cpp index 7acd463..b1d9722 100644 --- a/src/namespacedef.cpp +++ b/src/namespacedef.cpp @@ -79,7 +79,7 @@ class NamespaceDefImpl : public DefinitionMixin virtual QCString localName() const; virtual void setInline(bool isInline) { m_inline = isInline; } virtual bool isConstantGroup() const { return CONSTANT_GROUP == m_type; } - virtual bool isModule() const { return MODULE == m_type; } + virtual bool isModule() const { return NAMESPACE == m_type || MODULE == m_type; } virtual bool isLibrary() const { return LIBRARY == m_type; } virtual bool isInline() const { return m_inline; } virtual bool isLinkableInProject() const; -- cgit v0.12