From fabc36878377119b13bb5b20dff0026d8dd350a5 Mon Sep 17 00:00:00 2001
From: albert-github <albert.tests@gmail.com>
Date: Thu, 13 Jun 2019 15:33:40 +0200
Subject: Bug 489766 - Wrong MSC syntax rejected *silently*

In case of an error at least a message (consistency) should be given (besides msc also for dia and htags).
---
 src/dia.cpp   | 2 ++
 src/htags.cpp | 4 ++++
 src/msc.cpp   | 4 ++++
 3 files changed, 10 insertions(+)

diff --git a/src/dia.cpp b/src/dia.cpp
index 5adbc7c..8dab5b0 100644
--- a/src/dia.cpp
+++ b/src/dia.cpp
@@ -65,6 +65,8 @@ void writeDiaGraphFromFile(const char *inFile,const char *outDir,
   portable_sysTimerStart();
   if ((exitCode=portable_system(diaExe,diaArgs,FALSE))!=0)
   {
+    err("Problems running %s. Check your installation or look typos in you dia file %s\n",
+        diaExe.data(),inFile);
     portable_sysTimerStop();
     goto error;
   }
diff --git a/src/htags.cpp b/src/htags.cpp
index 7f5870d..51cd6d9 100644
--- a/src/htags.cpp
+++ b/src/htags.cpp
@@ -91,6 +91,10 @@ bool Htags::execute(const QCString &htmldir)
   //printf("CommandLine=[%s]\n",commandLine.data());
   portable_sysTimerStart();
   bool result=portable_system("htags",commandLine,FALSE)==0;
+  if (!result)
+  {
+    err("Problems running %s. Check your installation\n", "htags");
+  }
   portable_sysTimerStop();
   QDir::setCurrent(oldDir);
   return result;
diff --git a/src/msc.cpp b/src/msc.cpp
index 29f96ac..eb75fe1 100644
--- a/src/msc.cpp
+++ b/src/msc.cpp
@@ -132,6 +132,8 @@ void writeMscGraphFromFile(const char *inFile,const char *outDir,
   portable_sysTimerStart();
   if ((exitCode=portable_system(mscExe,mscArgs,FALSE))!=0)
   {
+    err("Problems running %s. Check your installation or look typos in you msc file %s\n",
+        mscExe.data(),inFile);
     portable_sysTimerStop();
     goto error;
   }
@@ -178,6 +180,8 @@ QCString getMscImageMapFromFile(const QCString& inFile, const QCString& outDir,
   portable_sysTimerStart();
   if ((exitCode=portable_system(mscExe,mscArgs,FALSE))!=0)
   {
+    err("Problems running %s (mapping phase). Check your installation or look typos in you msc file %s\n",
+        mscExe.data(),inFile);
     portable_sysTimerStop();
     QDir::setCurrent(oldDir);
     return "";
-- 
cgit v0.12